From nobody@FreeBSD.org  Sat Jul 17 11:02:52 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 493DA1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 17 Jul 2010 11:02:52 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id ED8BB8FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 17 Jul 2010 11:02:51 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6HB2piU045404
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 17 Jul 2010 11:02:51 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o6HB2pR3045403;
	Sat, 17 Jul 2010 11:02:51 GMT
	(envelope-from nobody)
Message-Id: <201007171102.o6HB2pR3045403@www.freebsd.org>
Date: Sat, 17 Jul 2010 11:02:51 GMT
From: Galimov Albert <wtfcrap@mail.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [sysctl][patch] Document sys/kern sysctls
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         148710
>Category:       kern
>Synopsis:       [sysctl][patch] Document sys/kern sysctls
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 17 11:10:02 UTC 2010
>Closed-Date:    Sun Nov 21 13:06:50 UTC 2010
>Last-Modified:  Sun Nov 21 13:06:50 UTC 2010
>Originator:     Galimov Albert
>Release:        HEAD
>Organization:
>Environment:
>Description:
Descriptions for sysctls from sys/kern/sysv_sem.c sys/kern/kern_proc.c sys/kern/subr_clock.c sys/kern/kern_tc.c sys/kern/subr_rtc.c sys/kern/vfs_cache.c
>How-To-Repeat:

>Fix:
patch

Patch attached with submission follows:

Index: sys/kern/sysv_sem.c
===================================================================
--- sys/kern/sysv_sem.c	(revision 210019)
+++ sys/kern/sysv_sem.c	(working copy)
@@ -212,7 +212,7 @@
 SYSCTL_INT(_kern_ipc, OID_AUTO, semaem, CTLFLAG_RW, &seminfo.semaem, 0,
     "Adjust on exit max value");
 SYSCTL_PROC(_kern_ipc, OID_AUTO, sema, CTLFLAG_RD,
-    NULL, 0, sysctl_sema, "", "");
+    NULL, 0, sysctl_sema, "", "semaphore id pool");
 
 static struct syscall_helper_data sem_syscalls[] = {
 	SYSCALL_INIT_HELPER(__semctl),
Index: sys/kern/kern_proc.c
===================================================================
--- sys/kern/kern_proc.c	(revision 210019)
+++ sys/kern/kern_proc.c	(working copy)
@@ -148,7 +148,7 @@
 uma_zone_t proc_zone;
 
 int kstack_pages = KSTACK_PAGES;
-SYSCTL_INT(_kern, OID_AUTO, kstack_pages, CTLFLAG_RD, &kstack_pages, 0, "");
+SYSCTL_INT(_kern, OID_AUTO, kstack_pages, CTLFLAG_RD, &kstack_pages, 0, "KSTACK_PAGES is the number of memory pages to assigned to the kernel");
 
 CTASSERT(sizeof(struct kinfo_proc) == KINFO_PROC_SIZE);
 #ifdef COMPAT_FREEBSD32
Index: sys/kern/subr_clock.c
===================================================================
--- sys/kern/subr_clock.c	(revision 210019)
+++ sys/kern/subr_clock.c	(working copy)
@@ -61,7 +61,7 @@
  * kern.
  */
 SYSCTL_INT(_machdep, OID_AUTO, wall_cmos_clock,
-	CTLFLAG_RW, &wall_cmos_clock, 0, "");
+	CTLFLAG_RW, &wall_cmos_clock, 0, "wall CMOS clock assumed if != 0");
 
 static int
 sysctl_machdep_adjkerntz(SYSCTL_HANDLER_ARGS)
@@ -74,7 +74,7 @@
 }
 
 SYSCTL_PROC(_machdep, OID_AUTO, adjkerntz, CTLTYPE_INT|CTLFLAG_RW,
-	&adjkerntz, 0, sysctl_machdep_adjkerntz, "I", "");
+	&adjkerntz, 0, sysctl_machdep_adjkerntz, "I", "local offset from GMT in seconds");
 
 /*--------------------------------------------------------------------*
  * Generic routines to convert between a POSIX date
Index: sys/kern/kern_tc.c
===================================================================
--- sys/kern/kern_tc.c	(revision 210019)
+++ sys/kern/kern_tc.c	(working copy)
@@ -101,7 +101,7 @@
 
 static int timestepwarnings;
 SYSCTL_INT(_kern_timecounter, OID_AUTO, stepwarnings, CTLFLAG_RW,
-    &timestepwarnings, 0, "");
+    &timestepwarnings, 0, "Log warnings");
 
 static void tc_windup(void);
 static void cpu_tick_calibrate(int);
@@ -556,7 +556,7 @@
 }
 
 SYSCTL_PROC(_kern_timecounter, OID_AUTO, hardware, CTLTYPE_STRING | CTLFLAG_RW,
-    0, 0, sysctl_kern_timecounter_hardware, "A", "");
+    0, 0, sysctl_kern_timecounter_hardware, "A", "Report or change the active timecounter hardware selected");
 
 
 /* Report or change the active timecounter hardware. */
@@ -579,7 +579,7 @@
 }
 
 SYSCTL_PROC(_kern_timecounter, OID_AUTO, choice, CTLTYPE_STRING | CTLFLAG_RD,
-    0, 0, sysctl_kern_timecounter_choice, "A", "");
+    0, 0, sysctl_kern_timecounter_choice, "A", "Report the active timecounter hardware detected");
 
 /*
  * RFC 2783 PPS-API implementation.
@@ -764,7 +764,7 @@
  */
 
 static int tc_tick;
-SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0, "");
+SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0, "approx. number of hardclock ticks in a millisecond");
 
 void
 tc_ticktock(void)
Index: sys/kern/subr_rtc.c
===================================================================
--- sys/kern/subr_rtc.c	(revision 210019)
+++ sys/kern/subr_rtc.c	(working copy)
@@ -66,7 +66,7 @@
 /* XXX: should be kern. now, it's no longer machdep.  */
 static int disable_rtc_set;
 SYSCTL_INT(_machdep, OID_AUTO, disable_rtc_set,
-	CTLFLAG_RW, &disable_rtc_set, 0, "");
+	CTLFLAG_RW, &disable_rtc_set, 0, "Disable write system time back to RTC");
 
 void
 clock_register(device_t dev, long res)	/* res has units of microseconds */
Index: sys/kern/vfs_cache.c
===================================================================
--- sys/kern/vfs_cache.c	(revision 210019)
+++ sys/kern/vfs_cache.c	(working copy)
@@ -126,18 +126,18 @@
 static LIST_HEAD(nchashhead, namecache) *nchashtbl;	/* Hash Table */
 static TAILQ_HEAD(, namecache) ncneg;	/* Hash Table */
 static u_long	nchash;			/* size of hash table */
-SYSCTL_ULONG(_debug, OID_AUTO, nchash, CTLFLAG_RD, &nchash, 0, "");
+SYSCTL_ULONG(_debug, OID_AUTO, nchash, CTLFLAG_RD, &nchash, 0, "size of hash table");
 static u_long	ncnegfactor = 16;	/* ratio of negative entries */
-SYSCTL_ULONG(_debug, OID_AUTO, ncnegfactor, CTLFLAG_RW, &ncnegfactor, 0, "");
-static u_long	numneg;			/* number of cache entries allocated */
-SYSCTL_ULONG(_debug, OID_AUTO, numneg, CTLFLAG_RD, &numneg, 0, "");
+SYSCTL_ULONG(_debug, OID_AUTO, ncnegfactor, CTLFLAG_RW, &ncnegfactor, 0, "ratio of negative entries");
+static u_long	numneg;			/* number of negative cache entries allocated */
+SYSCTL_ULONG(_debug, OID_AUTO, numneg, CTLFLAG_RD, &numneg, 0, "number of negative cache entries allocated");
 static u_long	numcache;		/* number of cache entries allocated */
-SYSCTL_ULONG(_debug, OID_AUTO, numcache, CTLFLAG_RD, &numcache, 0, "");
+SYSCTL_ULONG(_debug, OID_AUTO, numcache, CTLFLAG_RD, &numcache, 0, "number of cache entries allocated");
 static u_long	numcachehv;		/* number of cache entries with vnodes held */
-SYSCTL_ULONG(_debug, OID_AUTO, numcachehv, CTLFLAG_RD, &numcachehv, 0, "");
+SYSCTL_ULONG(_debug, OID_AUTO, numcachehv, CTLFLAG_RD, &numcachehv, 0, "number of cache entries with vnodes held");
 #if 0
 static u_long	numcachepl;		/* number of cache purge for leaf entries */
-SYSCTL_ULONG(_debug, OID_AUTO, numcachepl, CTLFLAG_RD, &numcachepl, 0, "");
+SYSCTL_ULONG(_debug, OID_AUTO, numcachepl, CTLFLAG_RD, &numcachepl, 0, "number of cache purge for leaf entries");
 #endif
 struct	nchstats nchstats;		/* cache effectiveness statistics */
 
@@ -174,31 +174,31 @@
 } while (0)
 
 static int	doingcache = 1;		/* 1 => enable the cache */
-SYSCTL_INT(_debug, OID_AUTO, vfscache, CTLFLAG_RW, &doingcache, 0, "");
+SYSCTL_INT(_debug, OID_AUTO, vfscache, CTLFLAG_RW, &doingcache, 0, "enable the cache");
 
 /* Export size information to userland */
 SYSCTL_INT(_debug_sizeof, OID_AUTO, namecache, CTLFLAG_RD, 0,
-	sizeof(struct namecache), "");
+	sizeof(struct namecache), "Export size information to userland");
 
 /*
  * The new name cache statistics
  */
 static SYSCTL_NODE(_vfs, OID_AUTO, cache, CTLFLAG_RW, 0, "Name cache statistics");
-#define STATNODE(mode, name, var) \
-	SYSCTL_ULONG(_vfs_cache, OID_AUTO, name, mode, var, 0, "");
-STATNODE(CTLFLAG_RD, numneg, &numneg);
-STATNODE(CTLFLAG_RD, numcache, &numcache);
-static u_long numcalls; STATNODE(CTLFLAG_RD, numcalls, &numcalls);
-static u_long dothits; STATNODE(CTLFLAG_RD, dothits, &dothits);
-static u_long dotdothits; STATNODE(CTLFLAG_RD, dotdothits, &dotdothits);
-static u_long numchecks; STATNODE(CTLFLAG_RD, numchecks, &numchecks);
-static u_long nummiss; STATNODE(CTLFLAG_RD, nummiss, &nummiss);
-static u_long nummisszap; STATNODE(CTLFLAG_RD, nummisszap, &nummisszap);
-static u_long numposzaps; STATNODE(CTLFLAG_RD, numposzaps, &numposzaps);
-static u_long numposhits; STATNODE(CTLFLAG_RD, numposhits, &numposhits);
-static u_long numnegzaps; STATNODE(CTLFLAG_RD, numnegzaps, &numnegzaps);
-static u_long numneghits; STATNODE(CTLFLAG_RD, numneghits, &numneghits);
-static u_long numupgrades; STATNODE(CTLFLAG_RD, numupgrades, &numupgrades);
+#define STATNODE(mode, name, var, descr) \
+	SYSCTL_ULONG(_vfs_cache, OID_AUTO, name, mode, var, 0, descr);
+STATNODE(CTLFLAG_RD, numneg, &numneg, "number of negative cache entries allocated");
+STATNODE(CTLFLAG_RD, numcache, &numcache, "number of cache entries allocated");
+static u_long numcalls; STATNODE(CTLFLAG_RD, numcalls, &numcalls, "# cache lookups");
+static u_long dothits; STATNODE(CTLFLAG_RD, dothits, &dothits, " # '.' hits");
+static u_long dotdothits; STATNODE(CTLFLAG_RD, dotdothits, &dotdothits, " # '..' hits");
+static u_long numchecks; STATNODE(CTLFLAG_RD, numchecks, &numchecks, "# checks in lookup");
+static u_long nummiss; STATNODE(CTLFLAG_RD, nummiss, &nummiss, "# cache miss");
+static u_long nummisszap; STATNODE(CTLFLAG_RD, nummisszap, &nummisszap, "# cache miss we dont want to cache");
+static u_long numposhits; STATNODE(CTLFLAG_RD, numposhits, &numposhits, "# cache hits (positive)");
+static u_long numposzaps; STATNODE(CTLFLAG_RD, numposzaps, &numposzaps, "# cache hits (positive) we dont want to cache");
+static u_long numneghits; STATNODE(CTLFLAG_RD, numneghits, &numneghits, "# cache hits (negative)");
+static u_long numnegzaps; STATNODE(CTLFLAG_RD, numnegzaps, &numnegzaps, "# cache hits (negative) we dont want to cache");
+static u_long numupgrades; STATNODE(CTLFLAG_RD, numupgrades, &numupgrades, "# update the cache after lookup (write lock + retry)");
 
 SYSCTL_OPAQUE(_vfs_cache, OID_AUTO, nchstats, CTLFLAG_RD | CTLFLAG_MPSAFE,
 	&nchstats, sizeof(nchstats), "LU", "VFS cache effectiveness statistics");
@@ -964,20 +964,20 @@
  */
 
 #undef STATNODE
-#define STATNODE(name)							\
+#define STATNODE(name, descr)						\
 	static u_int name;						\
-	SYSCTL_UINT(_vfs_cache, OID_AUTO, name, CTLFLAG_RD, &name, 0, "")
+	SYSCTL_UINT(_vfs_cache, OID_AUTO, name, CTLFLAG_RD, &name, 0, descr)
 
 static int disablefullpath;
 SYSCTL_INT(_debug, OID_AUTO, disablefullpath, CTLFLAG_RW, &disablefullpath, 0,
 	"Disable the vn_fullpath function");
 
 /* These count for kern___getcwd(), too. */
-STATNODE(numfullpathcalls);
-STATNODE(numfullpathfail1);
-STATNODE(numfullpathfail2);
-STATNODE(numfullpathfail4);
-STATNODE(numfullpathfound);
+STATNODE(numfullpathcalls, "# fullpath search calls");
+STATNODE(numfullpathfail1, "# fullpath search error (ENOTDIR)");
+STATNODE(numfullpathfail2, "# fullpath search error (ENOENT)");
+STATNODE(numfullpathfail4, "# fullpath search error (ENOMEM)");
+STATNODE(numfullpathfound, "# fullpath search found");
 
 /*
  * Retrieve the full filesystem path that correspond to a vnode from the name


>Release-Note:
>Audit-Trail:

From: Chip Camden <sterling@camdensoftware.com>
To: bug-followup@FreeBSD.org, wtfcrap@mail.ru
Cc:  
Subject: Re: kern/148710: [sysctl][patch] Document sys/kern sysctls
Date: Fri, 6 Aug 2010 13:11:45 -0700

 --45Z9DzgjV8m4Oswq
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 This patch applies cleanly to 8.1-STABLE, and the new info shows up in
 sysctl -d.
 
 --=20
 Sterling (Chip) Camden    | sterling@camdensoftware.com | 2048D/3A978E4F
 http://camdensoftware.com | http://chipstips.com        | http://chipsquips=
 .com
 
 --45Z9DzgjV8m4Oswq
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (FreeBSD)
 
 iQEcBAEBAgAGBQJMXGyBAAoJEIpckszW26+RnlEIAMZ0q1/KYH1KOredJKnerSGs
 wRMRAIYj6gnOohCqjUuBiELPOWVPyVyNXvGpi88gj90De+okQna9jSIcpgTTqEck
 uumdI8ReFVEEPXGGOIz68JXrdRkCbw8Aq6wzP5dZcgbUlVxRCD88dCbwTkQOqYeQ
 oTOmjfDSP2ND/UNE7D50vkB4/yJXxyWT8XyOIEPsFA9YzKhfFkaIj0P4j+L7EmP6
 0DWHvcFj+6cyRk8HM8EtmXU95rKMU1qt3rHVAg243QsWG0GTDdicvtBfOwetcEb+
 TS5XJBcBBv7emQOCKVJ9HCOGOtjJF9W312yIITtjvpWx2eWJz9AviTaYXaBfm3I=
 =pAp2
 -----END PGP SIGNATURE-----
 
 --45Z9DzgjV8m4Oswq--
State-Changed-From-To: open->analyzed 
State-Changed-By: vwe 
State-Changed-When: Sun Aug 15 22:41:24 UTC 2010 
State-Changed-Why:  
patch looking fine, tested by Chip - now it takes a committer... ;) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148710 
Responsible-Changed-From-To: freebsd-bugs->brucec 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Mon Aug 16 08:14:43 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148710 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/148710: commit references a PR
Date: Sun, 14 Nov 2010 06:09:56 +0000 (UTC)

 Author: brucec
 Date: Sun Nov 14 06:09:50 2010
 New Revision: 215281
 URL: http://svn.freebsd.org/changeset/base/215281
 
 Log:
   Add some descriptions to sys/kern sysctls.
   
   PR:	kern/148710
   Tested by:	Chip Camden <sterling at camdensoftware.com>
   MFC after:	1 week
 
 Modified:
   head/sys/kern/kern_proc.c
   head/sys/kern/kern_tc.c
   head/sys/kern/subr_clock.c
   head/sys/kern/sysv_sem.c
   head/sys/kern/vfs_cache.c
 
 Modified: head/sys/kern/kern_proc.c
 ==============================================================================
 --- head/sys/kern/kern_proc.c	Sun Nov 14 05:05:41 2010	(r215280)
 +++ head/sys/kern/kern_proc.c	Sun Nov 14 06:09:50 2010	(r215281)
 @@ -144,7 +144,7 @@ struct mtx ppeers_lock;
  uma_zone_t proc_zone;
  
  int kstack_pages = KSTACK_PAGES;
 -SYSCTL_INT(_kern, OID_AUTO, kstack_pages, CTLFLAG_RD, &kstack_pages, 0, "");
 +SYSCTL_INT(_kern, OID_AUTO, kstack_pages, CTLFLAG_RD, &kstack_pages, 0, "Kernel stack size in pages");
  
  CTASSERT(sizeof(struct kinfo_proc) == KINFO_PROC_SIZE);
  #ifdef COMPAT_FREEBSD32
 
 Modified: head/sys/kern/kern_tc.c
 ==============================================================================
 --- head/sys/kern/kern_tc.c	Sun Nov 14 05:05:41 2010	(r215280)
 +++ head/sys/kern/kern_tc.c	Sun Nov 14 06:09:50 2010	(r215281)
 @@ -103,7 +103,7 @@ SYSCTL_NODE(_kern_timecounter, OID_AUTO,
  
  static int timestepwarnings;
  SYSCTL_INT(_kern_timecounter, OID_AUTO, stepwarnings, CTLFLAG_RW,
 -    &timestepwarnings, 0, "");
 +    &timestepwarnings, 0, "Log time steps");
  
  static void tc_windup(void);
  static void cpu_tick_calibrate(int);
 @@ -560,7 +560,7 @@ sysctl_kern_timecounter_hardware(SYSCTL_
  }
  
  SYSCTL_PROC(_kern_timecounter, OID_AUTO, hardware, CTLTYPE_STRING | CTLFLAG_RW,
 -    0, 0, sysctl_kern_timecounter_hardware, "A", "");
 +    0, 0, sysctl_kern_timecounter_hardware, "A", "Timecounter hardware selected");
  
  
  /* Report or change the active timecounter hardware. */
 @@ -583,7 +583,7 @@ sysctl_kern_timecounter_choice(SYSCTL_HA
  }
  
  SYSCTL_PROC(_kern_timecounter, OID_AUTO, choice, CTLTYPE_STRING | CTLFLAG_RD,
 -    0, 0, sysctl_kern_timecounter_choice, "A", "");
 +    0, 0, sysctl_kern_timecounter_choice, "A", "Timecounter hardware detected");
  
  /*
   * RFC 2783 PPS-API implementation.
 @@ -768,7 +768,7 @@ pps_event(struct pps_state *pps, int eve
   */
  
  static int tc_tick;
 -SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0, "");
 +SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0, "Approximate number of hardclock ticks in a millisecond");
  
  void
  tc_ticktock(int cnt)
 
 Modified: head/sys/kern/subr_clock.c
 ==============================================================================
 --- head/sys/kern/subr_clock.c	Sun Nov 14 05:05:41 2010	(r215280)
 +++ head/sys/kern/subr_clock.c	Sun Nov 14 06:09:50 2010	(r215281)
 @@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$");
  #include <sys/timetc.h>
  
  #define ct_debug bootverbose
 -static int adjkerntz;		/* local offset from GMT in seconds */
 +static int adjkerntz;		/* local offset from UTC in seconds */
  static int wall_cmos_clock;	/* wall CMOS clock assumed if != 0 */
  
  int tz_minuteswest;
 @@ -61,7 +61,7 @@ int tz_dsttime;
   * kern.
   */
  SYSCTL_INT(_machdep, OID_AUTO, wall_cmos_clock,
 -	CTLFLAG_RW, &wall_cmos_clock, 0, "");
 +	CTLFLAG_RW, &wall_cmos_clock, 0, "CMOS clock keeps wall time");
  
  static int
  sysctl_machdep_adjkerntz(SYSCTL_HANDLER_ARGS)
 @@ -74,7 +74,7 @@ sysctl_machdep_adjkerntz(SYSCTL_HANDLER_
  }
  
  SYSCTL_PROC(_machdep, OID_AUTO, adjkerntz, CTLTYPE_INT|CTLFLAG_RW,
 -	&adjkerntz, 0, sysctl_machdep_adjkerntz, "I", "");
 +	&adjkerntz, 0, sysctl_machdep_adjkerntz, "I", "Local offset from UTC in seconds");
  
  /*--------------------------------------------------------------------*
   * Generic routines to convert between a POSIX date
 
 Modified: head/sys/kern/sysv_sem.c
 ==============================================================================
 --- head/sys/kern/sysv_sem.c	Sun Nov 14 05:05:41 2010	(r215280)
 +++ head/sys/kern/sysv_sem.c	Sun Nov 14 06:09:50 2010	(r215281)
 @@ -212,7 +212,7 @@ SYSCTL_INT(_kern_ipc, OID_AUTO, semvmx, 
  SYSCTL_INT(_kern_ipc, OID_AUTO, semaem, CTLFLAG_RW, &seminfo.semaem, 0,
      "Adjust on exit max value");
  SYSCTL_PROC(_kern_ipc, OID_AUTO, sema, CTLFLAG_RD,
 -    NULL, 0, sysctl_sema, "", "");
 +    NULL, 0, sysctl_sema, "", "Semaphore id pool");
  
  static struct syscall_helper_data sem_syscalls[] = {
  	SYSCALL_INIT_HELPER(__semctl),
 
 Modified: head/sys/kern/vfs_cache.c
 ==============================================================================
 --- head/sys/kern/vfs_cache.c	Sun Nov 14 05:05:41 2010	(r215280)
 +++ head/sys/kern/vfs_cache.c	Sun Nov 14 06:09:50 2010	(r215281)
 @@ -184,27 +184,27 @@ SYSCTL_INT(_debug, OID_AUTO, vfscache, C
  
  /* Export size information to userland */
  SYSCTL_INT(_debug_sizeof, OID_AUTO, namecache, CTLFLAG_RD, 0,
 -	sizeof(struct namecache), "");
 +	sizeof(struct namecache), "sizeof(struct namecache)");
  
  /*
   * The new name cache statistics
   */
  static SYSCTL_NODE(_vfs, OID_AUTO, cache, CTLFLAG_RW, 0, "Name cache statistics");
 -#define STATNODE(mode, name, var) \
 -	SYSCTL_ULONG(_vfs_cache, OID_AUTO, name, mode, var, 0, "");
 -STATNODE(CTLFLAG_RD, numneg, &numneg);
 -STATNODE(CTLFLAG_RD, numcache, &numcache);
 -static u_long numcalls; STATNODE(CTLFLAG_RD, numcalls, &numcalls);
 -static u_long dothits; STATNODE(CTLFLAG_RD, dothits, &dothits);
 -static u_long dotdothits; STATNODE(CTLFLAG_RD, dotdothits, &dotdothits);
 -static u_long numchecks; STATNODE(CTLFLAG_RD, numchecks, &numchecks);
 -static u_long nummiss; STATNODE(CTLFLAG_RD, nummiss, &nummiss);
 -static u_long nummisszap; STATNODE(CTLFLAG_RD, nummisszap, &nummisszap);
 -static u_long numposzaps; STATNODE(CTLFLAG_RD, numposzaps, &numposzaps);
 -static u_long numposhits; STATNODE(CTLFLAG_RD, numposhits, &numposhits);
 -static u_long numnegzaps; STATNODE(CTLFLAG_RD, numnegzaps, &numnegzaps);
 -static u_long numneghits; STATNODE(CTLFLAG_RD, numneghits, &numneghits);
 -static u_long numupgrades; STATNODE(CTLFLAG_RD, numupgrades, &numupgrades);
 +#define STATNODE(mode, name, var, descr) \
 +	SYSCTL_ULONG(_vfs_cache, OID_AUTO, name, mode, var, 0, descr);
 +STATNODE(CTLFLAG_RD, numneg, &numneg, "Number of negative cache entries");
 +STATNODE(CTLFLAG_RD, numcache, &numcache, "Number of cache entries");
 +static u_long numcalls; STATNODE(CTLFLAG_RD, numcalls, &numcalls, "Number of cache lookups");
 +static u_long dothits; STATNODE(CTLFLAG_RD, dothits, &dothits, "Number of '.' hits");
 +static u_long dotdothits; STATNODE(CTLFLAG_RD, dotdothits, &dotdothits, "Number of '..' hits");
 +static u_long numchecks; STATNODE(CTLFLAG_RD, numchecks, &numchecks, "Number of checks in lookup");
 +static u_long nummiss; STATNODE(CTLFLAG_RD, nummiss, &nummiss, "Number of cache misses");
 +static u_long nummisszap; STATNODE(CTLFLAG_RD, nummisszap, &nummisszap, "Number of cache misses we do not want to cache");
 +static u_long numposzaps; STATNODE(CTLFLAG_RD, numposzaps, &numposzaps, "Number of cache hits (positive) we do not want to cache");
 +static u_long numposhits; STATNODE(CTLFLAG_RD, numposhits, &numposhits, "Number of cache hits (positive)");
 +static u_long numnegzaps; STATNODE(CTLFLAG_RD, numnegzaps, &numnegzaps, "Number of cache hits (negative) we do not want to cache");
 +static u_long numneghits; STATNODE(CTLFLAG_RD, numneghits, &numneghits, "Number of cache hits (negative)");
 +static u_long numupgrades; STATNODE(CTLFLAG_RD, numupgrades, &numupgrades, "Number of updates of the cache after lookup (write lock + retry)");
  
  SYSCTL_OPAQUE(_vfs_cache, OID_AUTO, nchstats, CTLFLAG_RD | CTLFLAG_MPSAFE,
  	&nchstats, sizeof(nchstats), "LU", "VFS cache effectiveness statistics");
 @@ -970,20 +970,20 @@ kern___getcwd(struct thread *td, u_char 
   */
  
  #undef STATNODE
 -#define STATNODE(name)							\
 +#define STATNODE(name, descr)						\
  	static u_int name;						\
 -	SYSCTL_UINT(_vfs_cache, OID_AUTO, name, CTLFLAG_RD, &name, 0, "")
 +	SYSCTL_UINT(_vfs_cache, OID_AUTO, name, CTLFLAG_RD, &name, 0, descr)
  
  static int disablefullpath;
  SYSCTL_INT(_debug, OID_AUTO, disablefullpath, CTLFLAG_RW, &disablefullpath, 0,
  	"Disable the vn_fullpath function");
  
  /* These count for kern___getcwd(), too. */
 -STATNODE(numfullpathcalls);
 -STATNODE(numfullpathfail1);
 -STATNODE(numfullpathfail2);
 -STATNODE(numfullpathfail4);
 -STATNODE(numfullpathfound);
 +STATNODE(numfullpathcalls, "Number of fullpath search calls");
 +STATNODE(numfullpathfail1, "Number of fullpath search errors (ENOTDIR)");
 +STATNODE(numfullpathfail2, "Number of fullpath search errors (VOP_VPTOCNP failures)");
 +STATNODE(numfullpathfail4, "Number of fullpath search errors (ENOMEM)");
 +STATNODE(numfullpathfound, "Number of successful fullpath calls");
  
  /*
   * Retrieve the full filesystem path that correspond to a vnode from the name
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->patched 
State-Changed-By: brucec 
State-Changed-When: Sun Nov 14 06:48:53 UTC 2010 
State-Changed-Why:  
Fixed in r215281. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148710 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/148710: commit references a PR
Date: Sun, 21 Nov 2010 12:48:00 +0000 (UTC)

 Author: brucec
 Date: Sun Nov 21 12:47:54 2010
 New Revision: 215629
 URL: http://svn.freebsd.org/changeset/base/215629
 
 Log:
   MFC r215281, r215282, r215283, r215304:
   
   Add some descriptions to sys/kern sysctls.
   Fix style(9) issues.
   
   PR:	kern/148710
   PR:	kern/148510
 
 Modified:
   stable/8/sys/kern/kern_proc.c
   stable/8/sys/kern/kern_tc.c
   stable/8/sys/kern/subr_clock.c
   stable/8/sys/kern/sysv_sem.c
   stable/8/sys/kern/vfs_cache.c
   stable/8/sys/kern/vfs_subr.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/kern/kern_proc.c
 ==============================================================================
 --- stable/8/sys/kern/kern_proc.c	Sun Nov 21 12:40:16 2010	(r215628)
 +++ stable/8/sys/kern/kern_proc.c	Sun Nov 21 12:47:54 2010	(r215629)
 @@ -148,7 +148,8 @@ struct mtx ppeers_lock;
  uma_zone_t proc_zone;
  
  int kstack_pages = KSTACK_PAGES;
 -SYSCTL_INT(_kern, OID_AUTO, kstack_pages, CTLFLAG_RD, &kstack_pages, 0, "");
 +SYSCTL_INT(_kern, OID_AUTO, kstack_pages, CTLFLAG_RD, &kstack_pages, 0,
 +    "Kernel stack size in pages");
  
  CTASSERT(sizeof(struct kinfo_proc) == KINFO_PROC_SIZE);
  #ifdef COMPAT_FREEBSD32
 
 Modified: stable/8/sys/kern/kern_tc.c
 ==============================================================================
 --- stable/8/sys/kern/kern_tc.c	Sun Nov 21 12:40:16 2010	(r215628)
 +++ stable/8/sys/kern/kern_tc.c	Sun Nov 21 12:47:54 2010	(r215629)
 @@ -101,7 +101,7 @@ SYSCTL_NODE(_kern_timecounter, OID_AUTO,
  
  static int timestepwarnings;
  SYSCTL_INT(_kern_timecounter, OID_AUTO, stepwarnings, CTLFLAG_RW,
 -    &timestepwarnings, 0, "");
 +    &timestepwarnings, 0, "Log time steps");
  
  static void tc_windup(void);
  static void cpu_tick_calibrate(int);
 @@ -556,7 +556,8 @@ sysctl_kern_timecounter_hardware(SYSCTL_
  }
  
  SYSCTL_PROC(_kern_timecounter, OID_AUTO, hardware, CTLTYPE_STRING | CTLFLAG_RW,
 -    0, 0, sysctl_kern_timecounter_hardware, "A", "");
 +    0, 0, sysctl_kern_timecounter_hardware, "A",
 +    "Timecounter hardware selected");
  
  
  /* Report or change the active timecounter hardware. */
 @@ -579,7 +580,7 @@ sysctl_kern_timecounter_choice(SYSCTL_HA
  }
  
  SYSCTL_PROC(_kern_timecounter, OID_AUTO, choice, CTLTYPE_STRING | CTLFLAG_RD,
 -    0, 0, sysctl_kern_timecounter_choice, "A", "");
 +    0, 0, sysctl_kern_timecounter_choice, "A", "Timecounter hardware detected");
  
  /*
   * RFC 2783 PPS-API implementation.
 @@ -764,7 +765,8 @@ pps_event(struct pps_state *pps, int eve
   */
  
  static int tc_tick;
 -SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0, "");
 +SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0,
 +    "Approximate number of hardclock ticks in a millisecond");
  
  void
  tc_ticktock(void)
 
 Modified: stable/8/sys/kern/subr_clock.c
 ==============================================================================
 --- stable/8/sys/kern/subr_clock.c	Sun Nov 21 12:40:16 2010	(r215628)
 +++ stable/8/sys/kern/subr_clock.c	Sun Nov 21 12:47:54 2010	(r215629)
 @@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$");
  #include <sys/timetc.h>
  
  #define ct_debug bootverbose
 -static int adjkerntz;		/* local offset from GMT in seconds */
 +static int adjkerntz;		/* local offset from UTC in seconds */
  static int wall_cmos_clock;	/* wall CMOS clock assumed if != 0 */
  
  int tz_minuteswest;
 @@ -61,7 +61,7 @@ int tz_dsttime;
   * kern.
   */
  SYSCTL_INT(_machdep, OID_AUTO, wall_cmos_clock,
 -	CTLFLAG_RW, &wall_cmos_clock, 0, "");
 +    CTLFLAG_RW, &wall_cmos_clock, 0, "CMOS clock keeps wall time");
  
  static int
  sysctl_machdep_adjkerntz(SYSCTL_HANDLER_ARGS)
 @@ -74,7 +74,8 @@ sysctl_machdep_adjkerntz(SYSCTL_HANDLER_
  }
  
  SYSCTL_PROC(_machdep, OID_AUTO, adjkerntz, CTLTYPE_INT|CTLFLAG_RW,
 -	&adjkerntz, 0, sysctl_machdep_adjkerntz, "I", "");
 +    &adjkerntz, 0, sysctl_machdep_adjkerntz, "I",
 +    "Local offset from UTC in seconds");
  
  /*--------------------------------------------------------------------*
   * Generic routines to convert between a POSIX date
 
 Modified: stable/8/sys/kern/sysv_sem.c
 ==============================================================================
 --- stable/8/sys/kern/sysv_sem.c	Sun Nov 21 12:40:16 2010	(r215628)
 +++ stable/8/sys/kern/sysv_sem.c	Sun Nov 21 12:47:54 2010	(r215629)
 @@ -212,7 +212,7 @@ SYSCTL_INT(_kern_ipc, OID_AUTO, semvmx, 
  SYSCTL_INT(_kern_ipc, OID_AUTO, semaem, CTLFLAG_RW, &seminfo.semaem, 0,
      "Adjust on exit max value");
  SYSCTL_PROC(_kern_ipc, OID_AUTO, sema, CTLFLAG_RD,
 -    NULL, 0, sysctl_sema, "", "");
 +    NULL, 0, sysctl_sema, "", "Semaphore id pool");
  
  static struct syscall_helper_data sem_syscalls[] = {
  	SYSCALL_INIT_HELPER(__semctl),
 
 Modified: stable/8/sys/kern/vfs_cache.c
 ==============================================================================
 --- stable/8/sys/kern/vfs_cache.c	Sun Nov 21 12:40:16 2010	(r215628)
 +++ stable/8/sys/kern/vfs_cache.c	Sun Nov 21 12:47:54 2010	(r215629)
 @@ -186,30 +186,43 @@ SYSCTL_INT(_debug, OID_AUTO, vfscache, C
  
  /* Export size information to userland */
  SYSCTL_INT(_debug_sizeof, OID_AUTO, namecache, CTLFLAG_RD, 0,
 -	sizeof(struct namecache), "");
 +    sizeof(struct namecache), "sizeof(struct namecache)");
  
  /*
   * The new name cache statistics
   */
 -static SYSCTL_NODE(_vfs, OID_AUTO, cache, CTLFLAG_RW, 0, "Name cache statistics");
 -#define STATNODE(mode, name, var) \
 -	SYSCTL_ULONG(_vfs_cache, OID_AUTO, name, mode, var, 0, "");
 -STATNODE(CTLFLAG_RD, numneg, &numneg);
 -STATNODE(CTLFLAG_RD, numcache, &numcache);
 -static u_long numcalls; STATNODE(CTLFLAG_RD, numcalls, &numcalls);
 -static u_long dothits; STATNODE(CTLFLAG_RD, dothits, &dothits);
 -static u_long dotdothits; STATNODE(CTLFLAG_RD, dotdothits, &dotdothits);
 -static u_long numchecks; STATNODE(CTLFLAG_RD, numchecks, &numchecks);
 -static u_long nummiss; STATNODE(CTLFLAG_RD, nummiss, &nummiss);
 -static u_long nummisszap; STATNODE(CTLFLAG_RD, nummisszap, &nummisszap);
 -static u_long numposzaps; STATNODE(CTLFLAG_RD, numposzaps, &numposzaps);
 -static u_long numposhits; STATNODE(CTLFLAG_RD, numposhits, &numposhits);
 -static u_long numnegzaps; STATNODE(CTLFLAG_RD, numnegzaps, &numnegzaps);
 -static u_long numneghits; STATNODE(CTLFLAG_RD, numneghits, &numneghits);
 -static u_long numupgrades; STATNODE(CTLFLAG_RD, numupgrades, &numupgrades);
 +static SYSCTL_NODE(_vfs, OID_AUTO, cache, CTLFLAG_RW, 0,
 +    "Name cache statistics");
 +#define STATNODE(mode, name, var, descr) \
 +	SYSCTL_ULONG(_vfs_cache, OID_AUTO, name, mode, var, 0, descr);
 +STATNODE(CTLFLAG_RD, numneg, &numneg, "Number of negative cache entries");
 +STATNODE(CTLFLAG_RD, numcache, &numcache, "Number of cache entries");
 +static u_long numcalls; STATNODE(CTLFLAG_RD, numcalls, &numcalls,
 +    "Number of cache lookups");
 +static u_long dothits; STATNODE(CTLFLAG_RD, dothits, &dothits,
 +    "Number of '.' hits");
 +static u_long dotdothits; STATNODE(CTLFLAG_RD, dotdothits, &dotdothits,
 +    "Number of '..' hits");
 +static u_long numchecks; STATNODE(CTLFLAG_RD, numchecks, &numchecks,
 +    "Number of checks in lookup");
 +static u_long nummiss; STATNODE(CTLFLAG_RD, nummiss, &nummiss,
 +    "Number of cache misses");
 +static u_long nummisszap; STATNODE(CTLFLAG_RD, nummisszap, &nummisszap,
 +    "Number of cache misses we do not want to cache");
 +static u_long numposzaps; STATNODE(CTLFLAG_RD, numposzaps, &numposzaps, 
 +    "Number of cache hits (positive) we do not want to cache");
 +static u_long numposhits; STATNODE(CTLFLAG_RD, numposhits, &numposhits,
 +    "Number of cache hits (positive)");
 +static u_long numnegzaps; STATNODE(CTLFLAG_RD, numnegzaps, &numnegzaps,
 +    "Number of cache hits (negative) we do not want to cache");
 +static u_long numneghits; STATNODE(CTLFLAG_RD, numneghits, &numneghits,
 +    "Number of cache hits (negative)");
 +static u_long numupgrades; STATNODE(CTLFLAG_RD, numupgrades, &numupgrades,
 +    "Number of updates of the cache after lookup (write lock + retry)");
  
  SYSCTL_OPAQUE(_vfs_cache, OID_AUTO, nchstats, CTLFLAG_RD | CTLFLAG_MPSAFE,
 -	&nchstats, sizeof(nchstats), "LU", "VFS cache effectiveness statistics");
 +    &nchstats, sizeof(nchstats), "LU",
 +    "VFS cache effectiveness statistics");
  
  
  
 @@ -261,8 +274,8 @@ sysctl_debug_hashstat_rawnchash(SYSCTL_H
  	return (0);
  }
  SYSCTL_PROC(_debug_hashstat, OID_AUTO, rawnchash, CTLTYPE_INT|CTLFLAG_RD|
 -	CTLFLAG_MPSAFE, 0, 0, sysctl_debug_hashstat_rawnchash, "S,int",
 -	"nchash chain lengths");
 +    CTLFLAG_MPSAFE, 0, 0, sysctl_debug_hashstat_rawnchash, "S,int",
 +    "nchash chain lengths");
  
  static int
  sysctl_debug_hashstat_nchash(SYSCTL_HANDLER_ARGS)
 @@ -310,8 +323,8 @@ sysctl_debug_hashstat_nchash(SYSCTL_HAND
  	return (0);
  }
  SYSCTL_PROC(_debug_hashstat, OID_AUTO, nchash, CTLTYPE_INT|CTLFLAG_RD|
 -	CTLFLAG_MPSAFE, 0, 0, sysctl_debug_hashstat_nchash, "I",
 -	"nchash chain lengths");
 +    CTLFLAG_MPSAFE, 0, 0, sysctl_debug_hashstat_nchash, "I",
 +    "nchash chain lengths");
  #endif
  
  /*
 @@ -972,20 +985,21 @@ kern___getcwd(struct thread *td, u_char 
   */
  
  #undef STATNODE
 -#define STATNODE(name)							\
 +#define STATNODE(name, descr)						\
  	static u_int name;						\
 -	SYSCTL_UINT(_vfs_cache, OID_AUTO, name, CTLFLAG_RD, &name, 0, "")
 +	SYSCTL_UINT(_vfs_cache, OID_AUTO, name, CTLFLAG_RD, &name, 0, descr)
  
  static int disablefullpath;
  SYSCTL_INT(_debug, OID_AUTO, disablefullpath, CTLFLAG_RW, &disablefullpath, 0,
 -	"Disable the vn_fullpath function");
 +    "Disable the vn_fullpath function");
  
  /* These count for kern___getcwd(), too. */
 -STATNODE(numfullpathcalls);
 -STATNODE(numfullpathfail1);
 -STATNODE(numfullpathfail2);
 -STATNODE(numfullpathfail4);
 -STATNODE(numfullpathfound);
 +STATNODE(numfullpathcalls, "Number of fullpath search calls");
 +STATNODE(numfullpathfail1, "Number of fullpath search errors (ENOTDIR)");
 +STATNODE(numfullpathfail2,
 +    "Number of fullpath search errors (VOP_VPTOCNP failures)");
 +STATNODE(numfullpathfail4, "Number of fullpath search errors (ENOMEM)");
 +STATNODE(numfullpathfound, "Number of successful fullpath calls");
  
  /*
   * Retrieve the full filesystem path that correspond to a vnode from the name
 
 Modified: stable/8/sys/kern/vfs_subr.c
 ==============================================================================
 --- stable/8/sys/kern/vfs_subr.c	Sun Nov 21 12:40:16 2010	(r215628)
 +++ stable/8/sys/kern/vfs_subr.c	Sun Nov 21 12:47:54 2010	(r215629)
 @@ -121,7 +121,8 @@ static void	destroy_vpollinfo(struct vpo
   */
  static unsigned long	numvnodes;
  
 -SYSCTL_LONG(_vfs, OID_AUTO, numvnodes, CTLFLAG_RD, &numvnodes, 0, "");
 +SYSCTL_LONG(_vfs, OID_AUTO, numvnodes, CTLFLAG_RD, &numvnodes, 0,
 +    "Number of vnodes in existence");
  
  /*
   * Conversion tables for conversion from vnode types to inode formats
 @@ -150,7 +151,8 @@ static u_long wantfreevnodes;
  SYSCTL_LONG(_vfs, OID_AUTO, wantfreevnodes, CTLFLAG_RW, &wantfreevnodes, 0, "");
  /* Number of vnodes in the free list. */
  static u_long freevnodes;
 -SYSCTL_LONG(_vfs, OID_AUTO, freevnodes, CTLFLAG_RD, &freevnodes, 0, "");
 +SYSCTL_LONG(_vfs, OID_AUTO, freevnodes, CTLFLAG_RD, &freevnodes, 0,
 +    "Number of vnodes in the free list");
  
  static int vlru_allow_cache_src;
  SYSCTL_INT(_vfs, OID_AUTO, vlru_allow_cache_src, CTLFLAG_RW,
 @@ -162,7 +164,8 @@ SYSCTL_INT(_vfs, OID_AUTO, vlru_allow_ca
   * XXX these are probably of (very) limited utility now.
   */
  static int reassignbufcalls;
 -SYSCTL_INT(_vfs, OID_AUTO, reassignbufcalls, CTLFLAG_RW, &reassignbufcalls, 0, "");
 +SYSCTL_INT(_vfs, OID_AUTO, reassignbufcalls, CTLFLAG_RW, &reassignbufcalls, 0,
 +    "Number of calls to reassignbuf");
  
  /*
   * Cache for the mount type id assigned to NFS.  This is used for
 @@ -237,14 +240,18 @@ static struct cv sync_wakeup;
  static int syncer_maxdelay = SYNCER_MAXDELAY;	/* maximum delay time */
  static int syncdelay = 30;		/* max time to delay syncing data */
  static int filedelay = 30;		/* time to delay syncing files */
 -SYSCTL_INT(_kern, OID_AUTO, filedelay, CTLFLAG_RW, &filedelay, 0, "");
 +SYSCTL_INT(_kern, OID_AUTO, filedelay, CTLFLAG_RW, &filedelay, 0,
 +    "Time to delay syncing files (in seconds)");
  static int dirdelay = 29;		/* time to delay syncing directories */
 -SYSCTL_INT(_kern, OID_AUTO, dirdelay, CTLFLAG_RW, &dirdelay, 0, "");
 +SYSCTL_INT(_kern, OID_AUTO, dirdelay, CTLFLAG_RW, &dirdelay, 0,
 +    "Time to delay syncing directories (in seconds)");
  static int metadelay = 28;		/* time to delay syncing metadata */
 -SYSCTL_INT(_kern, OID_AUTO, metadelay, CTLFLAG_RW, &metadelay, 0, "");
 +SYSCTL_INT(_kern, OID_AUTO, metadelay, CTLFLAG_RW, &metadelay, 0,
 +    "Time to delay syncing metadata (in seconds)");
  static int rushjob;		/* number of slots to run ASAP */
  static int stat_rush_requests;	/* number of times I/O speeded up */
 -SYSCTL_INT(_debug, OID_AUTO, rush_requests, CTLFLAG_RW, &stat_rush_requests, 0, "");
 +SYSCTL_INT(_debug, OID_AUTO, rush_requests, CTLFLAG_RW, &stat_rush_requests, 0,
 +    "Number of times I/O speeded up (rush requests)");
  
  /*
   * When shutting down the syncer, run it at four times normal speed.
 @@ -544,7 +551,9 @@ enum { TSP_SEC, TSP_HZ, TSP_USEC, TSP_NS
  
  static int timestamp_precision = TSP_SEC;
  SYSCTL_INT(_vfs, OID_AUTO, timestamp_precision, CTLFLAG_RW,
 -    &timestamp_precision, 0, "");
 +    &timestamp_precision, 0, "File timestamp precision (0: seconds, "
 +    "1: sec + ns accurate to 1/HZ, 2: sec + ns truncated to ms, "
 +    "3+: sec + ns (max. precision))");
  
  /*
   * Get a current timestamp.
 @@ -2376,7 +2385,7 @@ vinactive(struct vnode *vp, struct threa
   */
  #ifdef DIAGNOSTIC
  static int busyprt = 0;		/* print out busy vnodes */
 -SYSCTL_INT(_debug, OID_AUTO, busyprt, CTLFLAG_RW, &busyprt, 0, "");
 +SYSCTL_INT(_debug, OID_AUTO, busyprt, CTLFLAG_RW, &busyprt, 0, "Print out busy vnodes");
  #endif
  
  int
 @@ -3015,7 +3024,7 @@ vfs_sysctl(SYSCTL_HANDLER_ARGS)
  }
  
  static SYSCTL_NODE(_vfs, VFS_GENERIC, generic, CTLFLAG_RD | CTLFLAG_SKIP,
 -	vfs_sysctl, "Generic filesystem");
 +    vfs_sysctl, "Generic filesystem");
  
  #if 1 || defined(COMPAT_PRELITE2)
  
 @@ -3136,7 +3145,7 @@ sysctl_vnode(SYSCTL_HANDLER_ARGS)
  }
  
  SYSCTL_PROC(_kern, KERN_VNODE, vnode, CTLTYPE_OPAQUE|CTLFLAG_RD,
 -	0, 0, sysctl_vnode, "S,xvnode", "");
 +    0, 0, sysctl_vnode, "S,xvnode", "");
  #endif
  
  /*
 @@ -3680,17 +3689,21 @@ extattr_check_cred(struct vnode *vp, int
  	(vp)->v_type == VCHR ||	(vp)->v_type == VBAD)
  
  int vfs_badlock_ddb = 1;	/* Drop into debugger on violation. */
 -SYSCTL_INT(_debug, OID_AUTO, vfs_badlock_ddb, CTLFLAG_RW, &vfs_badlock_ddb, 0, "");
 +SYSCTL_INT(_debug, OID_AUTO, vfs_badlock_ddb, CTLFLAG_RW, &vfs_badlock_ddb, 0,
 +    "Drop into debugger on lock violation");
  
  int vfs_badlock_mutex = 1;	/* Check for interlock across VOPs. */
 -SYSCTL_INT(_debug, OID_AUTO, vfs_badlock_mutex, CTLFLAG_RW, &vfs_badlock_mutex, 0, "");
 +SYSCTL_INT(_debug, OID_AUTO, vfs_badlock_mutex, CTLFLAG_RW, &vfs_badlock_mutex,
 +    0, "Check for interlock across VOPs");
  
  int vfs_badlock_print = 1;	/* Print lock violations. */
 -SYSCTL_INT(_debug, OID_AUTO, vfs_badlock_print, CTLFLAG_RW, &vfs_badlock_print, 0, "");
 +SYSCTL_INT(_debug, OID_AUTO, vfs_badlock_print, CTLFLAG_RW, &vfs_badlock_print,
 +    0, "Print lock violations");
  
  #ifdef KDB
  int vfs_badlock_backtrace = 1;	/* Print backtrace at lock violations. */
 -SYSCTL_INT(_debug, OID_AUTO, vfs_badlock_backtrace, CTLFLAG_RW, &vfs_badlock_backtrace, 0, "");
 +SYSCTL_INT(_debug, OID_AUTO, vfs_badlock_backtrace, CTLFLAG_RW,
 +    &vfs_badlock_backtrace, 0, "Print backtrace at lock violations");
  #endif
  
  static void
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brucec 
State-Changed-When: Sun Nov 21 13:06:20 UTC 2010 
State-Changed-Why:  
Fixed in stable/8 r215629. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148710 
>Unformatted:
