From nobody@FreeBSD.org  Wed Jun  2 19:01:37 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5018C1065677
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Jun 2010 19:01:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 401D48FC1C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Jun 2010 19:01:37 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o52J1adg004021
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 Jun 2010 19:01:36 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o52J1aJA004020;
	Wed, 2 Jun 2010 19:01:36 GMT
	(envelope-from nobody)
Message-Id: <201006021901.o52J1aJA004020@www.freebsd.org>
Date: Wed, 2 Jun 2010 19:01:36 GMT
From: CyberLeo <cyberleo@cyberleo.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: agp_nvidia device_printf missing newline
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         147337
>Category:       kern
>Synopsis:       [agp] [patch] agp_nvidia device_printf missing newline
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 02 19:10:02 UTC 2010
>Closed-Date:    Mon Jun 28 04:55:03 UTC 2010
>Last-Modified:  Mon Jun 28 05:00:07 UTC 2010
>Originator:     CyberLeo
>Release:        8.1-BETA1
>Organization:
CyberLeo.Net
>Environment:
>Description:
A device_printf call in agp_nvidia.c is missing a terminating newline in its format string.
>How-To-Repeat:

>Fix:
Attached patch

Patch attached with submission follows:

--- sys/dev/agp/agp_nvidia.c	2010-03-07 05:40:17.000000000 -0600
+++ sys/dev/agp/agp_nvidia.c	2010-03-07 05:40:55.000000000 -0600
@@ -282,7 +282,7 @@
 	case 14: return (64 * 1024 * 1024); break;
 	case 15: return (32 * 1024 * 1024); break;
 	default:
-		device_printf(dev, "Invalid aperture setting 0x%x",
+		device_printf(dev, "Invalid aperture setting 0x%x\n",
 		    pci_read_config(dev, AGP_NVIDIA_0_APSIZE, 1));
 		return 0;
 	}


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brian 
State-Changed-When: Sat Jun 19 08:38:32 UTC 2010 
State-Changed-Why:  
Applied to head (r209329).  I'll MFC in 1 week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147337 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/147337: commit references a PR
Date: Sat, 19 Jun 2010 08:42:43 +0000 (UTC)

 Author: brian
 Date: Sat Jun 19 08:42:29 2010
 New Revision: 209329
 URL: http://svn.freebsd.org/changeset/base/209329
 
 Log:
   Add a missing linefeed
   
   PR:		147337
   Submitted by:	cyberleo at cyberleo dot net
   MFC after:	1 week
 
 Modified:
   head/sys/dev/agp/agp_nvidia.c
 
 Modified: head/sys/dev/agp/agp_nvidia.c
 ==============================================================================
 --- head/sys/dev/agp/agp_nvidia.c	Sat Jun 19 08:36:12 2010	(r209328)
 +++ head/sys/dev/agp/agp_nvidia.c	Sat Jun 19 08:42:29 2010	(r209329)
 @@ -282,7 +282,7 @@ agp_nvidia_get_aperture(device_t dev)
  	case 14: return (64 * 1024 * 1024); break;
  	case 15: return (32 * 1024 * 1024); break;
  	default:
 -		device_printf(dev, "Invalid aperture setting 0x%x",
 +		device_printf(dev, "Invalid aperture setting 0x%x\n",
  		    pci_read_config(dev, AGP_NVIDIA_0_APSIZE, 1));
  		return 0;
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brian 
State-Changed-When: Mon Jun 28 04:54:37 UTC 2010 
State-Changed-Why:  
Merged from current, r209560 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147337 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/147337: commit references a PR
Date: Mon, 28 Jun 2010 04:54:28 +0000 (UTC)

 Author: brian
 Date: Mon Jun 28 04:54:16 2010
 New Revision: 209560
 URL: http://svn.freebsd.org/changeset/base/209560
 
 Log:
   MFC r209329; add a missing linefeed
   
   PR:		147337
   Submitted by:	cyberleo at cyberleo dot net
 
 Modified:
   stable/8/sys/dev/agp/agp_nvidia.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/dev/agp/agp_nvidia.c
 ==============================================================================
 --- stable/8/sys/dev/agp/agp_nvidia.c	Mon Jun 28 01:46:26 2010	(r209559)
 +++ stable/8/sys/dev/agp/agp_nvidia.c	Mon Jun 28 04:54:16 2010	(r209560)
 @@ -282,7 +282,7 @@ agp_nvidia_get_aperture(device_t dev)
  	case 14: return (64 * 1024 * 1024); break;
  	case 15: return (32 * 1024 * 1024); break;
  	default:
 -		device_printf(dev, "Invalid aperture setting 0x%x",
 +		device_printf(dev, "Invalid aperture setting 0x%x\n",
  		    pci_read_config(dev, AGP_NVIDIA_0_APSIZE, 1));
  		return 0;
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
