From nobody@FreeBSD.org  Fri May 14 15:36:41 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8400B106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 May 2010 15:36:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 5A7688FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 May 2010 15:36:41 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o4EFaef0032318
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 May 2010 15:36:40 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o4EFae1n032317;
	Fri, 14 May 2010 15:36:40 GMT
	(envelope-from nobody)
Message-Id: <201005141536.o4EFae1n032317@www.freebsd.org>
Date: Fri, 14 May 2010 15:36:40 GMT
From: Erwin Rol <erwin@erwinrol.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sys/kern/kern_uuid.c has a le16dec be16dec mixup
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         146588
>Category:       kern
>Synopsis:       [kernel] [patch] sys/kern/kern_uuid.c has a le16dec be16dec mixup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 14 15:40:03 UTC 2010
>Closed-Date:    Thu Feb 20 10:01:03 CET 2014
>Last-Modified:  Thu Feb 20 09:10:00 UTC 2014
>Originator:     Erwin Rol
>Release:        FreeBSD 8.0
>Organization:
>Environment:
Not running FreeBSD, just noticed the error
>Description:
The sys/kern/kern_uuid.c has what seems a bug in the function be_uuid_dec()

it uses uuid->time_mid = le16dec(p + 4); instead of
uuid->time_mid = be16dec(p + 4);

Just noticed it because I am using parts of FreeBSD in the barebox bootloader.

- Erwin

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Thu Feb 13 23:25:58 CET 2014 
State-Changed-Why:  
Nice catch, patch committed.  Thanks! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Thu Feb 13 23:25:58 CET 2014 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146588 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/146588: commit references a PR
Date: Thu, 13 Feb 2014 22:24:48 +0000 (UTC)

 Author: brueffer
 Date: Thu Feb 13 22:24:36 2014
 New Revision: 261858
 URL: http://svnweb.freebsd.org/changeset/base/261858
 
 Log:
   Fix a bug in be_uuid_dec(); it called le16dec() instead of be16dec(),
   probably due to copy+pasting le_uuid_dec().
   
   PR:		146588
   Submitted by:	Erwin Rol <erwin at erwinrol.com>
   Reviewed by:	marcel
   MFC after:	1 week
 
 Modified:
   head/sys/kern/kern_uuid.c
 
 Modified: head/sys/kern/kern_uuid.c
 ==============================================================================
 --- head/sys/kern/kern_uuid.c	Thu Feb 13 22:19:24 2014	(r261857)
 +++ head/sys/kern/kern_uuid.c	Thu Feb 13 22:24:36 2014	(r261858)
 @@ -371,7 +371,7 @@ be_uuid_dec(void const *buf, struct uuid
  
  	p = buf;
  	uuid->time_low = be32dec(p);
 -	uuid->time_mid = le16dec(p + 4);
 +	uuid->time_mid = be16dec(p + 4);
  	uuid->time_hi_and_version = be16dec(p + 6);
  	uuid->clock_seq_hi_and_reserved = p[8];
  	uuid->clock_seq_low = p[9];
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/146588: commit references a PR
Date: Thu, 20 Feb 2014 08:58:17 +0000 (UTC)

 Author: brueffer
 Date: Thu Feb 20 08:58:05 2014
 New Revision: 262240
 URL: http://svnweb.freebsd.org/changeset/base/262240
 
 Log:
   MFC: r261858
   
   Fix a bug in be_uuid_dec(); it called le16dec() instead of be16dec(),
   probably due to copy+pasting le_uuid_dec().
   
   PR:		146588
   Submitted by:	Erwin Rol <erwin at erwinrol.com>
   Reviewed by:	marcel
 
 Modified:
   stable/9/sys/kern/kern_uuid.c
 Directory Properties:
   stable/9/sys/   (props changed)
 
 Modified: stable/9/sys/kern/kern_uuid.c
 ==============================================================================
 --- stable/9/sys/kern/kern_uuid.c	Thu Feb 20 08:55:59 2014	(r262239)
 +++ stable/9/sys/kern/kern_uuid.c	Thu Feb 20 08:58:05 2014	(r262240)
 @@ -314,7 +314,7 @@ be_uuid_dec(void const *buf, struct uuid
  
  	p = buf;
  	uuid->time_low = be32dec(p);
 -	uuid->time_mid = le16dec(p + 4);
 +	uuid->time_mid = be16dec(p + 4);
  	uuid->time_hi_and_version = be16dec(p + 6);
  	uuid->clock_seq_hi_and_reserved = p[8];
  	uuid->clock_seq_low = p[9];
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/146588: commit references a PR
Date: Thu, 20 Feb 2014 08:56:07 +0000 (UTC)

 Author: brueffer
 Date: Thu Feb 20 08:55:59 2014
 New Revision: 262239
 URL: http://svnweb.freebsd.org/changeset/base/262239
 
 Log:
   MFC: r261858
   
   Fix a bug in be_uuid_dec(); it called le16dec() instead of be16dec(),
   probably due to copy+pasting le_uuid_dec().
   
   PR:		146588
   Submitted by:	Erwin Rol <erwin at erwinrol.com>
   Reviewed by:	marcel
 
 Modified:
   stable/10/sys/kern/kern_uuid.c
 Directory Properties:
   stable/10/   (props changed)
 
 Modified: stable/10/sys/kern/kern_uuid.c
 ==============================================================================
 --- stable/10/sys/kern/kern_uuid.c	Thu Feb 20 04:56:55 2014	(r262238)
 +++ stable/10/sys/kern/kern_uuid.c	Thu Feb 20 08:55:59 2014	(r262239)
 @@ -371,7 +371,7 @@ be_uuid_dec(void const *buf, struct uuid
  
  	p = buf;
  	uuid->time_low = be32dec(p);
 -	uuid->time_mid = le16dec(p + 4);
 +	uuid->time_mid = be16dec(p + 4);
  	uuid->time_hi_and_version = be16dec(p + 6);
  	uuid->clock_seq_hi_and_reserved = p[8];
  	uuid->clock_seq_low = p[9];
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Thu Feb 20 10:00:44 CET 2014 
State-Changed-Why:  
Merges to stable branches done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146588 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/146588: commit references a PR
Date: Thu, 20 Feb 2014 09:00:27 +0000 (UTC)

 Author: brueffer
 Date: Thu Feb 20 09:00:13 2014
 New Revision: 262241
 URL: http://svnweb.freebsd.org/changeset/base/262241
 
 Log:
   MFC: r261858
   
   Fix a bug in be_uuid_dec(); it called le16dec() instead of be16dec(),
   probably due to copy+pasting le_uuid_dec().
   
   PR:		146588
   Submitted by:	Erwin Rol <erwin at erwinrol.com>
   Reviewed by:	marcel
 
 Modified:
   stable/8/sys/kern/kern_uuid.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/kern/   (props changed)
 
 Modified: stable/8/sys/kern/kern_uuid.c
 ==============================================================================
 --- stable/8/sys/kern/kern_uuid.c	Thu Feb 20 08:58:05 2014	(r262240)
 +++ stable/8/sys/kern/kern_uuid.c	Thu Feb 20 09:00:13 2014	(r262241)
 @@ -314,7 +314,7 @@ be_uuid_dec(void const *buf, struct uuid
  
  	p = buf;
  	uuid->time_low = be32dec(p);
 -	uuid->time_mid = le16dec(p + 4);
 +	uuid->time_mid = be16dec(p + 4);
  	uuid->time_hi_and_version = be16dec(p + 6);
  	uuid->clock_seq_hi_and_reserved = p[8];
  	uuid->clock_seq_low = p[9];
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
