From simon@comsys.ntu-kpi.kiev.ua  Fri May  7 12:48:03 2010
Return-Path: <simon@comsys.ntu-kpi.kiev.ua>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DC3311065670
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 May 2010 12:48:03 +0000 (UTC)
	(envelope-from simon@comsys.ntu-kpi.kiev.ua)
Received: from comsys.ntu-kpi.kiev.ua (comsys.kpi.ua [77.47.192.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 57A868FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  7 May 2010 12:48:02 +0000 (UTC)
Received: from pm513-1.comsys.kpi.ua ([10.18.52.101] helo=pm513-1.comsys.ntu-kpi.kiev.ua)
	by comsys.ntu-kpi.kiev.ua with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.63)
	(envelope-from <simon@comsys.ntu-kpi.kiev.ua>)
	id 1OAMyI-0000X6-4D
	for FreeBSD-gnats-submit@freebsd.org; Fri, 07 May 2010 15:48:02 +0300
Received: by pm513-1.comsys.ntu-kpi.kiev.ua (Postfix, from userid 1001)
	id C76671CC44; Fri,  7 May 2010 15:48:02 +0300 (EEST)
Message-Id: <20100507124802.GA67048@pm513-1.comsys.ntu-kpi.kiev.ua>
Date: Fri, 7 May 2010 15:48:02 +0300
From: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Typos in macro variables names in sys/fs/nfs/*.h

>Number:         146375
>Category:       kern
>Synopsis:       [nfs] [patch] Typos in macro variables names in sys/fs/nfs/*.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    rmacklem
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 07 12:50:05 UTC 2010
>Closed-Date:    Mon Apr 11 20:12:58 UTC 2011
>Last-Modified:  Mon Apr 11 20:12:58 UTC 2011
>Originator:     Andrey Simonenko
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:

There are two typos in macro variables names in sys/fs/nfs/*.h files.

>How-To-Repeat:
>Fix:
diff -ruNp nfs.orig/nfskpiport.h nfs/nfskpiport.h
--- nfs.orig/nfskpiport.h	2009-05-04 18:23:58.000000000 +0300
+++ nfs/nfskpiport.h	2010-05-07 15:13:16.000000000 +0300
@@ -27,7 +27,7 @@
  */
 
 #ifndef _NFS_NFSKPIPORT_H_
-#define	_NFSKPIPORT_NFS_H_
+#define	_NFS_NFSKPIPORT_H_
 /*
  * These definitions are needed since the generic code is now using Darwin8
  * KPI stuff. (I know, seems a bit silly, but I want the code to build on
@@ -70,4 +70,4 @@ typedef struct mbuf *		mbuf_t;
 #define	uio_iov_len(p)		((p)->uio_iov->iov_len)
 #define	uio_iov_len_add(p, v)	((p)->uio_iov->iov_len += (v))
 
-#endif	/* _NFSKPIPORT_NFS_H */
+#endif	/* _NFS_NFSKPIPORT_H_ */
diff -ruNp nfs.orig/nfsport.h nfs/nfsport.h
--- nfs.orig/nfsport.h	2010-05-07 11:44:43.000000000 +0300
+++ nfs/nfsport.h	2010-05-07 15:13:31.000000000 +0300
@@ -33,7 +33,7 @@
  */
 
 #ifndef _NFS_NFSPORT_H_
-#define	_NFSPORT_NFS_H_
+#define	_NFS_NFSPORT_H_
 
 /*
  * In general, I'm not fond of #includes in .h files, but this seems
@@ -918,4 +918,4 @@ struct nfsreq {
 
 #endif	/* _KERNEL */
 
-#endif	/* _NFSPORT_NFS_H */
+#endif	/* _NFS_NFSPORT_H_ */

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri May 7 21:38:31 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146375 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/146375: commit references a PR
Date: Sat,  8 May 2010 14:50:30 +0000 (UTC)

 Author: rmacklem
 Date: Sat May  8 14:50:12 2010
 New Revision: 207785
 URL: http://svn.freebsd.org/changeset/base/207785
 
 Log:
   Fix typos in macros.
   
   PR:		kern/146375
   Submitted by:	simon AT comsys.ntu-kpi.kiev.ua
   MFC after:	1 week
 
 Modified:
   head/sys/fs/nfs/nfskpiport.h
   head/sys/fs/nfs/nfsport.h
 
 Modified: head/sys/fs/nfs/nfskpiport.h
 ==============================================================================
 --- head/sys/fs/nfs/nfskpiport.h	Sat May  8 14:12:04 2010	(r207784)
 +++ head/sys/fs/nfs/nfskpiport.h	Sat May  8 14:50:12 2010	(r207785)
 @@ -27,7 +27,7 @@
   */
  
  #ifndef _NFS_NFSKPIPORT_H_
 -#define	_NFSKPIPORT_NFS_H_
 +#define	_NFS_NFSKPIPORT_H_
  /*
   * These definitions are needed since the generic code is now using Darwin8
   * KPI stuff. (I know, seems a bit silly, but I want the code to build on
 @@ -70,4 +70,4 @@ typedef struct mbuf *		mbuf_t;
  #define	uio_iov_len(p)		((p)->uio_iov->iov_len)
  #define	uio_iov_len_add(p, v)	((p)->uio_iov->iov_len += (v))
  
 -#endif	/* _NFSKPIPORT_NFS_H */
 +#endif	/* _NFS_NFSKPIPORT_H */
 
 Modified: head/sys/fs/nfs/nfsport.h
 ==============================================================================
 --- head/sys/fs/nfs/nfsport.h	Sat May  8 14:12:04 2010	(r207784)
 +++ head/sys/fs/nfs/nfsport.h	Sat May  8 14:50:12 2010	(r207785)
 @@ -33,7 +33,7 @@
   */
  
  #ifndef _NFS_NFSPORT_H_
 -#define	_NFSPORT_NFS_H_
 +#define	_NFS_NFSPORT_H_
  
  /*
   * In general, I'm not fond of #includes in .h files, but this seems
 @@ -918,4 +918,4 @@ struct nfsreq {
  
  #endif	/* _KERNEL */
  
 -#endif	/* _NFSPORT_NFS_H */
 +#endif	/* _NFS_NFSPORT_H */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: brucec 
State-Changed-When: Mon Feb 21 09:12:24 UTC 2011 
State-Changed-Why:  
MFC reminder. 


Responsible-Changed-From-To: freebsd-fs->rmacklem 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Mon Feb 21 09:12:24 UTC 2011 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146375 
State-Changed-From-To: patched->closed 
State-Changed-By: rmacklem 
State-Changed-When: Mon Apr 11 20:11:02 UTC 2011 
State-Changed-Why:  


The patched system no longer has typos in the macros. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=146375 
>Unformatted:
