From root@kirov.so-ups.ru  Wed Apr  7 08:31:27 2010
Return-Path: <root@kirov.so-ups.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AEEF0106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Apr 2010 08:31:27 +0000 (UTC)
	(envelope-from root@kirov.so-ups.ru)
Received: from mgat.kirov.so-cdu.ru (mgat.kirov.so-cdu.ru [77.72.136.147])
	by mx1.freebsd.org (Postfix) with ESMTP id DBB4C8FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Apr 2010 08:31:26 +0000 (UTC)
Received: from kirov.so-cdu.ru ([172.21.81.1]RDNS failed) by mgat.kirov.so-cdu.ru with InterScan Message Security Suite; Wed, 07 Apr 2010 12:01:20 +0400
Received: by ns.kirov.so-cdu.ru (Postfix, from userid 1010)
	id 82CAFB80FE; Wed,  7 Apr 2010 12:01:20 +0400 (MSD)
Received: from freebsd.kirov.so-ups.ru (unknown [10.118.3.227])
	by ns.kirov.so-cdu.ru (Postfix) with ESMTP id 52FFCB80F9
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Apr 2010 12:01:20 +0400 (MSD)
Received: by freebsd.kirov.so-ups.ru (Postfix, from userid 0)
	id 555A1205B; Wed,  7 Apr 2010 12:01:20 +0400 (MSD)
Message-Id: <20100407080120.555A1205B@freebsd.kirov.so-ups.ru>
Date: Wed,  7 Apr 2010 12:01:20 +0400 (MSD)
From: Andrey V. Elsukov <bu7cher@yandex.ru>
Reply-To: Andrey V. Elsukov <bu7cher@yandex.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [geom] panic in geom_part_mbr when undoing destroy command 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         145452
>Category:       kern
>Synopsis:       [geom] [panic] panic in geom_part_mbr when undoing destroy command
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-geom
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 07 08:40:06 UTC 2010
>Closed-Date:    Sat Jul 10 16:52:32 UTC 2010
>Last-Modified:  Sat Jul 10 16:52:32 UTC 2010
>Originator:     Andrey V. Elsukov
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD 9.0-CURRENT i386/amd64

>Description:
	System panic when trying undo destroy MBR scheme:
	Fatal trap 18: integer divide fault while in kernel mode.
	Backtrace attached.
>How-To-Repeat:
	# mdconfig -s 50m
	# gpart create -s mbr md0
	# gpart destroy -f x md0
	# gpart undo md0
>Fix:
	Don't know how to fix it in a right way.
	It seems it can be fixed by adding at the end of g_part_mbr_read method
	after loop on partitions entries some code, which will be check and
	properly initialize basetable->gpt_sectors. 
	Also it can be fixed somewhere in g_part.c, but currently it is not so 
	easy for me to found right place where :)

	

--- bt.txt begins here ---
(kgdb) bt
#0  doadump () at pcpu.h:246
#1  0xc05bf707 in boot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:416
#2  0xc05bf9f9 in panic (fmt=) at /usr/src/sys/kern/kern_shutdown.c:579
#3  0xc084632c in trap_fatal (frame=0xc3af2a10, eva=0)
    at /usr/src/sys/i386/i386/trap.c:940
#4  0xc084707d in trap (frame=0xc3af2a10) at /usr/src/sys/i386/i386/trap.c:729
#5  0xc082905b in calltrap () at /usr/src/sys/i386/i386/exception.s:165
#6  0xc084e6ab in __qdivrem (uq=) at /usr/src/sys/libkern/qdivrem.c:97
#7  0xc084e5d1 in __moddi3 (a=102400, b=) at /usr/src/sys/libkern/moddi3.c:60
#8  0xc056af6f in g_part_mbr_read (basetable=0xc3ea9c00, cp=0xcc7a1d40)
    at /usr/src/sys/geom/part/g_part_mbr.c:433
#9  0xc0566521 in g_part_ctlreq (req=0xcc7a1300, mp=0xc08e9c60, 
    verb=0xd023e760 "undo") at g_part_if.h:190
#10 0xc055933e in g_ctl_req (arg=0xcc7a1300, flag=0)
    at /usr/src/sys/geom/geom_ctl.c:454
#11 0xc055c454 in g_run_events () at /usr/src/sys/geom/geom_event.c:211
#12 0xc055d945 in g_event_procbody () at /usr/src/sys/geom/geom_kern.c:141
#13 0xc0594e31 in fork_exit (callout=0xc055d8e0 <g_event_procbody>, arg=0x0, 
    frame=0xc3af2d38) at /usr/src/sys/kern/kern_fork.c:843
#14 0xc08290d0 in fork_trampoline () at /usr/src/sys/i386/i386/exception.s:270
(kgdb) f 8
#8  0xc056af6f in g_part_mbr_read (basetable=0xc3ea9c00, cp=0xcc7a1d40)
    at /usr/src/sys/geom/part/g_part_mbr.c:433
433		basetable->gpt_last = msize - (msize % basetable->gpt_sectors) - 1;
(kgdb) p *basetable
$1 = {ops = 0xc566d800, gpt_scheme = 0xc08ea420, gpt_gp = 0xc946c280, 
  gpt_entry = {lh_first = 0x0}, gpt_first = 0, gpt_last = 0, gpt_entries = 4, 
  gpt_smhead = 0, gpt_smtail = 0, gpt_sectors = 0, gpt_heads = 0, 
  gpt_depth = 0, gpt_isleaf = 0, gpt_created = 0, gpt_modified = 0, 
  gpt_opened = 0, gpt_fixgeom = 0}
(kgdb) p *basetable->gpt_scheme
$2 = {name = 0xc08a33fe "MBR", methods = 0xc08ea480, size = 572, 
  baseclasses = 0x0, refs = 1, ops = 0xc566d800, gps_entrysz = 60, 
  gps_minent = 4, gps_maxent = 4, gps_bootcodesz = 512, scheme_list = {
    tqe_next = 0x0, tqe_prev = 0xc08ea388}}
(kgdb) 
--- bt.txt ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Apr 7 18:44:17 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145452 

From: Andrey V. Elsukov <bu7cher@yandex.ru>
To: bug-followup@freebsd.org
Cc: Marcel Moolenaar <xcllnt@mac.com>
Subject: Re: kern/145452: [geom] [panic] panic in geom_part_mbr when undoing destroy command
Date: Fri, 09 Apr 2010 20:31:19 +0400

 ------==--bound.20366.web44.yandex.ru
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain
 
 Hi,
 
 I wrote the patch that fix the problem.
 Also I added fix to schemes which use some info about geometry.
 
 -- 
 WBR, Andrey V. Elsukov
 ------==--bound.20366.web44.yandex.ru
 Content-Disposition: attachment;
 	filename="geom_part.patch.txt"
 Content-Transfer-Encoding: base64
 Content-Type: text/plain;
 	name="geom_part.patch.txt"
 
 SW5kZXg6IGdfcGFydF9wYzk4LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ19wYXJ0X3BjOTguYwkocmV2aXNp
 b24gMjA2NDIzKQorKysgZ19wYXJ0X3BjOTguYwkod29ya2luZyBjb3B5KQpAQCAtMzk1LDYgKzQy
 Myw5IEBAIGdfcGFydF9wYzk4X3JlYWQoc3RydWN0IGdfcGFydF90YWJsZSAqYmFzZXRhYmxlLCBz
 CiAJaWYgKGJ1ZiA9PSBOVUxMKQogCQlyZXR1cm4gKGVycm9yKTsKIAorCWlmIChiYXNldGFibGUt
 PmdwdF9zZWN0b3JzID09IDAgfHwgYmFzZXRhYmxlLT5ncHRfaGVhZHMgPT0gMCkKKwkJZ19wYXJ0
 X2luaXRfZ2VvbWV0cnkobXNpemUsICZiYXNldGFibGUtPmdwdF9zZWN0b3JzLAorCQkgICAgJmJh
 c2V0YWJsZS0+Z3B0X2hlYWRzKTsKIAljeWwgPSBiYXNldGFibGUtPmdwdF9oZWFkcyAqIGJhc2V0
 YWJsZS0+Z3B0X3NlY3RvcnM7CiAKIAliY29weShidWYsIHRhYmxlLT5ib290LCBzaXplb2YodGFi
 bGUtPmJvb3QpKTsKSW5kZXg6IGdfcGFydF92dG9jOC5jCj09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdfcGFydF92
 dG9jOC5jCShyZXZpc2lvbiAyMDY0MjMpCisrKyBnX3BhcnRfdnRvYzguYwkod29ya2luZyBjb3B5
 KQpAQCAtMzY2LDYgKzM4OSw5IEBAIGdfcGFydF92dG9jOF9yZWFkKHN0cnVjdCBnX3BhcnRfdGFi
 bGUgKmJhc2V0YWJsZSwKIAlnX2ZyZWUoYnVmKTsKIAogCW1zaXplID0gcHAtPm1lZGlhc2l6ZSAv
 IHBwLT5zZWN0b3JzaXplOworCWlmIChiYXNldGFibGUtPmdwdF9zZWN0b3JzID09IDAgfHwgYmFz
 ZXRhYmxlLT5ncHRfaGVhZHMgPT0gMCkKKwkJZ19wYXJ0X2luaXRfZ2VvbWV0cnkobXNpemUsICZi
 YXNldGFibGUtPmdwdF9zZWN0b3JzLAorCQkgICAgJmJhc2V0YWJsZS0+Z3B0X2hlYWRzKTsKIAog
 CXNlY3RvcnMgPSBiZTE2ZGVjKCZ0YWJsZS0+dnRvYy5uc2Vjcyk7CiAJaWYgKHNlY3RvcnMgPCAx
 KQpJbmRleDogZ19wYXJ0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ19wYXJ0LmgJKHJldmlzaW9uIDIwNjQy
 MykKKysrIGdfcGFydC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsNiArMTg4LDcgQEAgc3RydWN0
 IGdfcGFydF9wYXJtcyB7CiB9OwogCiB2b2lkIGdfcGFydF9nZW9tZXRyeV9oZWFkcyhvZmZfdCwg
 dV9pbnQsIG9mZl90ICosIHVfaW50ICopOwordm9pZCBnX3BhcnRfaW5pdF9nZW9tZXRyeShvZmZf
 dCAsIHVfaW50ICosIHVfaW50ICopOwogCiBpbnQgZ19wYXJ0X21vZGV2ZW50KG1vZHVsZV90LCBp
 bnQsIHN0cnVjdCBnX3BhcnRfc2NoZW1lICopOwogCkluZGV4OiBnX3BhcnRfYnNkLmMKPT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PQotLS0gZ19wYXJ0X2JzZC5jCShyZXZpc2lvbiAyMDY0MjMpCisrKyBnX3BhcnRfYnNkLmMJ
 KHdvcmtpbmcgY29weSkKQEAgLTM0MSw2ICszNTcsOSBAQCBnX3BhcnRfYnNkX3JlYWQoc3RydWN0
 IGdfcGFydF90YWJsZSAqYmFzZXRhYmxlLCBzdAogCXBwID0gY3AtPnByb3ZpZGVyOwogCXRhYmxl
 ID0gKHN0cnVjdCBnX3BhcnRfYnNkX3RhYmxlICopYmFzZXRhYmxlOwogCW1zaXplID0gcHAtPm1l
 ZGlhc2l6ZSAvIHBwLT5zZWN0b3JzaXplOworCWlmIChiYXNldGFibGUtPmdwdF9zZWN0b3JzID09
 IDAgfHwgYmFzZXRhYmxlLT5ncHRfaGVhZHMgPT0gMCkKKwkJZ19wYXJ0X2luaXRfZ2VvbWV0cnko
 bXNpemUsICZiYXNldGFibGUtPmdwdF9zZWN0b3JzLAorCQkgICAgJmJhc2V0YWJsZS0+Z3B0X2hl
 YWRzKTsKIAogCXRhYmxlLT5iYmFyZWEgPSBnX3JlYWRfZGF0YShjcCwgMCwgQkJTSVpFLCAmZXJy
 b3IpOwogCWlmICh0YWJsZS0+YmJhcmVhID09IE5VTEwpCkluZGV4OiBnX3BhcnRfZWJyLmMKPT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PQotLS0gZ19wYXJ0X2Vici5jCShyZXZpc2lvbiAyMDY0MjMpCisrKyBnX3BhcnRfZWJy
 LmMJKHdvcmtpbmcgY29weSkKQEAgLTQ1NSw2ICs0NTUsOSBAQCBnX3BhcnRfZWJyX3JlYWQoc3Ry
 dWN0IGdfcGFydF90YWJsZSAqYmFzZXRhYmxlLCBzdAogCXBwID0gY3AtPnByb3ZpZGVyOwogCXRh
 YmxlID0gKHN0cnVjdCBnX3BhcnRfZWJyX3RhYmxlICopYmFzZXRhYmxlOwogCW1zaXplID0gcHAt
 Pm1lZGlhc2l6ZSAvIHBwLT5zZWN0b3JzaXplOworCWlmIChiYXNldGFibGUtPmdwdF9zZWN0b3Jz
 ID09IDAgfHwgYmFzZXRhYmxlLT5ncHRfaGVhZHMgPT0gMCkKKwkJZ19wYXJ0X2luaXRfZ2VvbWV0
 cnkobXNpemUsICZiYXNldGFibGUtPmdwdF9zZWN0b3JzLAorCQkgICAgJmJhc2V0YWJsZS0+Z3B0
 X2hlYWRzKTsKIAogCWxiYSA9IDA7CiAJd2hpbGUgKDEpIHsKSW5kZXg6IGdfcGFydC5jCj09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT0KLS0tIGdfcGFydC5jCShyZXZpc2lvbiAyMDY0MjMpCisrKyBnX3BhcnQuYwkod29ya2lu
 ZyBjb3B5KQpAQCAtMTgwLDQ2ICsxODAsNTMgQEAgZ19wYXJ0X2dlb21ldHJ5X2hlYWRzKG9mZl90
 IGJsb2NrcywgdV9pbnQgc2VjdG9ycywKIAl9CiB9CiAKK3ZvaWQKK2dfcGFydF9pbml0X2dlb21l
 dHJ5KG9mZl90IGJsb2NrcywgdV9pbnQgKnNlY3RvcnMsIHVfaW50ICpoZWFkcykKK3sKKwlzdGF0
 aWMgdV9pbnQgY2FuZGlkYXRlX3NlY3RvcnNbXSA9IHsgMSwgOSwgMTcsIDMzLCA2MywgMCB9Owor
 CW9mZl90IGNocywgYmVzdGNocyA9IDA7CisJdV9pbnQgaCwgczsKKwlpbnQgaWR4OworCisJKmhl
 YWRzID0gKnNlY3RvcnMgPSAwOworCWZvciAoaWR4ID0gMDsgY2FuZGlkYXRlX3NlY3RvcnNbaWR4
 XSAhPSAwOyBpZHgrKykgeworCQlzID0gY2FuZGlkYXRlX3NlY3RvcnNbaWR4XTsKKwkJZ19wYXJ0
 X2dlb21ldHJ5X2hlYWRzKGJsb2NrcywgcywgJmNocywgJmgpOworCQlpZiAoY2hzID09IDApCisJ
 CQljb250aW51ZTsKKwkJLyoKKwkJICogUHJlZmVyIGEgZ2VvbWV0cnkgd2l0aCBzZWN0b3JzID4g
 MSwgYnV0IG9ubHkgaWYKKwkJICogaXQgZG9lc24ndCBidW1wIGRvd24gdGhlIG51bWJ2ZXIgb2Yg
 aGVhZHMgdG8gMS4KKwkJICovCisJCWlmIChjaHMgPiBiZXN0Y2hzIHx8IChjaHMgPT0gYmVzdGNo
 cyAmJiBoID4gMSAmJgorCQkgICAgKnNlY3RvcnMgPT0gMSkpIHsKKwkJCWJlc3RjaHMgPSBjaHM7
 CisJCQkqaGVhZHMgPSBoOworCQkJKnNlY3RvcnMgPSBzOworCQl9CisJfQorCS8qCisJICogSWYg
 d2UgZGlkbid0IGZpbmQgYSBnZW9tZXRyeSBhdCBhbGwsIHRoZW4gdGhlIGRpc2sgaXMKKwkgKiB0
 b28gYmlnLiBUaGlzIG1lYW5zIHdlIGNhbiB1c2UgdGhlIG1heGltdW0gbnVtYmVyIG9mCisJICog
 aGVhZHMgYW5kIHNlY3RvcnMuCisJICovCisJaWYgKGJlc3RjaHMgPT0gMCkgeworCQkqaGVhZHMg
 PSAyNTU7CisJCSpzZWN0b3JzID0gNjM7CisJfQorfQorCiBzdGF0aWMgdm9pZAogZ19wYXJ0X2dl
 b21ldHJ5KHN0cnVjdCBnX3BhcnRfdGFibGUgKnRhYmxlLCBzdHJ1Y3QgZ19jb25zdW1lciAqY3As
 CiAgICAgb2ZmX3QgYmxvY2tzKQogewotCXN0YXRpYyB1X2ludCBjYW5kaWRhdGVfc2VjdG9yc1td
 ID0geyAxLCA5LCAxNywgMzMsIDYzLCAwIH07Ci0Jb2ZmX3QgY2hzLCBiZXN0Y2hzOwogCXVfaW50
 IGhlYWRzLCBzZWN0b3JzOwotCWludCBpZHg7CiAKIAlpZiAoZ19nZXRhdHRyKCJHRU9NOjpmd3Nl
 Y3RvcnMiLCBjcCwgJnNlY3RvcnMpICE9IDAgfHwgc2VjdG9ycyA9PSAwIHx8CiAJICAgIGdfZ2V0
 YXR0cigiR0VPTTo6ZndoZWFkcyIsIGNwLCAmaGVhZHMpICE9IDAgfHwgaGVhZHMgPT0gMCkgewog
 CQl0YWJsZS0+Z3B0X2ZpeGdlb20gPSAwOwotCQl0YWJsZS0+Z3B0X2hlYWRzID0gMDsKLQkJdGFi
 bGUtPmdwdF9zZWN0b3JzID0gMDsKLQkJYmVzdGNocyA9IDA7Ci0JCWZvciAoaWR4ID0gMDsgY2Fu
 ZGlkYXRlX3NlY3RvcnNbaWR4XSAhPSAwOyBpZHgrKykgewotCQkJc2VjdG9ycyA9IGNhbmRpZGF0
 ZV9zZWN0b3JzW2lkeF07Ci0JCQlnX3BhcnRfZ2VvbWV0cnlfaGVhZHMoYmxvY2tzLCBzZWN0b3Jz
 LCAmY2hzLCAmaGVhZHMpOwotCQkJaWYgKGNocyA9PSAwKQotCQkJCWNvbnRpbnVlOwotCQkJLyoK
 LQkJCSAqIFByZWZlciBhIGdlb21ldHJ5IHdpdGggc2VjdG9ycyA+IDEsIGJ1dCBvbmx5IGlmCi0J
 CQkgKiBpdCBkb2Vzbid0IGJ1bXAgZG93biB0aGUgbnVtYnZlciBvZiBoZWFkcyB0byAxLgotCQkJ
 ICovCi0JCQlpZiAoY2hzID4gYmVzdGNocyB8fCAoY2hzID09IGJlc3RjaHMgJiYgaGVhZHMgPiAx
 ICYmCi0JCQkgICAgdGFibGUtPmdwdF9zZWN0b3JzID09IDEpKSB7Ci0JCQkJYmVzdGNocyA9IGNo
 czsKLQkJCQl0YWJsZS0+Z3B0X2hlYWRzID0gaGVhZHM7Ci0JCQkJdGFibGUtPmdwdF9zZWN0b3Jz
 ID0gc2VjdG9yczsKLQkJCX0KLQkJfQotCQkvKgotCQkgKiBJZiB3ZSBkaWRuJ3QgZmluZCBhIGdl
 b21ldHJ5IGF0IGFsbCwgdGhlbiB0aGUgZGlzayBpcwotCQkgKiB0b28gYmlnLiBUaGlzIG1lYW5z
 IHdlIGNhbiB1c2UgdGhlIG1heGltdW0gbnVtYmVyIG9mCi0JCSAqIGhlYWRzIGFuZCBzZWN0b3Jz
 LgotCQkgKi8KLQkJaWYgKGJlc3RjaHMgPT0gMCkgewotCQkJdGFibGUtPmdwdF9oZWFkcyA9IDI1
 NTsKLQkJCXRhYmxlLT5ncHRfc2VjdG9ycyA9IDYzOwotCQl9CisJCWdfcGFydF9pbml0X2dlb21l
 dHJ5KGJsb2NrcywgJnRhYmxlLT5ncHRfc2VjdG9ycywKKwkJICAgICZ0YWJsZS0+Z3B0X2hlYWRz
 KTsKIAl9IGVsc2UgewogCQl0YWJsZS0+Z3B0X2ZpeGdlb20gPSAxOwogCQl0YWJsZS0+Z3B0X2hl
 YWRzID0gaGVhZHM7CkluZGV4OiBnX3BhcnRfbWJyLmMKPT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ19wYXJ0X21i
 ci5jCShyZXZpc2lvbiAyMDY0MjMpCisrKyBnX3BhcnRfbWJyLmMJKHdvcmtpbmcgY29weSkKQEAg
 LTM4Niw2ICs0MTQsMTAgQEAgZ19wYXJ0X21icl9yZWFkKHN0cnVjdCBnX3BhcnRfdGFibGUgKmJh
 c2V0YWJsZSwgc3QKIAl0YWJsZSA9IChzdHJ1Y3QgZ19wYXJ0X21icl90YWJsZSAqKWJhc2V0YWJs
 ZTsKIAltc2l6ZSA9IHBwLT5tZWRpYXNpemUgLyBwcC0+c2VjdG9yc2l6ZTsKIAorCWlmIChiYXNl
 dGFibGUtPmdwdF9zZWN0b3JzID09IDAgfHwgYmFzZXRhYmxlLT5ncHRfaGVhZHMgPT0gMCkKKwkJ
 Z19wYXJ0X2luaXRfZ2VvbWV0cnkobXNpemUsICZiYXNldGFibGUtPmdwdF9zZWN0b3JzLAorCQkg
 ICAgJmJhc2V0YWJsZS0+Z3B0X2hlYWRzKTsKKwogCWJ1ZiA9IGdfcmVhZF9kYXRhKGNwLCAwTCwg
 cHAtPnNlY3RvcnNpemUsICZlcnJvcik7CiAJaWYgKGJ1ZiA9PSBOVUxMKQogCQlyZXR1cm4gKGVy
 cm9yKTsK
 ------==--bound.20366.web44.yandex.ru--
State-Changed-From-To: open->patched 
State-Changed-By: marcel 
State-Changed-When: Sun Apr 25 02:00:05 UTC 2010 
State-Changed-Why:  
A fix has been committed to head. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145452 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/145452: commit references a PR
Date: Sun, 25 Apr 2010 01:57:02 +0000 (UTC)

 Author: marcel
 Date: Sun Apr 25 01:56:39 2010
 New Revision: 207181
 URL: http://svn.freebsd.org/changeset/base/207181
 
 Log:
   Re-calculate a geometry when reprobing as well.
   
   PR:		kern/145452
   Reported by:	"Andrey V. Elsukov" <bu7cher@yandex.ru>
 
 Modified:
   head/sys/geom/part/g_part.c
 
 Modified: head/sys/geom/part/g_part.c
 ==============================================================================
 --- head/sys/geom/part/g_part.c	Sun Apr 25 01:56:31 2010	(r207180)
 +++ head/sys/geom/part/g_part.c	Sun Apr 25 01:56:39 2010	(r207181)
 @@ -1166,6 +1166,15 @@ g_part_ctl_undo(struct gctl_req *req, st
  			return (0);
  		}
  		table = gp->softc;
 +
 +		/*
 +		 * Synthesize a disk geometry. Some partitioning schemes
 +		 * depend on it and since some file systems need it even
 +		 * when the partitition scheme doesn't, we do it here in
 +		 * scheme-independent code.
 +		 */
 +		pp = cp->provider;
 +		g_part_geometry(table, cp, pp->mediasize / pp->sectorsize);
  	}
  
  	error = G_PART_READ(table, cp);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/145452: commit references a PR
Date: Mon,  7 Jun 2010 10:22:31 +0000 (UTC)

 Author: ae
 Date: Mon Jun  7 10:22:22 2010
 New Revision: 208890
 URL: http://svn.freebsd.org/changeset/base/208890
 
 Log:
   MFC r207181:
   
   Re-calculate a geometry when reprobing as well.
   
   PR:		kern/145452
   Reviewed by:	marcel
   Approved by:	kib (mentor)
   Approved by:	re (bz)
 
 Modified:
   stable/8/sys/geom/part/g_part.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
   stable/8/sys/geom/sched/   (props changed)
 
 Modified: stable/8/sys/geom/part/g_part.c
 ==============================================================================
 --- stable/8/sys/geom/part/g_part.c	Mon Jun  7 10:10:44 2010	(r208889)
 +++ stable/8/sys/geom/part/g_part.c	Mon Jun  7 10:22:22 2010	(r208890)
 @@ -1067,6 +1067,15 @@ g_part_ctl_undo(struct gctl_req *req, st
  			return (0);
  		}
  		table = gp->softc;
 +
 +		/*
 +		 * Synthesize a disk geometry. Some partitioning schemes
 +		 * depend on it and since some file systems need it even
 +		 * when the partitition scheme doesn't, we do it here in
 +		 * scheme-independent code.
 +		 */
 +		pp = cp->provider;
 +		g_part_geometry(table, cp, pp->mediasize / pp->sectorsize);
  	}
  
  	error = G_PART_READ(table, cp);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: ae 
State-Changed-When: Sat Jul 10 16:49:06 UTC 2010 
State-Changed-Why:  
Close my PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145452 
>Unformatted:
