From nobody@FreeBSD.org  Wed Mar 31 08:04:58 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 253E11065676
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 31 Mar 2010 08:04:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 143EC8FC1E
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 31 Mar 2010 08:04:58 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2V84vO3073141
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 31 Mar 2010 08:04:57 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o2V84v41073140;
	Wed, 31 Mar 2010 08:04:57 GMT
	(envelope-from nobody)
Message-Id: <201003310804.o2V84v41073140@www.freebsd.org>
Date: Wed, 31 Mar 2010 08:04:57 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Fix compiler warning with libficl by exporting dictCheckThreshold in ficl.h
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         145232
>Category:       kern
>Synopsis:       [boot] [patch] Fix compiler warning with libficl by exporting dictCheckThreshold in ficl.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brian
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 31 08:10:08 UTC 2010
>Closed-Date:    Mon Jun 28 07:16:08 UTC 2010
>Last-Modified:  Sun Feb 03 22:28:29 UTC 2013
>Originator:     Garrett Cooper
>Release:        9-CURRENT
>Organization:
Cisco Systems, Inc.
>Environment:
FreeBSD bayonetta.local 9.0-CURRENT FreeBSD 9.0-CURRENT #5 r205310: Sat Mar 20 01:32:51 PDT 2010     gcooper@bayonetta.local:/usr/obj/usr/src/sys/BAYONETTA  amd64
>Description:
There's a compiler warning that pops up when you compile sys/boot/ficl:

cc -O2 -pipe -fno-strict-aliasing -pipe -O2 -march=nocona -ffreestanding -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -std=gnu99   -m32 -march=i386 -I. -I/scratch/freebsd/releng_8/sys/boot/ficl -I/scratch/freebsd/releng_8/sys/boot/ficl/i386  -I/scratch/freebsd/releng_8/sys/boot/ficl/../common -c words.c
words.c: In function 'colon':
words.c:467: warning: implicit declaration of function 'dictCheckThreshold'

This patch takes care of the warning by exporting dictCheckThreshold via ficl.h
>How-To-Repeat:
make -C sys/boot/ficl clean all
>Fix:


Patch attached with submission follows:

Index: /usr/src/sys/boot/ficl/ficl.h
===================================================================
--- /usr/src/sys/boot/ficl/ficl.h	(revision 205872)
+++ /usr/src/sys/boot/ficl/ficl.h	(working copy)
@@ -757,6 +757,7 @@
 int         dictCellsAvail (FICL_DICT *pDict);
 int         dictCellsUsed  (FICL_DICT *pDict);
 void        dictCheck      (FICL_DICT *pDict, FICL_VM *pVM, int n);
+void        dictCheckThreshold(FICL_DICT* dp);
 FICL_DICT  *dictCreate(unsigned nCELLS);
 FICL_DICT  *dictCreateHashed(unsigned nCells, unsigned nHash);
 FICL_HASH  *dictCreateWordlist(FICL_DICT *dp, int nBuckets);


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brian 
State-Changed-When: Sun Jun 20 07:59:29 UTC 2010 
State-Changed-Why:  
Submitted to head (r209361).  I'll MFC after 1 week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145232 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/145232: commit references a PR
Date: Sun, 20 Jun 2010 08:03:20 +0000 (UTC)

 Author: brian
 Date: Sun Jun 20 08:03:06 2010
 New Revision: 209361
 URL: http://svn.freebsd.org/changeset/base/209361
 
 Log:
   Add a missing prototype
   
   PR:		145232
   Submitted by:	gcooper
   MFC after:	1 week
 
 Modified:
   head/sys/boot/ficl/ficl.h
 
 Modified: head/sys/boot/ficl/ficl.h
 ==============================================================================
 --- head/sys/boot/ficl/ficl.h	Sun Jun 20 06:52:10 2010	(r209360)
 +++ head/sys/boot/ficl/ficl.h	Sun Jun 20 08:03:06 2010	(r209361)
 @@ -757,6 +757,7 @@ void        dictAppendUNS  (FICL_DICT *p
  int         dictCellsAvail (FICL_DICT *pDict);
  int         dictCellsUsed  (FICL_DICT *pDict);
  void        dictCheck      (FICL_DICT *pDict, FICL_VM *pVM, int n);
 +void        dictCheckThreshold(FICL_DICT* dp);
  FICL_DICT  *dictCreate(unsigned nCELLS);
  FICL_DICT  *dictCreateHashed(unsigned nCells, unsigned nHash);
  FICL_HASH  *dictCreateWordlist(FICL_DICT *dp, int nBuckets);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: freebsd-bugs->brian 
Responsible-Changed-By: brian 
Responsible-Changed-When: Sun Jun 20 19:55:39 UTC 2010 
Responsible-Changed-Why:  
Take 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145232 
State-Changed-From-To: patched->closed 
State-Changed-By: brian 
State-Changed-When: Mon Jun 28 07:15:49 UTC 2010 
State-Changed-Why:  
Merged to stable/8, r209563. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145232 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/145232: commit references a PR
Date: Mon, 28 Jun 2010 07:15:50 +0000 (UTC)

 Author: brian
 Date: Mon Jun 28 07:15:30 2010
 New Revision: 209563
 URL: http://svn.freebsd.org/changeset/base/209563
 
 Log:
   MFC r209361; Add a missing prototype
   
   PR:		145232
   Submitted by:	gcooper
 
 Modified:
   stable/8/sys/boot/ficl/ficl.h
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/boot/ficl/ficl.h
 ==============================================================================
 --- stable/8/sys/boot/ficl/ficl.h	Mon Jun 28 07:03:18 2010	(r209562)
 +++ stable/8/sys/boot/ficl/ficl.h	Mon Jun 28 07:15:30 2010	(r209563)
 @@ -757,6 +757,7 @@ void        dictAppendUNS  (FICL_DICT *p
  int         dictCellsAvail (FICL_DICT *pDict);
  int         dictCellsUsed  (FICL_DICT *pDict);
  void        dictCheck      (FICL_DICT *pDict, FICL_VM *pVM, int n);
 +void        dictCheckThreshold(FICL_DICT* dp);
  FICL_DICT  *dictCreate(unsigned nCELLS);
  FICL_DICT  *dictCreateHashed(unsigned nCells, unsigned nHash);
  FICL_HASH  *dictCreateWordlist(FICL_DICT *dp, int nBuckets);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
