From nobody@FreeBSD.org  Sat Mar  6 09:38:39 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7EB021065673
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  6 Mar 2010 09:38:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6EEC28FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  6 Mar 2010 09:38:39 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o269ccbS097987
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 6 Mar 2010 09:38:38 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o269ccgC097986;
	Sat, 6 Mar 2010 09:38:38 GMT
	(envelope-from nobody)
Message-Id: <201003060938.o269ccgC097986@www.freebsd.org>
Date: Sat, 6 Mar 2010 09:38:38 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Error in macro CALC_COEFF2.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         144505
>Category:       kern
>Synopsis:       [bwn] [patch] Error in macro CALC_COEFF2.
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    weongyo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 06 09:40:01 UTC 2010
>Closed-Date:    Mon Sep 06 22:29:13 UTC 2010
>Last-Modified:  Mon Sep  6 22:30:07 UTC 2010
>Originator:     Henning Petersen
>Release:        Freebsd-current
>Organization:
>Environment:
>Description:
Error in macro CALC_COEFF2, rename tmp[3] to _v. Found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.10 if_bwn.c
--- sys/dev/bwn/if_bwn.c	3 Mar 2010 20:06:09 -0000	1.10
+++ sys/dev/bwn/if_bwn.c	6 Mar 2010 09:06:04 -0000
@@ -12910,9 +12910,9 @@
 	int _t;								\
 	_t = _x - 11;							\
 	if (_t >= 0)							\
-		tmp[3] = (_y << (31 - _x)) / (_z >> _t);		\
+		_v = (_y << (31 - _x)) / (_z >> _t);			\
 	else								\
-		tmp[3] = (_y << (31 - _x)) / (_z << -_t);		\
+		_v = (_y << (31 - _x)) / (_z << -_t);			\
 } while (0)
 	struct bwn_phy_lp_iq_est ie;
 	uint16_t v0, v1;


Patch attached with submission follows:

diff -u -r1.10 if_bwn.c
--- sys/dev/bwn/if_bwn.c	3 Mar 2010 20:06:09 -0000	1.10
+++ sys/dev/bwn/if_bwn.c	6 Mar 2010 09:06:04 -0000
@@ -12910,9 +12910,9 @@
 	int _t;								\
 	_t = _x - 11;							\
 	if (_t >= 0)							\
-		tmp[3] = (_y << (31 - _x)) / (_z >> _t);		\
+		_v = (_y << (31 - _x)) / (_z >> _t);			\
 	else								\
-		tmp[3] = (_y << (31 - _x)) / (_z << -_t);		\
+		_v = (_y << (31 - _x)) / (_z << -_t);			\
 } while (0)
 	struct bwn_phy_lp_iq_est ie;
 	uint16_t v0, v1;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Sat Mar 6 10:08:44 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144505 
Responsible-Changed-From-To: freebsd-net->weongyo 
Responsible-Changed-By: weongyo 
Responsible-Changed-When: Thu Jul 22 20:02:51 UTC 2010 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144505 
State-Changed-From-To: open->patched 
State-Changed-By: weongyo 
State-Changed-When: Thu Jul 22 20:08:11 UTC 2010 
State-Changed-Why:  
It's commited at r210393.  Thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144505 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/144505: commit references a PR
Date: Thu, 22 Jul 2010 20:08:11 +0000 (UTC)

 Author: weongyo
 Date: Thu Jul 22 20:08:02 2010
 New Revision: 210393
 URL: http://svn.freebsd.org/changeset/base/210393
 
 Log:
   Fixes a mistake to calculate CALC_COEFF2() value that tmp[3] is
   used even if it's unreachable.
   
   PR:		kern/144505
   Submitted by:	Henning Petersen <henning.petersen at t-online dot de>
   MFC after:	1 week
 
 Modified:
   head/sys/dev/bwn/if_bwn.c
 
 Modified: head/sys/dev/bwn/if_bwn.c
 ==============================================================================
 --- head/sys/dev/bwn/if_bwn.c	Thu Jul 22 19:30:13 2010	(r210392)
 +++ head/sys/dev/bwn/if_bwn.c	Thu Jul 22 20:08:02 2010	(r210393)
 @@ -12828,9 +12828,9 @@ bwn_phy_lp_calc_rx_iq_comp(struct bwn_ma
  	int _t;								\
  	_t = _x - 11;							\
  	if (_t >= 0)							\
 -		tmp[3] = (_y << (31 - _x)) / (_z >> _t);		\
 +		_v = (_y << (31 - _x)) / (_z >> _t);			\
  	else								\
 -		tmp[3] = (_y << (31 - _x)) / (_z << -_t);		\
 +		_v = (_y << (31 - _x)) / (_z << -_t);			\
  } while (0)
  	struct bwn_phy_lp_iq_est ie;
  	uint16_t v0, v1;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: weongyo 
State-Changed-When: Mon Sep 6 22:28:55 UTC 2010 
State-Changed-Why:  
MFCed into STABLE_8 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144505 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/144505: commit references a PR
Date: Mon,  6 Sep 2010 22:29:01 +0000 (UTC)

 Author: weongyo
 Date: Mon Sep  6 22:28:46 2010
 New Revision: 212273
 URL: http://svn.freebsd.org/changeset/base/212273
 
 Log:
   MFC r210393:
     Fixes a mistake to calculate CALC_COEFF2() value that tmp[3] is
     used even if it's unreachable.
   
     PR:		kern/144505
     Submitted by:	Henning Petersen <henning.petersen at t-online dot de>
 
 Modified:
   stable/8/sys/dev/bwn/if_bwn.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/dev/bwn/if_bwn.c
 ==============================================================================
 --- stable/8/sys/dev/bwn/if_bwn.c	Mon Sep  6 22:23:35 2010	(r212272)
 +++ stable/8/sys/dev/bwn/if_bwn.c	Mon Sep  6 22:28:46 2010	(r212273)
 @@ -12828,9 +12828,9 @@ bwn_phy_lp_calc_rx_iq_comp(struct bwn_ma
  	int _t;								\
  	_t = _x - 11;							\
  	if (_t >= 0)							\
 -		tmp[3] = (_y << (31 - _x)) / (_z >> _t);		\
 +		_v = (_y << (31 - _x)) / (_z >> _t);			\
  	else								\
 -		tmp[3] = (_y << (31 - _x)) / (_z << -_t);		\
 +		_v = (_y << (31 - _x)) / (_z << -_t);			\
  } while (0)
  	struct bwn_phy_lp_iq_est ie;
  	uint16_t v0, v1;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
