From danny@cs.huji.ac.il  Thu Mar  4 09:01:29 2010
Return-Path: <danny@cs.huji.ac.il>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9034F106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 Mar 2010 09:01:29 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.16.84])
	by mx1.freebsd.org (Postfix) with ESMTP id 0D6738FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 Mar 2010 09:01:28 +0000 (UTC)
Received: from sunfire.cs.huji.ac.il ([132.65.16.80])
	by kabab.cs.huji.ac.il with esmtp
	id 1Nn6vv-000KKY-Fu
	for FreeBSD-gnats-submit@freebsd.org; Thu, 04 Mar 2010 11:01:27 +0200
Received: from danny by sunfire.cs.huji.ac.il with local (Exim 4.71 (FreeBSD))
	(envelope-from <danny@cs.huji.ac.il>)
	id 1Nn6vv-000Lgo-FY
	for FreeBSD-gnats-submit@freebsd.org; Thu, 04 Mar 2010 11:01:27 +0200
Message-Id: <E1Nn6vv-000Lgo-FY@sunfire.cs.huji.ac.il>
Date: Thu, 04 Mar 2010 11:01:27 +0200
From: Daniel Braniss <danny@cs.huji.ac.il>
Reply-To: Daniel Braniss <danny@cs.huji.ac.il>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: nfsd failes as a klm
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         144458
>Category:       kern
>Synopsis:       [nfs] [patch] nfsd fails as a kld
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    rmacklem
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 04 09:10:03 UTC 2010
>Closed-Date:    Mon Apr 11 20:14:47 UTC 2011
>Last-Modified:  Mon Apr 11 20:14:47 UTC 2011
>Originator:     Daniel Braniss
>Release:        FreeBSD 8.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD sunfire 8.0-STABLE FreeBSD 8.0-STABLE #62 r1468: Fri Feb 5 09:40:49 IST 2010 danny@sunfire:/r+d/obj/sunfire/r+d/stable/8/sys/HUJI amd64


	
>Description:
	kldload nfsd results in:
		link_elf_obj: symbol nfsd_call_nfsd undefined

>How-To-Repeat:
	kldload nfsd
>Fix:

--- a/sys/fs/nfsserver/nfs_nfsdport.c   Mon Mar 01 18:29:54 2010 +0200
+++ b/sys/fs/nfsserver/nfs_nfsdport.c   Thu Mar 04 10:46:27 2010 +0200
@@ -3143,6 +3143,7 @@
 
 /* So that loader and kldload(2) can find us, wherever we are.. */
 MODULE_VERSION(nfsd, 1);
+MODULE_DEPEND(nfsd, nfssvc, 1, 1, 1);
 MODULE_DEPEND(nfsd, nfscommon, 1, 1, 1);
 MODULE_DEPEND(nfsd, nfslockd, 1, 1, 1);
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Mar 4 14:08:46 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144458 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/144458: commit references a PR
Date: Tue, 15 Jun 2010 00:25:16 +0000 (UTC)

 Author: rmacklem
 Date: Tue Jun 15 00:25:04 2010
 New Revision: 209191
 URL: http://svn.freebsd.org/changeset/base/209191
 
 Log:
   Add MODULE_DEPEND() macros to the experimental NFS client and
   server so that the modules will load when kernels are built with
   none of the NFS* configuration options specified. I believe this
   resolves the problems reported by PR kern/144458 and the email on
   freebsd-stable@ posted by Dmitry Pryanishnikov on June 13.
   
   Tested by:	kib
   PR:		kern/144458
   Reviewed by:	kib
   MFC after:	1 week
 
 Modified:
   head/sys/fs/nfsclient/nfs_clport.c
   head/sys/fs/nfsserver/nfs_nfsdport.c
 
 Modified: head/sys/fs/nfsclient/nfs_clport.c
 ==============================================================================
 --- head/sys/fs/nfsclient/nfs_clport.c	Mon Jun 14 23:51:35 2010	(r209190)
 +++ head/sys/fs/nfsclient/nfs_clport.c	Tue Jun 15 00:25:04 2010	(r209191)
 @@ -1275,4 +1275,6 @@ DECLARE_MODULE(nfscl, nfscl_mod, SI_SUB_
  /* So that loader and kldload(2) can find us, wherever we are.. */
  MODULE_VERSION(nfscl, 1);
  MODULE_DEPEND(nfscl, nfscommon, 1, 1, 1);
 +MODULE_DEPEND(nfscl, krpc, 1, 1, 1);
 +MODULE_DEPEND(nfscl, nfssvc, 1, 1, 1);
  
 
 Modified: head/sys/fs/nfsserver/nfs_nfsdport.c
 ==============================================================================
 --- head/sys/fs/nfsserver/nfs_nfsdport.c	Mon Jun 14 23:51:35 2010	(r209190)
 +++ head/sys/fs/nfsserver/nfs_nfsdport.c	Tue Jun 15 00:25:04 2010	(r209191)
 @@ -3147,4 +3147,6 @@ DECLARE_MODULE(nfsd, nfsd_mod, SI_SUB_VF
  MODULE_VERSION(nfsd, 1);
  MODULE_DEPEND(nfsd, nfscommon, 1, 1, 1);
  MODULE_DEPEND(nfsd, nfslockd, 1, 1, 1);
 +MODULE_DEPEND(nfsd, krpc, 1, 1, 1);
 +MODULE_DEPEND(nfsd, nfssvc, 1, 1, 1);
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Tue Mar 1 10:15:42 EST 2011 
State-Changed-Why:  
committed in head (r209191) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144458 
Responsible-Changed-From-To: freebsd-fs->rmacklem 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Mar 1 10:23:02 EST 2011 
Responsible-Changed-Why:  
same as above 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144458 
State-Changed-From-To: patched->closed 
State-Changed-By: rmacklem 
State-Changed-When: Mon Apr 11 20:13:12 UTC 2011 
State-Changed-Why:  


Head and stable have the patch and no longer have problems 
loading as a kld, as far as I know. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144458 
>Unformatted:
