From sec@pi.musin.de Sun Oct 17 06:31:54 1999
Return-Path: <sec@pi.musin.de>
Received: from yoda.pi.musin.de (yoda.pi.musin.de [194.246.250.12])
	by hub.freebsd.org (Postfix) with ESMTP id CD22814C3D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 17 Oct 1999 06:31:43 -0700 (PDT)
	(envelope-from sec@pi.musin.de)
Received: by yoda.pi.musin.de (Postfix, from userid 4242)
	id EBC7C349; Sun, 17 Oct 1999 15:31:41 +0200 (CEST)
Message-Id: <19991017133141.EBC7C349@yoda.pi.musin.de>
Date: Sun, 17 Oct 1999 15:31:41 +0200 (CEST)
From: sec@pi.musin.de
Reply-To: sec@yoda.pi.musin.de
To: FreeBSD-gnats-submit@freebsd.org
Subject: Log message is missing n
X-Send-Pr-Version: 3.2

>Number:         14371
>Category:       kern
>Synopsis:       Log message is missing \n
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sheldonh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 17 06:40:01 PDT 1999
>Closed-Date:    Mon Oct 18 04:59:09 PDT 1999
>Last-Modified:  Mon Oct 18 05:10:00 PDT 1999
>Originator:     Stefan `Sec` Zehl
>Release:        FreeBSD 3.3-STABLE i386
>Organization:
>Environment:

$FreeBSD: src/sys/netinet/if_ether.c,v 1.52.2.5 1999/09/16 00:50:37 lile Exp $

>Description:

The 'attempts to overwrite permanent arp entry' message is missing a \n at the
end.

See the following output-snippet of /etc/security

yoda kernel log messages:
> arp: 00:50:04:3d:38:14 attempts to modify permanent entry for 194.246.250.0 on ep0<3>arp: 00:50:04:3d:38:14 attempts to modify permanent entry for 194.246.250.0 on ep0<6>nfs server ewok:/usr/ports: not responding

>How-To-Repeat:

	

>Fix:
	
--- /usr/src/sys/netinet/if_ether.c	Thu Sep 16 19:23:25 1999
+++ /tmp/if_ether.c	Sun Oct 17 15:30:03 1999
@@ -556,7 +556,7 @@
 				ac->ac_if.if_name, ac->ac_if.if_unit);
 			else {
 			    log(LOG_ERR,
-				"arp: %6D attempts to modify permanent entry for %s on %s%d",
+				"arp: %6D attempts to modify permanent entry for %s on %s%d\n",
 				ea->arp_sha, ":", inet_ntoa(isaddr),
 				ac->ac_if.if_name, ac->ac_if.if_unit);
 			    goto reply;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sheldonh 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Mon Oct 18 04:50:49 PDT 1999 
Responsible-Changed-Why:  
Looks simple enough for me to handle. 
State-Changed-From-To: open->closed 
State-Changed-By: sheldonh 
State-Changed-When: Mon Oct 18 04:59:09 PDT 1999 
State-Changed-Why:  
Committed as rev 1.62 and merged to RELENG_3 branch as rev 1.52.2.6. 
Thanks! 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: sec@yoda.pi.musin.de
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: kern/14371: Log message is missing n 
Date: Mon, 18 Oct 1999 13:52:06 +0200

 On Sun, 17 Oct 1999 15:31:41 +0200, sec@pi.musin.de wrote:
 
 > The 'attempts to overwrite permanent arp entry' message is missing a
 > \n at the end.
 
 Introduced with a new message in rev 1.48 .  Once I'm sure there aren't
 any other log()'s requiring newlines, I'll commit. Thanks.
 
 Ciao,
 Sheldon.
 
>Unformatted:
