From nobody@FreeBSD.org  Sun Jan 24 13:24:46 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 55BE0106568D
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 24 Jan 2010 13:24:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 457268FC1D
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 24 Jan 2010 13:24:46 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0ODOjrP027226
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 24 Jan 2010 13:24:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o0ODOjgm027217;
	Sun, 24 Jan 2010 13:24:45 GMT
	(envelope-from nobody)
Message-Id: <201001241324.o0ODOjgm027217@www.freebsd.org>
Date: Sun, 24 Jan 2010 13:24:45 GMT
From: Alexander Egorenkov <egorenar@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Radiotap bug in ieee80211_sta.c:sta_input
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         143163
>Category:       kern
>Synopsis:       [ieee80211] [patch] Radiotap bug in ieee80211_sta.c:sta_input
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 24 13:30:01 UTC 2010
>Closed-Date:    Mon Jan 25 12:24:51 UTC 2010
>Last-Modified:  Fri Jan 29 18:20:10 UTC 2010
>Originator:     Alexander Egorenkov
>Release:        FreeBSD 8.0 STABLE
>Organization:
>Environment:
FreeBSD dantooine 8.0-RELEASE FreeBSD 8.0-RELEASE #2: Tue Dec 15 17:56:06 CET 2009     root@dantooine:/usr/obj/usr/src/sys/MYKERNEL  i386
>Description:
I have found a bug in ieee80211_sta.c:sta_input which causes some problems
with wireshark.

Here is a code fragment:

------------------------------------------------------

        /* copy to listener after decrypt */
	if (ieee80211_radiotap_active_vap(vap))
		ieee80211_radiotap_tx(vap, m);   <------- Bug
	need_tap = 0;
------------------------------------------------------
>How-To-Repeat:
I have found this bug by analyzing data packets with wireshark.
It causes wireshark to display wrong data.

Sniff some incoming packets with wireshark on a WLAN NIC.
>Fix:
he function sta_input handles incoming packets in STA mode in net80211 stack.
Thus, the right thing to do would be to call

       ieee80211_radiotap_rx(vap, m)
and not
       ieee80211_radiotap_tx(vap, m)

>Release-Note:
>Audit-Trail:

From: Alexander Egorenkov <egorenar@googlemail.com>
To: bug-followup@FreeBSD.org, egorenar@gmail.com
Cc:  
Subject: Re: kern/143163: Radiotap bug in ieee80211_sta.c:sta_input
Date: Sun, 24 Jan 2010 15:42:00 +0100

 --0016361374dc3008d6047dea0e2b
 Content-Type: text/plain; charset=ISO-8859-1
 
 I have replaced ieee80211_radiotap_tx with ieee80211_radiotap_rx and
 recompiled the kernel on my machine.
 And now it works fine and wireshark shows right radiotap header.
 
 --0016361374dc3008d6047dea0e2b--
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: remko 
Responsible-Changed-When: Sun Jan 24 18:49:29 UTC 2010 
Responsible-Changed-Why:  
Assign to networking guys. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143163 
State-Changed-From-To: open->closed 
State-Changed-By: rpaulo 
State-Changed-When: Mon Jan 25 12:24:24 UTC 2010 
State-Changed-Why:  
I've fixed this on HEAD. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143163 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/143163: commit references a PR
Date: Mon, 25 Jan 2010 12:24:02 +0000 (UTC)

 Author: rpaulo
 Date: Mon Jan 25 12:23:51 2010
 New Revision: 202967
 URL: http://svn.freebsd.org/changeset/base/202967
 
 Log:
   Call ieee80211_radiotap_rx, not ieee80211_radiotap_tx on sta_input()
   
   PR:		143163
   Submitted by:	Alexander Egorenkov <egorenar at gmail.com>
   MFC after:	3 days
 
 Modified:
   head/sys/net80211/ieee80211_sta.c
 
 Modified: head/sys/net80211/ieee80211_sta.c
 ==============================================================================
 --- head/sys/net80211/ieee80211_sta.c	Mon Jan 25 12:05:51 2010	(r202966)
 +++ head/sys/net80211/ieee80211_sta.c	Mon Jan 25 12:23:51 2010	(r202967)
 @@ -759,7 +759,7 @@ sta_input(struct ieee80211_node *ni, str
  
  		/* copy to listener after decrypt */
  		if (ieee80211_radiotap_active_vap(vap))
 -			ieee80211_radiotap_tx(vap, m);
 +			ieee80211_radiotap_rx(vap, m);
  		need_tap = 0;
  
  		/*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/143163: commit references a PR
Date: Fri, 29 Jan 2010 18:18:37 +0000 (UTC)

 Author: rpaulo
 Date: Fri Jan 29 18:18:18 2010
 New Revision: 203172
 URL: http://svn.freebsd.org/changeset/base/203172
 
 Log:
   MFC r202967:
      Call ieee80211_radiotap_rx, not ieee80211_radiotap_tx on sta_input()
   
      PR:		143163
      Submitted by:Alexander Egorenkov <egorenar at gmail.com>
 
 Modified:
   stable/8/sys/net80211/ieee80211_sta.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/net80211/ieee80211_sta.c
 ==============================================================================
 --- stable/8/sys/net80211/ieee80211_sta.c	Fri Jan 29 16:14:35 2010	(r203171)
 +++ stable/8/sys/net80211/ieee80211_sta.c	Fri Jan 29 18:18:18 2010	(r203172)
 @@ -759,7 +759,7 @@ sta_input(struct ieee80211_node *ni, str
  
  		/* copy to listener after decrypt */
  		if (ieee80211_radiotap_active_vap(vap))
 -			ieee80211_radiotap_tx(vap, m);
 +			ieee80211_radiotap_rx(vap, m);
  		need_tap = 0;
  
  		/*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
