From nobody@FreeBSD.org  Thu Jan 21 21:18:18 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2D164106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 Jan 2010 21:18:18 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1B9C68FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 Jan 2010 21:18:18 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0LLIHYP084749
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 Jan 2010 21:18:17 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o0LLIHmS084744;
	Thu, 21 Jan 2010 21:18:17 GMT
	(envelope-from nobody)
Message-Id: <201001212118.o0LLIHmS084744@www.freebsd.org>
Date: Thu, 21 Jan 2010 21:18:17 GMT
From: Mike Tancsa <mike@sentex.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Device ID for ichwd on the H55 Express chipset watchdog timer
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         143068
>Category:       kern
>Synopsis:       Device ID for ichwd on the H55 Express chipset watchdog timer
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    emaste
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 21 21:20:31 UTC 2010
>Closed-Date:    Tue Feb 23 01:24:34 UTC 2010
>Last-Modified:  Tue Feb 23 01:30:04 UTC 2010
>Originator:     Mike Tancsa
>Release:        9.0
>Organization:
Sentex Communications
>Environment:
FreeBSD i3.sentex.ca 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Thu Jan 21 15:14:14 EST 2010  
>Description:
Device ID to add support for the ichwd driver on the Intel H55 Express chipset (intel i3 cpus)


>How-To-Repeat:
kldload ichwd... The ID is not there, so the driver does not work
>Fix:
1(ich10)# diff -u orig/ichwd.c ichwd.c 
--- orig/ichwd.c        2009-11-07 06:41:23.000000000 -0500
+++ ichwd.c     2010-01-21 16:10:36.000000000 -0500
@@ -109,6 +109,7 @@
        { DEVICEID_ICH10D,   "Intel ICH10D watchdog timer",     10 },
        { DEVICEID_ICH10DO,  "Intel ICH10DO watchdog timer",    10 },
        { DEVICEID_ICH10R,   "Intel ICH10R watchdog timer",     10 },
+       { DEVICEID_H55EXP,   "Intel H55 Express watchdog timer",        10 },
        { 0, NULL, 0 },
 };
 
1(ich10)# diff -u orig/ichwd.h ichwd.h 
--- orig/ichwd.h        2008-08-25 11:23:54.000000000 -0400
+++ ichwd.h     2010-01-21 16:10:20.000000000 -0500
@@ -99,6 +99,7 @@
 #define DEVICEID_ICH10D                0x3a1a
 #define DEVICEID_ICH10DO       0x3a14
 #define DEVICEID_ICH10R                0x3a16
+#define DEVICEID_H55EXP                0x3b06
 
 /* ICH LPC Interface Bridge Registers (ICH5 and older) */
 #define ICH_GEN_STA            0xd4
1(ich10)# 

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->emaste 
Responsible-Changed-By: emaste 
Responsible-Changed-When: Fri Jan 22 03:38:23 UTC 2010 
Responsible-Changed-Why:  
Grab 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143068 

From: Andriy Gapon <avg@icyb.net.ua>
To: bug-followup@FreeBSD.org, Mike Tancsa <mike@sentex.net>,
        Ed Maste <emaste@FreeBSD.org>
Cc:  
Subject: Re: kern/143068: Device ID for ichwd on the H55 Express chipset watchdog
 timer
Date: Fri, 22 Jan 2010 15:03:22 +0200

 According to
   http://www.intel.com/Assets/PDF/specupdate/322170.pdf
   Section "PCH Device and Revision Identification" (page 9)
 I'd simply call it "H55 Chipset", i.e. dropped "EXP" and "Express" from ID and
 description respectively.
 
 Maybe other other devices belonging to the same chipset family could also be added
 along the way.
 
 -- 
 Andriy Gapon
State-Changed-From-To: open->patched 
State-Changed-By: emaste 
State-Changed-When: Fri Jan 22 16:05:21 UTC 2010 
State-Changed-Why:  
Committed as r202812. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143068 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/143068: commit references a PR
Date: Fri, 22 Jan 2010 16:05:25 +0000 (UTC)

 Author: emaste
 Date: Fri Jan 22 16:05:10 2010
 New Revision: 202812
 URL: http://svn.freebsd.org/changeset/base/202812
 
 Log:
   Add H55 ID from Mike Tancsa, with minor rewording from avg@.
   
   PR:		kern/143068
   Submitted by:	Mike Tancsa (Sentex)
   MFC after:	1 week
 
 Modified:
   head/sys/dev/ichwd/ichwd.c
   head/sys/dev/ichwd/ichwd.h
 
 Modified: head/sys/dev/ichwd/ichwd.c
 ==============================================================================
 --- head/sys/dev/ichwd/ichwd.c	Fri Jan 22 15:12:01 2010	(r202811)
 +++ head/sys/dev/ichwd/ichwd.c	Fri Jan 22 16:05:10 2010	(r202812)
 @@ -109,6 +109,7 @@ static struct ichwd_device ichwd_devices
  	{ DEVICEID_ICH10D,   "Intel ICH10D watchdog timer",	10 },
  	{ DEVICEID_ICH10DO,  "Intel ICH10DO watchdog timer",	10 },
  	{ DEVICEID_ICH10R,   "Intel ICH10R watchdog timer",	10 },
 +	{ DEVICEID_H55,      "Intel H55 watchdog timer",	10 },
  	{ 0, NULL, 0 },
  };
  
 
 Modified: head/sys/dev/ichwd/ichwd.h
 ==============================================================================
 --- head/sys/dev/ichwd/ichwd.h	Fri Jan 22 15:12:01 2010	(r202811)
 +++ head/sys/dev/ichwd/ichwd.h	Fri Jan 22 16:05:10 2010	(r202812)
 @@ -99,6 +99,7 @@ struct ichwd_softc {
  #define DEVICEID_ICH10D		0x3a1a
  #define DEVICEID_ICH10DO	0x3a14
  #define DEVICEID_ICH10R		0x3a16
 +#define DEVICEID_H55		0x3b06
  
  /* ICH LPC Interface Bridge Registers (ICH5 and older) */
  #define ICH_GEN_STA		0xd4
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/143068: commit references a PR
Date: Tue, 23 Feb 2010 01:00:25 +0000 (UTC)

 Author: emaste
 Date: Tue Feb 23 01:00:15 2010
 New Revision: 204234
 URL: http://svn.freebsd.org/changeset/base/204234
 
 Log:
   MFC r202812:
   
     Add H55 ID from Mike Tancsa, with minor rewording from avg@.
   
   PR:		kern/143068
   Submitted by:	Mike Tancsa (Sentex)
 
 Modified:
   stable/8/sys/dev/ichwd/ichwd.c
   stable/8/sys/dev/ichwd/ichwd.h
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
   stable/8/sys/netinet/   (props changed)
 
 Modified: stable/8/sys/dev/ichwd/ichwd.c
 ==============================================================================
 --- stable/8/sys/dev/ichwd/ichwd.c	Tue Feb 23 00:41:40 2010	(r204233)
 +++ stable/8/sys/dev/ichwd/ichwd.c	Tue Feb 23 01:00:15 2010	(r204234)
 @@ -109,6 +109,7 @@ static struct ichwd_device ichwd_devices
  	{ DEVICEID_ICH10D,   "Intel ICH10D watchdog timer",	10 },
  	{ DEVICEID_ICH10DO,  "Intel ICH10DO watchdog timer",	10 },
  	{ DEVICEID_ICH10R,   "Intel ICH10R watchdog timer",	10 },
 +	{ DEVICEID_H55,      "Intel H55 watchdog timer",	10 },
  	{ 0, NULL, 0 },
  };
  
 
 Modified: stable/8/sys/dev/ichwd/ichwd.h
 ==============================================================================
 --- stable/8/sys/dev/ichwd/ichwd.h	Tue Feb 23 00:41:40 2010	(r204233)
 +++ stable/8/sys/dev/ichwd/ichwd.h	Tue Feb 23 01:00:15 2010	(r204234)
 @@ -99,6 +99,7 @@ struct ichwd_softc {
  #define DEVICEID_ICH10D		0x3a1a
  #define DEVICEID_ICH10DO	0x3a14
  #define DEVICEID_ICH10R		0x3a16
 +#define DEVICEID_H55		0x3b06
  
  /* ICH LPC Interface Bridge Registers (ICH5 and older) */
  #define ICH_GEN_STA		0xd4
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: emaste 
State-Changed-When: Tue Feb 23 01:24:22 UTC 2010 
State-Changed-Why:  
MFC'd to 8 and 7 now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143068 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/143068: commit references a PR
Date: Tue, 23 Feb 2010 01:24:10 +0000 (UTC)

 Author: emaste
 Date: Tue Feb 23 01:24:01 2010
 New Revision: 204240
 URL: http://svn.freebsd.org/changeset/base/204240
 
 Log:
   MFC r202812:
   
     Add H55 ID from Mike Tancsa, with minor rewording from avg@.
   
   PR:		kern/143068
   Submitted by:	Mike Tancsa (Sentex)
 
 Modified:
   stable/7/sys/dev/ichwd/ichwd.c
   stable/7/sys/dev/ichwd/ichwd.h
 Directory Properties:
   stable/7/sys/   (props changed)
   stable/7/sys/cddl/contrib/opensolaris/   (props changed)
   stable/7/sys/contrib/dev/acpica/   (props changed)
   stable/7/sys/contrib/pf/   (props changed)
 
 Modified: stable/7/sys/dev/ichwd/ichwd.c
 ==============================================================================
 --- stable/7/sys/dev/ichwd/ichwd.c	Tue Feb 23 01:08:03 2010	(r204239)
 +++ stable/7/sys/dev/ichwd/ichwd.c	Tue Feb 23 01:24:01 2010	(r204240)
 @@ -109,6 +109,7 @@ static struct ichwd_device ichwd_devices
  	{ DEVICEID_ICH10D,   "Intel ICH10D watchdog timer",	10 },
  	{ DEVICEID_ICH10DO,  "Intel ICH10DO watchdog timer",	10 },
  	{ DEVICEID_ICH10R,   "Intel ICH10R watchdog timer",	10 },
 +	{ DEVICEID_H55,      "Intel H55 watchdog timer",	10 },
  	{ 0, NULL, 0 },
  };
  
 
 Modified: stable/7/sys/dev/ichwd/ichwd.h
 ==============================================================================
 --- stable/7/sys/dev/ichwd/ichwd.h	Tue Feb 23 01:08:03 2010	(r204239)
 +++ stable/7/sys/dev/ichwd/ichwd.h	Tue Feb 23 01:24:01 2010	(r204240)
 @@ -99,6 +99,7 @@ struct ichwd_softc {
  #define DEVICEID_ICH10D		0x3a1a
  #define DEVICEID_ICH10DO	0x3a14
  #define DEVICEID_ICH10R		0x3a16
 +#define DEVICEID_H55		0x3b06
  
  /* ICH LPC Interface Bridge Registers (ICH5 and older) */
  #define ICH_GEN_STA		0xd4
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
