From nobody@FreeBSD.org  Wed Dec 30 18:37:53 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 617AA106568F
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Dec 2009 18:37:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 50D528FC27
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Dec 2009 18:37:53 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBUIbrGl028960
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Dec 2009 18:37:53 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nBUIbrbK028959;
	Wed, 30 Dec 2009 18:37:53 GMT
	(envelope-from nobody)
Message-Id: <200912301837.nBUIbrbK028959@www.freebsd.org>
Date: Wed, 30 Dec 2009 18:37:53 GMT
From: Przemyslaw Laczynski <torindel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: gpart fails to correctly set partition type for GPT
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         142174
>Category:       kern
>Synopsis:       [geom] [patch] gpart(8) fails to correctly set partition type for GPT
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-geom
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 30 18:40:01 UTC 2009
>Closed-Date:    Sat Jan 02 01:03:38 UTC 2010
>Last-Modified:  Mon May 31 20:20:04 UTC 2010
>Originator:     Przemyslaw Laczynski
>Release:        9.0-CURRENT@20091229
>Organization:
>Environment:
FreeBSD localhost 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Wed Dec 30 14:15:23 UTC 2009     root@:/usr/src/sys/amd64/compile/GENERIC  amd64
>Description:
gpart fails to correctly create/modify GPT entry partition types and
sets it to "!00000000-0000-0000-0000-000000000000" or leaves it unchanged.
Full problem log bellow.

>How-To-Repeat:
localhost# gpart create -s GPT ad4 
ad4 created 
localhost# gpart add -t freebsd-ufs ad4 
ad4p1 added
localhost# gpart show ad4
=>      34  15038397  ad4  GPT  (7.2G)
        34  15038397    1  !00000000-0000-0000-0000-000000000000  (7.2G)
>Fix:
Apply patch

Patch attached with submission follows:

--- /usr/src/sys/geom/part/g_part_gpt.c	2009-12-30 18:27:25.000000000 +0000
+++ /usr/src/sys/geom/part/g_part_gpt.c	2009-12-30 19:10:50.000000000 +0000
@@ -375,7 +375,7 @@ gpt_parse_type(const char *type, struct uuid *uuid)
 	for (uap = &gpt_uuid_alias_match[0]; uap->uuid; uap++) {
 		alias = g_part_alias_name(uap->alias);
 		if (!strcasecmp(type, alias)) {
-			uuid = uap->uuid;
+			*uuid = *uap->uuid;
 			return (0);
 		}
 	}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Dec 31 16:53:38 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142174 
State-Changed-From-To: open->closed 
State-Changed-By: marcel 
State-Changed-When: Sat Jan 2 01:00:43 UTC 2010 
State-Changed-Why:  
Committed. Thanks for supplying a fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142174 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/142174: commit references a PR
Date: Sat,  2 Jan 2010 01:03:11 +0000 (UTC)

 Author: marcel
 Date: Sat Jan  2 01:02:59 2010
 New Revision: 201374
 URL: http://svn.freebsd.org/changeset/base/201374
 
 Log:
   Properly return the UUID represented by the alias.
   
   PR:		142174
   Submitted by:	Przemyslaw Laczynski <torindel@gmail.com>
   Pointy hat to:	rpaulo
 
 Modified:
   head/sys/geom/part/g_part_gpt.c
 
 Modified: head/sys/geom/part/g_part_gpt.c
 ==============================================================================
 --- head/sys/geom/part/g_part_gpt.c	Sat Jan  2 00:37:00 2010	(r201373)
 +++ head/sys/geom/part/g_part_gpt.c	Sat Jan  2 01:02:59 2010	(r201374)
 @@ -375,7 +375,7 @@ gpt_parse_type(const char *type, struct 
  	for (uap = &gpt_uuid_alias_match[0]; uap->uuid; uap++) {
  		alias = g_part_alias_name(uap->alias);
  		if (!strcasecmp(type, alias)) {
 -			uuid = uap->uuid;
 +			*uuid = *uap->uuid;
  			return (0);
  		}
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/142174: commit references a PR
Date: Mon, 31 May 2010 20:18:38 +0000 (UTC)

 Author: avg
 Date: Mon May 31 20:17:37 2010
 New Revision: 208673
 URL: http://svn.freebsd.org/changeset/base/208673
 
 Log:
   MFC r201374: g_part_gpt: Properly return the UUID represented by the alias
   
   PR:		kern/142174
   Approved by:	re (kib)
   Approved by:	marcel
 
 Modified:
   stable/8/sys/geom/part/g_part_gpt.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
   stable/8/sys/geom/sched/   (props changed)
 
 Modified: stable/8/sys/geom/part/g_part_gpt.c
 ==============================================================================
 --- stable/8/sys/geom/part/g_part_gpt.c	Mon May 31 09:10:39 2010	(r208672)
 +++ stable/8/sys/geom/part/g_part_gpt.c	Mon May 31 20:17:37 2010	(r208673)
 @@ -354,7 +354,7 @@ gpt_parse_type(const char *type, struct 
  	for (uap = &gpt_uuid_alias_match[0]; uap->uuid; uap++) {
  		alias = g_part_alias_name(uap->alias);
  		if (!strcasecmp(type, alias)) {
 -			uuid = uap->uuid;
 +			*uuid = *uap->uuid;
  			return (0);
  		}
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
