From nobody@FreeBSD.org  Sun Dec 27 10:21:58 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CF5261065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Dec 2009 10:21:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id BEF7C8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Dec 2009 10:21:58 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBRALw3q091628
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Dec 2009 10:21:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nBRALwWq091627;
	Sun, 27 Dec 2009 10:21:58 GMT
	(envelope-from nobody)
Message-Id: <200912271021.nBRALwWq091627@www.freebsd.org>
Date: Sun, 27 Dec 2009 10:21:58 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Missing parenthesis in sys/netinet/sctp_pcb.c .
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         142066
>Category:       kern
>Synopsis:       [patch] [sctp] Missing parenthesis in sys/netinet/sctp_pcb.c .
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 27 10:30:03 UTC 2009
>Closed-Date:    Sun Feb 28 18:25:45 UTC 2010
>Last-Modified:  Sun Feb 28 18:25:45 UTC 2010
>Originator:     Henning Petersen
>Release:        Freebsd-current
>Organization:
>Environment:
>Description:
Missplaced parenthesis found with cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.94 sctp_pcb.c
--- sys/netinet/sctp_pcb.c	17 Nov 2009 20:56:14 -0000	1.94
+++ sys/netinet/sctp_pcb.c	27 Dec 2009 10:11:48 -0000
@@ -6385,7 +6385,7 @@
 	}
 skip_vtag_check:
 
-	chain = &SCTP_BASE_INFO(vtag_timewait[(tag % SCTP_STACK_VTAG_HASH_SIZE))];
+	chain = &SCTP_BASE_INFO(vtag_timewait)[(tag % SCTP_STACK_VTAG_HASH_SIZE)];
 	/* Now what about timed wait ? */
 	if (!LIST_EMPTY(chain)) {
 		/*


Patch attached with submission follows:

Index: sys/netinet/sctp_pcb.c
===================================================================
RCS file: /usr/ncvs/src/sys/netinet/sctp_pcb.c,v
retrieving revision 1.94
diff -u -r1.94 sctp_pcb.c
--- sys/netinet/sctp_pcb.c	17 Nov 2009 20:56:14 -0000	1.94
+++ sys/netinet/sctp_pcb.c	27 Dec 2009 10:11:48 -0000
@@ -6385,7 +6385,7 @@
 	}
 skip_vtag_check:
 
-	chain = &SCTP_BASE_INFO(vtag_timewait[(tag % SCTP_STACK_VTAG_HASH_SIZE))];
+	chain = &SCTP_BASE_INFO(vtag_timewait)[(tag % SCTP_STACK_VTAG_HASH_SIZE)];
 	/* Now what about timed wait ? */
 	if (!LIST_EMPTY(chain)) {
 		/*


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Sun Dec 27 12:57:08 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142066 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/142066: commit references a PR
Date: Mon,  4 Jan 2010 18:25:52 +0000 (UTC)

 Author: tuexen
 Date: Mon Jan  4 18:25:38 2010
 New Revision: 201523
 URL: http://svn.freebsd.org/changeset/base/201523
 
 Log:
   Correct usage of parenthesis.
   
   PR:	kern/142066
   Approved by: rrs (mentor)
   Obtained from: Henning Petersen, Bruce Cran.
   MFC after: 2 weeks
 
 Modified:
   head/sys/netinet/sctp_pcb.c
 
 Modified: head/sys/netinet/sctp_pcb.c
 ==============================================================================
 --- head/sys/netinet/sctp_pcb.c	Mon Jan  4 18:21:27 2010	(r201522)
 +++ head/sys/netinet/sctp_pcb.c	Mon Jan  4 18:25:38 2010	(r201523)
 @@ -5528,7 +5528,7 @@ sctp_pcb_init()
  
  	/* Init the TIMEWAIT list */
  	for (i = 0; i < SCTP_STACK_VTAG_HASH_SIZE; i++) {
 -		LIST_INIT(&SCTP_BASE_INFO(vtag_timewait[i]));
 +		LIST_INIT(&SCTP_BASE_INFO(vtag_timewait)[i]);
  	}
  
  #if defined(SCTP_USE_THREAD_BASED_ITERATOR)
 @@ -6385,7 +6385,7 @@ sctp_is_vtag_good(struct sctp_inpcb *inp
  	}
  skip_vtag_check:
  
 -	chain = &SCTP_BASE_INFO(vtag_timewait[(tag % SCTP_STACK_VTAG_HASH_SIZE))];
 +	chain = &SCTP_BASE_INFO(vtag_timewait)[(tag % SCTP_STACK_VTAG_HASH_SIZE)];
  	/* Now what about timed wait ? */
  	if (!LIST_EMPTY(chain)) {
  		/*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched  
State-Changed-By: brucec 
State-Changed-When: Mon Jan 4 19:13:06 UTC 2010 
State-Changed-Why:  
Fixed in r201523. 


Responsible-Changed-From-To: freebsd-net->brucec  
Responsible-Changed-By: brucec 
Responsible-Changed-When: Mon Jan 4 19:13:06 UTC 2010 
Responsible-Changed-Why:  
Track. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142066 
State-Changed-From-To: patched->closed  
State-Changed-By: brucec 
State-Changed-When: Sun Feb 28 18:25:17 UTC 2010 
State-Changed-Why:  
Patch has been committed to stable/7 and stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142066 
>Unformatted:
