From nobody@FreeBSD.org  Fri Dec 11 16:58:26 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 396711065679
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Dec 2009 16:58:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 2958D8FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Dec 2009 16:58:26 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBBGwPfX019354
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 11 Dec 2009 16:58:25 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nBBGwPnR019353;
	Fri, 11 Dec 2009 16:58:25 GMT
	(envelope-from nobody)
Message-Id: <200912111658.nBBGwPnR019353@www.freebsd.org>
Date: Fri, 11 Dec 2009 16:58:25 GMT
From: Paul <onemda@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ndis: broken scan
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         141376
>Category:       kern
>Synopsis:       [ndis] [patch] fix broken scan by passing ies and ies_len pointer to net80211
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-net
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 11 17:00:11 UTC 2009
>Closed-Date:    Mon Dec 14 18:44:09 UTC 2009
>Last-Modified:  Sat Dec 26 18:30:02 UTC 2009
>Originator:     Paul
>Release:        
>Organization:
>Environment:
FreeBSD dhcppc0 9.0-CURRENT FreeBSD 9.0-CURRENT #3 r200402: Fri Dec 11 10:27:58 UTC 2009     r@dhcppc0:/usr/obj/usr/src/sys/kernel  i386
>Description:
Scan routine from if_ndis.c does not pass ies to net80211 causing that
RSN ie can not be detected - so no authentication with such AP can happen.
>How-To-Repeat:
# ifconfig wlanY create wlandev ndisX
# ifconfig wlanY list scan
# ifconfig -v wlanY list scan
>Fix:
Pass ies and ies_len pointer to net80211

Patch attached with submission follows:

--- /sys/dev/if_ndis/if_ndis.c	2009-12-02 19:09:58.000000000 +0000
+++ if_ndis.c	2009-12-02 20:40:15.000000000 +0000
@@ -3299,24 +3299,11 @@
 			efrm = frm + wb->nwbx_ielen;
 			if (efrm - frm < 12)
 				goto done;
-			sp.tstamp = frm;
-			frm += 8;
-			sp.bintval = le16toh(*(uint16_t *)frm);
-			frm += 2;
-			sp.capinfo = le16toh(*(uint16_t *)frm);
-			frm += 2;
-
-			/* Grab variable length ies */
-			while (efrm - frm > 1) {
-				if (efrm - frm < frm[1] + 2)
-					break;
-				switch (*frm) {
-				case IEEE80211_ELEMID_RSN:
-					sp.rsn = frm;
-					break;
-				}
-				frm += frm[1] + 2;
-			}
+			sp.tstamp = frm;			frm += 8;
+			sp.bintval = le16toh(*(uint16_t *)frm);	frm += 2;
+			sp.capinfo = le16toh(*(uint16_t *)frm);	frm += 2;
+			sp.ies = frm;
+			sp.ies_len = efrm - frm;
 		}
 done:
 		DPRINTF(("scan: bssid %s chan %dMHz (%d/%d) rssi %d\n",


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Dec 11 19:48:19 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141376 
State-Changed-From-To: open->closed 
State-Changed-By: rpaulo 
State-Changed-When: Mon Dec 14 18:43:44 UTC 2009 
State-Changed-Why:  
fixed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141376 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/141376: commit references a PR
Date: Mon, 14 Dec 2009 18:43:47 +0000 (UTC)

 Author: rpaulo
 Date: Mon Dec 14 18:43:27 2009
 New Revision: 200524
 URL: http://svn.freebsd.org/changeset/base/200524
 
 Log:
   Pass all IEs to net80211.
   
   PR:		141376
   Submitted by:	Paul <onemda at gmail.com>
   MFC after:	1 week
 
 Modified:
   head/sys/dev/if_ndis/if_ndis.c
 
 Modified: head/sys/dev/if_ndis/if_ndis.c
 ==============================================================================
 --- head/sys/dev/if_ndis/if_ndis.c	Mon Dec 14 18:43:18 2009	(r200523)
 +++ head/sys/dev/if_ndis/if_ndis.c	Mon Dec 14 18:43:27 2009	(r200524)
 @@ -3299,24 +3299,11 @@ ndis_scan_results(struct ndis_softc *sc)
  			efrm = frm + wb->nwbx_ielen;
  			if (efrm - frm < 12)
  				goto done;
 -			sp.tstamp = frm;
 -			frm += 8;
 -			sp.bintval = le16toh(*(uint16_t *)frm);
 -			frm += 2;
 -			sp.capinfo = le16toh(*(uint16_t *)frm);
 -			frm += 2;
 -
 -			/* Grab variable length ies */
 -			while (efrm - frm > 1) {
 -				if (efrm - frm < frm[1] + 2)
 -					break;
 -				switch (*frm) {
 -				case IEEE80211_ELEMID_RSN:
 -					sp.rsn = frm;
 -					break;
 -				}
 -				frm += frm[1] + 2;
 -			}
 +			sp.tstamp = frm;			frm += 8;
 +			sp.bintval = le16toh(*(uint16_t *)frm);	frm += 2;
 +			sp.capinfo = le16toh(*(uint16_t *)frm);	frm += 2;
 +			sp.ies = frm;
 +			sp.ies_len = efrm - frm;
  		}
  done:
  		DPRINTF(("scan: bssid %s chan %dMHz (%d/%d) rssi %d\n",
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/141376: commit references a PR
Date: Sat, 26 Dec 2009 18:26:07 +0000 (UTC)

 Author: rpaulo
 Date: Sat Dec 26 18:25:52 2009
 New Revision: 201026
 URL: http://svn.freebsd.org/changeset/base/201026
 
 Log:
   MFC r200524:
    Pass all IEs to net80211.
   
   PR:		141376
   Submitted by:	Paul <onemda at gmail.com>
 
 Modified:
   stable/8/sys/dev/if_ndis/if_ndis.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/dev/if_ndis/if_ndis.c
 ==============================================================================
 --- stable/8/sys/dev/if_ndis/if_ndis.c	Sat Dec 26 18:23:21 2009	(r201025)
 +++ stable/8/sys/dev/if_ndis/if_ndis.c	Sat Dec 26 18:25:52 2009	(r201026)
 @@ -3355,24 +3355,11 @@ ndis_scan_results(struct ndis_softc *sc)
  			efrm = frm + wb->nwbx_ielen;
  			if (efrm - frm < 12)
  				goto done;
 -			sp.tstamp = frm;
 -			frm += 8;
 -			sp.bintval = le16toh(*(uint16_t *)frm);
 -			frm += 2;
 -			sp.capinfo = le16toh(*(uint16_t *)frm);
 -			frm += 2;
 -
 -			/* Grab variable length ies */
 -			while (efrm - frm > 1) {
 -				if (efrm - frm < frm[1] + 2)
 -					break;
 -				switch (*frm) {
 -				case IEEE80211_ELEMID_RSN:
 -					sp.rsn = frm;
 -					break;
 -				}
 -				frm += frm[1] + 2;
 -			}
 +			sp.tstamp = frm;			frm += 8;
 +			sp.bintval = le16toh(*(uint16_t *)frm);	frm += 2;
 +			sp.capinfo = le16toh(*(uint16_t *)frm);	frm += 2;
 +			sp.ies = frm;
 +			sp.ies_len = efrm - frm;
  		}
  done:
  		DPRINTF(("scan: bssid %s chan %dMHz (%d/%d) rssi %d\n",
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
