From nobody@FreeBSD.org  Sun Nov  8 12:19:32 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AD8F11065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  8 Nov 2009 12:19:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 9CD5A8FC21
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  8 Nov 2009 12:19:32 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nA8CJWJK014324
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 8 Nov 2009 12:19:32 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nA8CJWgH014323;
	Sun, 8 Nov 2009 12:19:32 GMT
	(envelope-from nobody)
Message-Id: <200911081219.nA8CJWgH014323@www.freebsd.org>
Date: Sun, 8 Nov 2009 12:19:32 GMT
From: soulcatcher <soulcatcher13@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: segfault in fmtmsg(3) with MM_NULLACT
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         140386
>Category:       kern
>Synopsis:       segfault in fmtmsg(3) with MM_NULLACT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 08 12:20:04 UTC 2009
>Closed-Date:    Mon Nov 16 09:32:45 CET 2009
>Last-Modified:  Mon Nov 16 09:32:45 CET 2009
>Originator:     soulcatcher
>Release:        FreeBSD 7.2-STABLE
>Organization:
>Environment:
FreeBSD xxx.org 7.2-STABLE FreeBSD 7.2-STABLE #4: Sun Oct  4 19:58:35 UTC 2009     xxx.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
obvious bug in /usr/src/lib/libc/gen/fmtmsg.c

>How-To-Repeat:
#include <fmtmsg.h>

int main(int argc, char * argv[])
{
    fmtmsg(MM_UTIL | MM_PRINT, "BSD:ls", MM_ERROR,
            "illegal option &#8208;&#8208; z", MM_NULLACT, "BSD:ls:001");
    return 0;
}

gcc main.c
./a.out dumps core

>Fix:


Patch attached with submission follows:

--- fmtmsg.c.bak	2009-11-08 15:01:29.000000000 +0300
+++ fmtmsg.c	2009-11-08 15:09:08.000000000 +0300
@@ -128,7 +128,7 @@
 		size += strlen(sevname);
 	if (text != MM_NULLTXT)
 		size += strlen(text);
-	if (text != MM_NULLACT)
+	if (act != MM_NULLACT)
 		size += strlen(act);
 	if (tag != MM_NULLTAG)
 		size += strlen(tag);


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Sun Nov 8 15:03:05 CET 2009 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Sun Nov 8 15:03:05 CET 2009 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140386 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/140386: commit references a PR
Date: Sun,  8 Nov 2009 14:03:08 +0000 (UTC)

 Author: brueffer
 Date: Sun Nov  8 14:02:54 2009
 New Revision: 199046
 URL: http://svn.freebsd.org/changeset/base/199046
 
 Log:
   Fix a copy+paste error by checking the correct variable against MM_NULLACT.
   
   PR:		140386
   Submitted by:	soulcatcher <soulcatcher13@gmail.com
   MFC after:	1 week
 
 Modified:
   head/lib/libc/gen/fmtmsg.c
 
 Modified: head/lib/libc/gen/fmtmsg.c
 ==============================================================================
 --- head/lib/libc/gen/fmtmsg.c	Sun Nov  8 12:08:42 2009	(r199045)
 +++ head/lib/libc/gen/fmtmsg.c	Sun Nov  8 14:02:54 2009	(r199046)
 @@ -128,7 +128,7 @@ printfmt(char *msgverb, long class, cons
  		size += strlen(sevname);
  	if (text != MM_NULLTXT)
  		size += strlen(text);
 -	if (text != MM_NULLACT)
 +	if (act != MM_NULLACT)
  		size += strlen(act);
  	if (tag != MM_NULLTAG)
  		size += strlen(tag);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Mon Nov 16 09:32:28 CET 2009 
State-Changed-Why:  
MFCs done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140386 
>Unformatted:
