From nobody@FreeBSD.org  Mon Oct 19 08:56:41 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5AEB3106568F
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Oct 2009 08:56:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 4ADBE8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Oct 2009 08:56:41 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n9J8ueLw071207
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Oct 2009 08:56:40 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n9J8ueRY071206;
	Mon, 19 Oct 2009 08:56:40 GMT
	(envelope-from nobody)
Message-Id: <200910190856.n9J8ueRY071206@www.freebsd.org>
Date: Mon, 19 Oct 2009 08:56:40 GMT
From: Xavier Heiny <xavier.heiny@netasq.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] fetch/libfetch : NO_PROXY=localhost seems to not work properly.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         139751
>Category:       kern
>Synopsis:       [libfetch] [patch] NO_PROXY=localhost seems to not work properly.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 19 09:00:13 UTC 2009
>Closed-Date:    Wed Oct 21 18:33:52 UTC 2009
>Last-Modified:  Tue Dec  1 23:30:04 UTC 2009
>Originator:     Xavier Heiny
>Release:        7.0
>Organization:
Netasq
>Environment:
>Description:
fetch/libfetch : NO_PROXY=localhost seems to not work properly.

To make it work, setting NO_PROXY=ocalhost instead of NO_PROXY=localhost is mandatory.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- lib/libfetch/common.c	Wed Feb 16 13:46:46 2005
+++ lib/libfetch/common.c	Tue Sep 17 16:37:23 2009
@@ -772,7 +772,7 @@
 				break;
 
 		d_len = q - p;
-		if (d_len > 0 && h_len > d_len &&
+		if (d_len > 0 && h_len >= d_len &&
 		    strncasecmp(host + h_len - d_len,
 			p, d_len) == 0) {
 			/* domain name matches */


>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/139751: commit references a PR
Date: Wed, 21 Oct 2009 18:29:37 +0000 (UTC)

 Author: fabient
 Date: Wed Oct 21 18:29:26 2009
 New Revision: 198339
 URL: http://svn.freebsd.org/changeset/base/198339
 
 Log:
   PR: 139751
   Approved by: des
   Obtained from: Xavier Heiny <xavier.heiny@netasq.com>
   MFC after: 3 weeks
 
 Modified:
   head/lib/libfetch/common.c
 
 Modified: head/lib/libfetch/common.c
 ==============================================================================
 --- head/lib/libfetch/common.c	Wed Oct 21 18:09:48 2009	(r198338)
 +++ head/lib/libfetch/common.c	Wed Oct 21 18:29:26 2009	(r198339)
 @@ -772,7 +772,7 @@ fetch_no_proxy_match(const char *host)
  				break;
  
  		d_len = q - p;
 -		if (d_len > 0 && h_len > d_len &&
 +		if (d_len > 0 && h_len >= d_len &&
  		    strncasecmp(host + h_len - d_len,
  			p, d_len) == 0) {
  			/* domain name matches */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: fabient 
State-Changed-When: Wed Oct 21 18:30:19 UTC 2009 
State-Changed-Why:  
Fix committed under r198339  

http://www.freebsd.org/cgi/query-pr.cgi?pr=139751 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/139751: commit references a PR
Date: Tue,  1 Dec 2009 23:24:11 +0000 (UTC)

 Author: fabient
 Date: Tue Dec  1 23:23:52 2009
 New Revision: 200012
 URL: http://svn.freebsd.org/changeset/base/200012
 
 Log:
   MFC 198339:
   Fix the NO_PROXY handling.
   
   PR: 139751
 
 Modified:
   stable/8/lib/libfetch/common.c
 Directory Properties:
   stable/8/lib/libfetch/   (props changed)
 
 Modified: stable/8/lib/libfetch/common.c
 ==============================================================================
 --- stable/8/lib/libfetch/common.c	Tue Dec  1 23:07:38 2009	(r200011)
 +++ stable/8/lib/libfetch/common.c	Tue Dec  1 23:23:52 2009	(r200012)
 @@ -772,7 +772,7 @@ fetch_no_proxy_match(const char *host)
  				break;
  
  		d_len = q - p;
 -		if (d_len > 0 && h_len > d_len &&
 +		if (d_len > 0 && h_len >= d_len &&
  		    strncasecmp(host + h_len - d_len,
  			p, d_len) == 0) {
  			/* domain name matches */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/139751: commit references a PR
Date: Tue,  1 Dec 2009 23:24:53 +0000 (UTC)

 Author: fabient
 Date: Tue Dec  1 23:24:42 2009
 New Revision: 200013
 URL: http://svn.freebsd.org/changeset/base/200013
 
 Log:
   MFC 198339:
   Fix the NO_PROXY handling.
   
   PR: 139751
 
 Modified:
   stable/7/lib/libfetch/common.c
 Directory Properties:
   stable/7/lib/libfetch/   (props changed)
 
 Modified: stable/7/lib/libfetch/common.c
 ==============================================================================
 --- stable/7/lib/libfetch/common.c	Tue Dec  1 23:23:52 2009	(r200012)
 +++ stable/7/lib/libfetch/common.c	Tue Dec  1 23:24:42 2009	(r200013)
 @@ -772,7 +772,7 @@ fetch_no_proxy_match(const char *host)
  				break;
  
  		d_len = q - p;
 -		if (d_len > 0 && h_len > d_len &&
 +		if (d_len > 0 && h_len >= d_len &&
  		    strncasecmp(host + h_len - d_len,
  			p, d_len) == 0) {
  			/* domain name matches */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
