From nobody@FreeBSD.org  Sun Aug 30 15:35:17 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CE5E2106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 30 Aug 2009 15:35:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A3DB38FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 30 Aug 2009 15:35:17 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7UFZH3t093590
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 30 Aug 2009 15:35:17 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n7UFZHNQ093589;
	Sun, 30 Aug 2009 15:35:17 GMT
	(envelope-from nobody)
Message-Id: <200908301535.n7UFZHNQ093589@www.freebsd.org>
Date: Sun, 30 Aug 2009 15:35:17 GMT
From: "System V. Unix" <sysv@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: UFS_EXTATTR static int prototyping error ufs_extattr_autostart_locked
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         138350
>Category:       kern
>Synopsis:       [ufs] [patch] UFS_EXTATTR static int prototyping error ufs_extattr_autostart_locked
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-fs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 30 15:40:02 UTC 2009
>Closed-Date:    Mon Aug 31 11:55:23 UTC 2009
>Last-Modified:  Mon Aug 31 12:00:14 UTC 2009
>Originator:     System V. Unix
>Release:        7.2-RELEASE
>Organization:
>Environment:
>Description:
Using additional kernel option UFS_EXTATTR in 7.2-RELEASE causes a kernel build failure 

cc -c -O2 -frename-registers -pipe -fno-strict-aliasing  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I../../.. -I../../../contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror  ../../../ufs/ufs/ufs_extattr.c
cc1: warnings being treated as errors
./../../ufs/ufs/ufs_extattr.c:97: warning: 'ufs_extattr_autostart_locked' declared 'static' but never defined
*** Error code 1


This is because the routine is getting optionally defined around line 215 with a #ifdef UFS_EXTATTR_AUTOSTART, but the prototype is missing the analoguous #ifdef, and the compiler seems to be picky.

>How-To-Repeat:
Add option UFS_EXTATTR to the 7.2-RELEASE kernel and do a build. The problem was NOT seen in 7.1-RELEASE.
>Fix:
Trivial solution. 

Simply the add the pre-process directives around the prototyping of the 
subroutine at the head of the file. The routine lower down in ufs_extattr.c already has the #ifdefs around it.

#ifdef UFS_EXTATTR_AUTOSTART
#endif /* !UFS_EXTATTR_AUTOSTART */

That way BOTH the prototype and the subroutine have that #ifdef.

e.g.
-------------
diff -u usr/src/sys/ufs/ufs/ufs_extattr.c.orig usr/src/sys/ufs/ufs/ufs_extattr.c
--- usr/src/sys/ufs/ufs/ufs_extattr.c.orig	2009-08-30 16:57:35.000000000 -0600
+++ usr/src/sys/ufs/ufs/ufs_extattr.c	2009-08-30 17:26:46.000000000 -0600
@@ -93,8 +93,10 @@
 		    struct thread *td);
 static int	ufs_extattr_rm(struct vnode *vp, int attrnamespace,
 		    const char *name, struct ucred *cred, struct thread *td);
+#ifdef UFS_EXTATTR_AUTOSTART
 static int	ufs_extattr_autostart_locked(struct mount *mp,
 		    struct thread *td);
+#endif /* !UFS_EXTATTR_AUTOSTART */
 static int	ufs_extattr_start_locked(struct ufsmount *ump,
 		    struct thread *td);

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Aug 30 16:44:02 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138350 
State-Changed-From-To: open->closed 
State-Changed-By: jhb 
State-Changed-When: Mon Aug 31 11:54:27 UTC 2009 
State-Changed-Why:  
Fix committed.  It was fixed earlier in 8.0 as a small part of another 
change. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138350 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/138350: commit references a PR
Date: Mon, 31 Aug 2009 11:54:25 +0000 (UTC)

 Author: jhb
 Date: Mon Aug 31 11:54:13 2009
 New Revision: 196693
 URL: http://svn.freebsd.org/changeset/base/196693
 
 Log:
   MFC a part of 191990:
   Fix compile of UFS_EXTATTR without UFS_EXTATTR_AUTOSTART.
   
   PR:		kern/138350
 
 Modified:
   stable/7/sys/ufs/ufs/ufs_extattr.c
 
 Modified: stable/7/sys/ufs/ufs/ufs_extattr.c
 ==============================================================================
 --- stable/7/sys/ufs/ufs/ufs_extattr.c	Mon Aug 31 10:20:52 2009	(r196692)
 +++ stable/7/sys/ufs/ufs/ufs_extattr.c	Mon Aug 31 11:54:13 2009	(r196693)
 @@ -93,8 +93,10 @@ static int	ufs_extattr_set(struct vnode 
  		    struct thread *td);
  static int	ufs_extattr_rm(struct vnode *vp, int attrnamespace,
  		    const char *name, struct ucred *cred, struct thread *td);
 +#ifdef UFS_EXTATTR_AUTOSTART
  static int	ufs_extattr_autostart_locked(struct mount *mp,
  		    struct thread *td);
 +#endif
  static int	ufs_extattr_start_locked(struct ufsmount *ump,
  		    struct thread *td);
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
