From nobody@FreeBSD.org  Mon Aug 24 10:17:01 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0DA7B106568E
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Aug 2009 10:17:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id BA14B8FC25
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Aug 2009 10:17:00 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7OAH0A8075060
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Aug 2009 10:17:00 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n7OAH0rk075056;
	Mon, 24 Aug 2009 10:17:00 GMT
	(envelope-from nobody)
Message-Id: <200908241017.n7OAH0rk075056@www.freebsd.org>
Date: Mon, 24 Aug 2009 10:17:00 GMT
From: Patroklos Argyroudis <argp@census-labs.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Resource leak in LibAliasRefreshModules() in file sys/netinet/libalias/alias.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         138130
>Category:       kern
>Synopsis:       [netinet] [patch] Resource leak in LibAliasRefreshModules() in file sys/netinet/libalias/alias.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 24 10:20:00 UTC 2009
>Closed-Date:    Wed Nov 04 14:32:51 CET 2009
>Last-Modified:  Wed Nov 04 14:32:51 CET 2009
>Originator:     Patroklos Argyroudis
>Release:        7.2
>Organization:
census, inc
>Environment:
FreeBSD julius.localdomain 7.2-RELEASE FreeBSD 7.2-RELEASE #25: Thu May  7 18:55:24 UTC 2009     root@julius.localdomain:/usr/obj/usr/src/sys/JULIUS  i386
>Description:
In function LibAliasRefreshModules() in file sys/netinet/libalias/alias.c
there is a resource leak of stream fd.  Although the stream is initialized
(line 1561), it is never closed.
>How-To-Repeat:
N/A 
>Fix:
1581 		}
1582 	}
1583    fclose(fd);
1584 	return (0);
1585 }

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Aug 24 10:35:19 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138130 
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Wed Oct 28 13:10:37 CET 2009 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-net->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Wed Oct 28 13:10:37 CET 2009 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138130 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/138130: commit references a PR
Date: Wed, 28 Oct 2009 12:10:42 +0000 (UTC)

 Author: brueffer
 Date: Wed Oct 28 12:10:29 2009
 New Revision: 198539
 URL: http://svn.freebsd.org/changeset/base/198539
 
 Log:
   Close a stream file descriptor leak.
   
   PR:		138130
   Submitted by:	Patroklos Argyroudis <argp@census-labs.com>
   MFC after:	1 week
 
 Modified:
   head/sys/netinet/libalias/alias.c
 
 Modified: head/sys/netinet/libalias/alias.c
 ==============================================================================
 --- head/sys/netinet/libalias/alias.c	Wed Oct 28 11:14:32 2009	(r198538)
 +++ head/sys/netinet/libalias/alias.c	Wed Oct 28 12:10:29 2009	(r198539)
 @@ -1669,6 +1669,7 @@ LibAliasRefreshModules(void)
  			LibAliasLoadModule(buf);
  		}
  	}
 +	fclose(fd);
  	return (0);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Wed Nov 4 14:32:36 CET 2009 
State-Changed-Why:  
MFCs done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138130 
>Unformatted:
