From nick@van-laarhoven.org  Mon Aug 24 07:06:28 2009
Return-Path: <nick@van-laarhoven.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7646B106568C
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Aug 2009 07:06:28 +0000 (UTC)
	(envelope-from nick@van-laarhoven.org)
Received: from CPSMTPM-EML110.kpnxchange.com (cpsmtpm-eml110.kpnxchange.com [195.121.3.14])
	by mx1.freebsd.org (Postfix) with ESMTP id 07E388FC25
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Aug 2009 07:06:27 +0000 (UTC)
Received: from uitsmijter.van-laarhoven.org ([81.207.207.222]) by CPSMTPM-EML110.kpnxchange.com with Microsoft SMTPSVC(7.0.6001.18000);
	 Mon, 24 Aug 2009 09:06:22 +0200
Received: from hind.van-laarhoven.org (HIND.van-laarhoven.org [10.66.0.147])
	by uitsmijter.van-laarhoven.org (8.14.3/8.14.3) with ESMTP id n7O711SJ065774
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Aug 2009 09:06:18 +0200 (CEST)
	(envelope-from nick@van-laarhoven.org)
Received: from nick by hind.van-laarhoven.org with local (masqmail
 0.2.21) id 1MfTTl-5rZ-00 for <FreeBSD-gnats-submit@freebsd.org>; Mon,
 24 Aug 2009 08:56:33 +0200
Message-Id: <1MfTTl-5rZ-00@hind.van-laarhoven.org>
Date: Mon, 24 Aug 2009 08:56:33 +0200
From: Nick Hibma <nick@van-laarhoven.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: bad style in kern_clock.c (confusing as well)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         138125
>Category:       kern
>Synopsis:       [kernel] [diff] bad style in kern_clock.c (confusing as well)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 24 07:10:01 UTC 2009
>Closed-Date:    Sat Oct 31 14:13:57 CET 2009
>Last-Modified:  Sat Oct 31 14:13:57 CET 2009
>Originator:     Nick Hibma
>Release:        FreeBSD 7.2-STABLE i386
>Organization:
AnyWi Technologies
>Environment:
System: FreeBSD hind.van-laarhoven.org 7.2-STABLE FreeBSD 7.2-STABLE #6 r196180:196225M: Mon Aug 17 14:28:06 CEST 2009 root@hind.van-laarhoven.org:/usr/obj/usr/src/sys/HIND i386


	
>Description:
	See diff below (bad use of curly braces, which creates confusing code. It also violates style(9).
>How-To-Repeat:
>Fix:
Index: kern_clock.c
===================================================================
--- kern_clock.c	(revision 196180)
+++ kern_clock.c	(working copy)
@@ -325,9 +325,9 @@
 	 */
 	mtx_lock_spin_flags(&callout_lock, MTX_QUIET);
 	ticks++;
-	if (!TAILQ_EMPTY(&callwheel[ticks & callwheelmask])) {
+	if (!TAILQ_EMPTY(&callwheel[ticks & callwheelmask]))
 		need_softclock = 1;
-	} else if (softticks + 1 == ticks)
+	else if (softticks + 1 == ticks)
 		++softticks;
 	mtx_unlock_spin_flags(&callout_lock, MTX_QUIET);
 
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: brueffer 
State-Changed-When: Sat Oct 31 14:11:31 CET 2009 
State-Changed-Why:  
Fixed in HEAD rev. 177859 18 month ago by removing the code 
as part of a larger change.  Nontheless, thank you for your 
submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138125 
>Unformatted:
