From nobody@FreeBSD.org  Fri Aug 14 09:02:36 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 82B3F106568D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Aug 2009 09:02:36 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0527A8FC51
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Aug 2009 09:02:36 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7E92ZwA052894
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Aug 2009 09:02:35 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n7E92Zm8052893;
	Fri, 14 Aug 2009 09:02:35 GMT
	(envelope-from nobody)
Message-Id: <200908140902.n7E92Zm8052893@www.freebsd.org>
Date: Fri, 14 Aug 2009 09:02:35 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Delete one ")"  in amr.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         137758
>Category:       kern
>Synopsis:       [amr] [patch] Delete one ")"  in amr.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 14 09:10:05 UTC 2009
>Closed-Date:    Wed Nov 04 13:44:38 CET 2009
>Last-Modified:  Wed Nov 04 13:44:38 CET 2009
>Originator:     Henning Petersen
>Release:        current-Freebsd
>Organization:
>Environment:
>Description:
Delete one ")"  in amr.c
>How-To-Repeat:

>Fix:
diff -u -r1.90 amr.c
--- sys/dev/amr/amr.c	2 Aug 2009 14:28:40 -0000	1.90
+++ sys/dev/amr/amr.c	14 Aug 2009 08:30:31 -0000
@@ -229,7 +229,7 @@
     }
 
 #ifdef AMR_BOARD_INIT
-    if ((AMR_IS_QUARTZ(sc) ? amr_quartz_init(sc) : amr_std_init(sc))))
+    if ((AMR_IS_QUARTZ(sc) ? amr_quartz_init(sc) : amr_std_init(sc)))
 	return(ENXIO);
 #endif


Patch attached with submission follows:

Index: sys/dev/amr/amr.c
===================================================================
RCS file: /usr/ncvs/src/sys/dev/amr/amr.c,v
retrieving revision 1.90
diff -u -r1.90 amr.c
--- sys/dev/amr/amr.c	2 Aug 2009 14:28:40 -0000	1.90
+++ sys/dev/amr/amr.c	14 Aug 2009 08:30:31 -0000
@@ -229,7 +229,7 @@
     }
 
 #ifdef AMR_BOARD_INIT
-    if ((AMR_IS_QUARTZ(sc) ? amr_quartz_init(sc) : amr_std_init(sc))))
+    if ((AMR_IS_QUARTZ(sc) ? amr_quartz_init(sc) : amr_std_init(sc)))
 	return(ENXIO);
 #endif
 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Wed Oct 28 16:23:08 CET 2009 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Wed Oct 28 16:23:08 CET 2009 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137758 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/137758: commit references a PR
Date: Wed, 28 Oct 2009 15:23:07 +0000 (UTC)

 Author: brueffer
 Date: Wed Oct 28 15:22:58 2009
 New Revision: 198546
 URL: http://svn.freebsd.org/changeset/base/198546
 
 Log:
   Remove spurious `)`
   
   PR:		137758
   Submitted by:	Henning Petersen <henning.petersen@t-online.de>
   MFC after:	1 week
 
 Modified:
   head/sys/dev/amr/amr.c
 
 Modified: head/sys/dev/amr/amr.c
 ==============================================================================
 --- head/sys/dev/amr/amr.c	Wed Oct 28 15:09:21 2009	(r198545)
 +++ head/sys/dev/amr/amr.c	Wed Oct 28 15:22:58 2009	(r198546)
 @@ -225,7 +225,7 @@ amr_attach(struct amr_softc *sc)
      }
  
  #ifdef AMR_BOARD_INIT
 -    if ((AMR_IS_QUARTZ(sc) ? amr_quartz_init(sc) : amr_std_init(sc))))
 +    if ((AMR_IS_QUARTZ(sc) ? amr_quartz_init(sc) : amr_std_init(sc)))
  	return(ENXIO);
  #endif
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Wed Nov 4 13:44:09 CET 2009 
State-Changed-Why:  
MFCs done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137758 
>Unformatted:
