From nobody@FreeBSD.org  Tue Aug  4 21:23:50 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 65288106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  4 Aug 2009 21:23:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 537698FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  4 Aug 2009 21:23:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n74LNn8N007256
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 4 Aug 2009 21:23:49 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n74LNnMM007253;
	Tue, 4 Aug 2009 21:23:49 GMT
	(envelope-from nobody)
Message-Id: <200908042123.n74LNnMM007253@www.freebsd.org>
Date: Tue, 4 Aug 2009 21:23:49 GMT
From: Bob Eager <rde@tavi.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Fix puc driver to support newer Timedia serial card (4027)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         137436
>Category:       kern
>Synopsis:       [puc] [patch] Fix puc driver to support newer Timedia serial card (4027)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 04 21:30:07 UTC 2009
>Closed-Date:    Fri Oct 28 15:45:46 UTC 2011
>Last-Modified:  Fri Oct 28 15:45:46 UTC 2011
>Originator:     Bob Eager
>Release:        7.2-STABLE
>Organization:
>Environment:
FreeBSD wolf.tavi.co.uk 7.2-STABLE FreeBSD 7.2-STABLE #0: Tue Aug  4 10:48:22 BST 2009     root@wolf.tavi.co.uk:/usr/obj/usr/src/sys/WOLF  i386

>Description:
The puc driver doesn't support one of the single port Timedia cards, the 4026. Actually, by chance it used to on 6.x, but the table changes in 7.x removed the 'chance'!

Attached is a short patch which adds the necessary table information. This has been tested on my system with one of these cards.

It's a common card (the two port version is already supported) so it's a useful fix.

>How-To-Repeat:
Not applicable.

>Fix:
Patch attached.

Patch attached with submission follows:

--- original/pucdata.c	2009-03-19 15:35:33.000000000 +0000
+++ pucdata.c	2009-08-04 21:17:11.000000000 +0100
@@ -1096,6 +1096,9 @@
 puc_config_timedia(struct puc_softc *sc, enum puc_cfg_cmd cmd, int port,
     intptr_t *res)
 {
+	static uint16_t sngl[] = {
+	    0x4027, 0
+	};
 	static uint16_t dual[] = {
 	    0x0002, 0x4036, 0x4037, 0x4038, 0x4078, 0x4079, 0x4085,
 	    0x4088, 0x4089, 0x5037, 0x5078, 0x5079, 0x5085, 0x6079, 
@@ -1117,6 +1120,7 @@
 		int ports;
 		uint16_t *ids;
 	} subdevs[] = {
+	    { 1, sngl },
 	    { 2, dual },
 	    { 4, quad },
 	    { 8, octa },


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sat Oct 15 21:39:55 UTC 2011 
Responsible-Changed-Why:  
Not my field, but I'll nag someone about these PRS 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137436 
State-Changed-From-To: open->feedback 
State-Changed-By: eadler 
State-Changed-When: Sun Oct 23 18:27:39 UTC 2011 
State-Changed-Why:  
uart should already have support for these cards 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137436 
State-Changed-From-To: feedback->closed 
State-Changed-By: eadler 
State-Changed-When: Fri Oct 28 15:45:45 UTC 2011 
State-Changed-Why:  
per my comment above 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137436 
>Unformatted:
