From nobody@FreeBSD.org  Sun Jul 19 09:26:03 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 93A98106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Jul 2009 09:26:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 827548FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Jul 2009 09:26:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n6J9Q3Vn004809
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 19 Jul 2009 09:26:03 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n6J9Q33L004808;
	Sun, 19 Jul 2009 09:26:03 GMT
	(envelope-from nobody)
Message-Id: <200907190926.n6J9Q33L004808@www.freebsd.org>
Date: Sun, 19 Jul 2009 09:26:03 GMT
From: Paul <onemda@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ndis regression
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         136895
>Category:       kern
>Synopsis:       [ndis] ndis regression [regression]
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    cokane
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 19 09:30:04 UTC 2009
>Closed-Date:    Tue Sep 22 12:46:43 UTC 2009
>Last-Modified:  Tue Sep 22 12:46:43 UTC 2009
>Originator:     Paul
>Release:        FreeBSD 8.0-BETA2
>Organization:
>Environment:
FreeBSD 8.0-BETA2 FreeBSD 8.0-BETA2 #5 r195750:195754: Sat Jul 18 17:00:16 UTC 2009     r@root:/usr/obj/usr/src/sys/kernel  i386
>Description:
regression introduced with r194432
>How-To-Repeat:
put ndis0 up before creating vap
>Fix:
--- /sys/dev/if_ndis/if_ndis.c  2009-06-28 09:15:54.000000000 +0000
+++ if_ndis.c   2009-07-19 09:22:44.000000000 +0000
@@ -2292,6 +2292,8 @@
        ifp = sc->ifp;
        ic = ifp->if_l2com;
        vap = TAILQ_FIRST(&ic->ic_vaps);
+       if (vap == NULL)
+               return;

        if (!NDIS_INITIALIZED(sc)) {
                DPRINTF(("%s: NDIS not initialized\n", __func__));

Patch attached with submission follows:

--- /sys/dev/if_ndis/if_ndis.c	2009-06-28 09:15:54.000000000 +0000
+++ if_ndis.c	2009-07-19 09:22:44.000000000 +0000
@@ -2292,6 +2292,8 @@
 	ifp = sc->ifp;
 	ic = ifp->if_l2com;
 	vap = TAILQ_FIRST(&ic->ic_vaps);
+	if (vap == NULL)
+		return;
 
 	if (!NDIS_INITIALIZED(sc)) {
 		DPRINTF(("%s: NDIS not initialized\n", __func__));


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->cokane 
Responsible-Changed-By: brian 
Responsible-Changed-When: Sun Jul 19 19:05:41 UTC 2009 
Responsible-Changed-Why:  
Assign to cokane as this claims to be a regression of r194432. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136895 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/136895: commit references a PR
Date: Mon, 20 Jul 2009 23:21:33 +0000 (UTC)

 Author: cokane
 Date: Mon Jul 20 23:21:19 2009
 New Revision: 195791
 URL: http://svn.freebsd.org/changeset/base/195791
 
 Log:
   Fix regression in last set of commits. Submitted via e-mail and then
   nagged again via PR. Thank Paul for his persistence and contributions.
   
   PR:		136895
   Submitted by:	Paul B. Mahol <onemda@gmail.com>
   Reviewed by:	sam (timeout, 10 days), weongyo (timeout, 10 days), me
   Approved by:	re (Kostik Belousov <kostikbel@gmail.com>)
 
 Modified:
   head/sys/dev/if_ndis/if_ndis.c
 
 Modified: head/sys/dev/if_ndis/if_ndis.c
 ==============================================================================
 --- head/sys/dev/if_ndis/if_ndis.c	Mon Jul 20 21:45:44 2009	(r195790)
 +++ head/sys/dev/if_ndis/if_ndis.c	Mon Jul 20 23:21:19 2009	(r195791)
 @@ -2292,6 +2292,8 @@ ndis_setstate_80211(sc)
  	ifp = sc->ifp;
  	ic = ifp->if_l2com;
  	vap = TAILQ_FIRST(&ic->ic_vaps);
 +	if (vap == NULL)
 +		return;
  
  	if (!NDIS_INITIALIZED(sc)) {
  		DPRINTF(("%s: NDIS not initialized\n", __func__));
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: cokane 
State-Changed-When: Tue Sep 22 12:45:59 UTC 2009 
State-Changed-Why:  
Committed in r195791 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136895 
>Unformatted:
