From nobody@FreeBSD.org  Wed Jun 24 04:21:10 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 42B6E1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Jun 2009 04:21:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 25C318FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Jun 2009 04:21:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n5O4L9iX099650
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Jun 2009 04:21:09 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n5O4L952099649;
	Wed, 24 Jun 2009 04:21:09 GMT
	(envelope-from nobody)
Message-Id: <200906240421.n5O4L952099649@www.freebsd.org>
Date: Wed, 24 Jun 2009 04:21:09 GMT
From: "Rashid N. Achilov" <citycat4@ngs.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: device vr support D-Link DFE-520TX, but none notified this
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         135989
>Category:       kern
>Synopsis:       [NOTES] [patch] device vr support D-Link DFE-520TX, but none notified this
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gavin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 24 04:30:01 UTC 2009
>Closed-Date:    Tue Feb 23 22:02:12 UTC 2010
>Last-Modified:  Tue Feb 23 22:02:12 UTC 2010
>Originator:     Rashid N. Achilov
>Release:        7.2-RELEASE
>Organization:
LLC "AS-System Complex"
>Environment:
FreeBSD 7.2-RELEASE #0: Wed Jun 10 14:19:08 NOVST 2009
glance kernel: root@glance.askd.gmbh:/usr/obj/usr/src/sys/Glance
>Description:
I had NIC D-Link DFE-520TX, but I could not detect, which driver supports this. NOTES file does not mark anything about this NIC

svr-63:[root] 251>cd /sys/conf && grep 520 *
NOTES:hint.uart.0.baud="115200"

svr-63:[root] 255>cd /sys/i386/conf && grep 520 *
LINT:options    CONSPEED=115200
NOTES:# CPU_ELAN enables support for AMDs ElanSC520 CPU.
NOTES:options   CONSPEED=115200         # Speed for serial console

I have to reload server with GENERIC kernel and this way I have detect, that this NIC supported by vr driver

Jun 24 10:38:14 glance kernel: vr0: <VIA VT6105 Rhine III 10/100BaseTX> port 0xd800-0xd8ff mem 0xff8ffc00-0xff8ffcff irq 22 at device 1.0 on pci1
Jun 24 10:38:14 glance kernel: vr0: Quirks: 0x0
Jun 24 10:38:14 glance kernel: vr0: Revision: 0x8b
Jun 24 10:38:14 glance kernel: miibus0: <MII bus> on vr0
Jun 24 10:38:14 glance kernel: ukphy0: <Generic IEEE 802.3u media interface> PHY 1 on miibus0
Jun 24 10:38:14 glance kernel: ukphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
Jun 24 10:38:14 glance kernel: vr0: Ethernet address: 00:1b:11:c3:8e:cc
Jun 24 10:38:14 glance kernel: vr0: [ITHREAD]

manual page about  vr doesn't know anything about DFE-520TX (but claims about support DFE530-TX). So, only way to detect right driver for NIC is load server with GENERIC kernel, that's incorrect. I had done a coulpe simply patches, which included notification about supporting D-Link DFE-520TX NIC's


>How-To-Repeat:
Install D-Link DFE-520TX and try to guess, which driver support it without reloading GENERIC kernel or loading all available NIC drivers
>Fix:
Patches included

Patch attached with submission follows:

--- sys/conf/NOTES.old	2009-03-22 22:27:14.000000000 +0600
+++ sys/conf/NOTES	2009-06-24 11:11:13.000000000 +0700
@@ -1824,8 +1824,8 @@
 # txp:	Support for 3Com 3cR990 cards with the "Typhoon" chipset
 # vr:   Support for various fast ethernet adapters based on the VIA
 #       Technologies VT3043 `Rhine I' and VT86C100A `Rhine II' chips,
-#       including the D-Link DFE530TX (see 'rl' for DFE530TX+), the Hawking
-#       Technologies PN102TX, and the AOpen/Acer ALN-320.
+#       including the D-Link DFE520TX and D-Link DFE530TX (see 'rl' for DFE530TX+),
+#	the Hawking Technologies PN102TX, and the AOpen/Acer ALN-320.
 # vx:   3Com 3C590 and 3C595
 # wb:   Support for fast ethernet adapters based on the Winbond W89C840F chip.
 #       Note: this is not the same as the Winbond W89C940F, which is a


--- share/man/man4/vr.4.old	2008-04-11 10:49:47.000000000 +0700
+++ share/man/man4/vr.4	2009-06-24 11:16:35.000000000 +0700
@@ -130,6 +130,8 @@
 .It
 AOpen/Acer ALN-320
 .It
+D-Link DFE520-TX
+.It
 D-Link DFE530-TX
 .It
 Hawking Technologies PN102TX




>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Sun Feb 7 18:08:57 UTC 2010 
State-Changed-Why:  
Fixed in head, MFC in a week 


Responsible-Changed-From-To: freebsd-bugs->gavin 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Sun Feb 7 18:08:57 UTC 2010 
Responsible-Changed-Why:  
Mine 

http://www.freebsd.org/cgi/query-pr.cgi?pr=135989 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/135989: commit references a PR
Date: Sun,  7 Feb 2010 18:05:25 +0000 (UTC)

 Author: gavin
 Date: Sun Feb  7 18:05:12 2010
 New Revision: 203620
 URL: http://svn.freebsd.org/changeset/base/203620
 
 Log:
   Document support for the D-Link DFE520-TX card (supported with the vr(4)
   driver)
   
   PR:		kern/135989
   Submitted by:	"Rashid N. Achilov"  citycat4 ngs.ru
 
 Modified:
   head/share/man/man4/vr.4
   head/sys/conf/NOTES
 
 Modified: head/share/man/man4/vr.4
 ==============================================================================
 --- head/share/man/man4/vr.4	Sun Feb  7 18:01:19 2010	(r203619)
 +++ head/share/man/man4/vr.4	Sun Feb  7 18:05:12 2010	(r203620)
 @@ -130,6 +130,8 @@ Fast Ethernet adapters including:
  .It
  AOpen/Acer ALN-320
  .It
 +D-Link DFE520-TX
 +.It
  D-Link DFE530-TX
  .It
  Hawking Technologies PN102TX
 
 Modified: head/sys/conf/NOTES
 ==============================================================================
 --- head/sys/conf/NOTES	Sun Feb  7 18:01:19 2010	(r203619)
 +++ head/sys/conf/NOTES	Sun Feb  7 18:05:12 2010	(r203620)
 @@ -1974,8 +1974,8 @@ device		xmphy		# XaQti XMAC II
  # txp:	Support for 3Com 3cR990 cards with the "Typhoon" chipset
  # vr:   Support for various fast ethernet adapters based on the VIA
  #       Technologies VT3043 `Rhine I' and VT86C100A `Rhine II' chips,
 -#       including the D-Link DFE530TX (see 'rl' for DFE530TX+), the Hawking
 -#       Technologies PN102TX, and the AOpen/Acer ALN-320.
 +#       including the D-Link DFE520TX and D-Link DFE530TX (see 'rl' for
 +#       DFE530TX+), the Hawking Technologies PN102TX, and the AOpen/Acer ALN-320.
  # vx:   3Com 3C590 and 3C595
  # wb:   Support for fast ethernet adapters based on the Winbond W89C840F chip.
  #       Note: this is not the same as the Winbond W89C940F, which is a
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/135989: commit references a PR
Date: Sun, 14 Feb 2010 09:41:44 +0000 (UTC)

 Author: gavin
 Date: Sun Feb 14 09:40:58 2010
 New Revision: 203857
 URL: http://svn.freebsd.org/changeset/base/203857
 
 Log:
   Merge r203620,203621 from head:
   
     Document support for the D-Link DFE520-TX card (supported with the vr(4)
     driver)
   
   PR:		kern/135989
   Submitted by:	"Rashid N. Achilov"  citycat4 ngs.ru
 
 Modified:
   stable/8/share/man/man4/vr.4
 Directory Properties:
   stable/8/share/man/man4/   (props changed)
 
 Modified: stable/8/share/man/man4/vr.4
 ==============================================================================
 --- stable/8/share/man/man4/vr.4	Sun Feb 14 09:37:13 2010	(r203856)
 +++ stable/8/share/man/man4/vr.4	Sun Feb 14 09:40:58 2010	(r203857)
 @@ -30,7 +30,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd March 11, 2008
 +.Dd February 7, 2010
  .Dt VR 4
  .Os
  .Sh NAME
 @@ -130,6 +130,8 @@ Fast Ethernet adapters including:
  .It
  AOpen/Acer ALN-320
  .It
 +D-Link DFE520-TX
 +.It
  D-Link DFE530-TX
  .It
  Hawking Technologies PN102TX
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/135989: commit references a PR
Date: Tue, 23 Feb 2010 19:34:36 +0000 (UTC)

 Author: gavin
 Date: Tue Feb 23 19:34:22 2010
 New Revision: 204254
 URL: http://svn.freebsd.org/changeset/base/204254
 
 Log:
   Merge r203620,203621 from head:
   
     Document support for the D-Link DFE520-TX card (supported with the vr(4)
     driver)
   
   PR:		kern/135989
   Submitted by:	"Rashid N. Achilov"  citycat4 ngs.ru
 
 Modified:
   stable/7/share/man/man4/vr.4
 Directory Properties:
   stable/7/share/man/man4/   (props changed)
 
 Modified: stable/7/share/man/man4/vr.4
 ==============================================================================
 --- stable/7/share/man/man4/vr.4	Tue Feb 23 18:42:07 2010	(r204253)
 +++ stable/7/share/man/man4/vr.4	Tue Feb 23 19:34:22 2010	(r204254)
 @@ -30,7 +30,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd March 11, 2008
 +.Dd February 7, 2010
  .Dt VR 4
  .Os
  .Sh NAME
 @@ -130,6 +130,8 @@ Fast Ethernet adapters including:
  .It
  AOpen/Acer ALN-320
  .It
 +D-Link DFE520-TX
 +.It
  D-Link DFE530-TX
  .It
  Hawking Technologies PN102TX
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Tue Feb 23 22:01:44 UTC 2010 
State-Changed-Why:  
Fixed in head, stable/8 and stable/7.  Thanks for your bug report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=135989 
>Unformatted:
