From nobody@FreeBSD.org  Tue May  5 06:15:44 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5516A106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  5 May 2009 06:15:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 449A58FC1B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  5 May 2009 06:15:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n456Fhbj014363
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 5 May 2009 06:15:43 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n456FhsN014362;
	Tue, 5 May 2009 06:15:43 GMT
	(envelope-from nobody)
Message-Id: <200905050615.n456FhsN014362@www.freebsd.org>
Date: Tue, 5 May 2009 06:15:43 GMT
From: Eugene Mychlo <myc@barev.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ng_netflow(4): incorrect comparison in ng_netflow_rcvmsg()
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         134220
>Category:       kern
>Synopsis:       [ng_netflow] [patch]: incorrect comparison in ng_netflow_rcvmsg()
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-net
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 05 06:20:01 UTC 2009
>Closed-Date:    Wed May 20 02:57:06 UTC 2009
>Last-Modified:  Wed May 20 02:57:06 UTC 2009
>Originator:     Eugene Mychlo
>Release:        FreeBSD 7.2-RC2
>Organization:
Rekomendata, JSC
>Environment:
FreeBSD mycws.local 7.2-RC2 FreeBSD 7.2-RC2 #0: Thu Apr 23 22:07:24 UTC 2009     root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
ng_netflow_rcvmsg() compare msg->header.arglen with sizeof(struct ng_netflow_settimeouts) instead of sizeof(struct ng_netflow_setconfig) when processing NGM_NETFLOW_SETCONFIG control message.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- sys/netgraph/netflow/ng_netflow.c	(revision 191778)
+++ sys/netgraph/netflow/ng_netflow.c	(working copy)
@@ -422,7 +422,7 @@
 		{
 			struct ng_netflow_setconfig *set;
 
-			if (msg->header.arglen != sizeof(struct ng_netflow_settimeouts))
+			if (msg->header.arglen != sizeof(struct ng_netflow_setconfig))
 				ERROUT(EINVAL);
 
 			set = (struct ng_netflow_setconfig *)msg->data;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon May 11 16:42:26 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134220 
State-Changed-From-To: open->patched 
State-Changed-By: mav 
State-Changed-When: Wed May 13 02:27:03 UTC 2009 
State-Changed-Why:  
Patch committed to 8-CURRENT. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134220 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/134220: commit references a PR
Date: Wed, 13 May 2009 02:26:48 +0000 (UTC)

 Author: mav
 Date: Wed May 13 02:26:34 2009
 New Revision: 192032
 URL: http://svn.freebsd.org/changeset/base/192032
 
 Log:
   Fix copy-paste bug in NGM_NETFLOW_SETCONFIG argument size verification.
   
   PR:		kern/134220
   Submitted by:	Eugene Mychlo
   MFC after:	1 week
 
 Modified:
   head/sys/netgraph/netflow/ng_netflow.c
 
 Modified: head/sys/netgraph/netflow/ng_netflow.c
 ==============================================================================
 --- head/sys/netgraph/netflow/ng_netflow.c	Wed May 13 00:04:08 2009	(r192031)
 +++ head/sys/netgraph/netflow/ng_netflow.c	Wed May 13 02:26:34 2009	(r192032)
 @@ -422,7 +422,7 @@ ng_netflow_rcvmsg (node_p node, item_p i
  		{
  			struct ng_netflow_setconfig *set;
  
 -			if (msg->header.arglen != sizeof(struct ng_netflow_settimeouts))
 +			if (msg->header.arglen != sizeof(struct ng_netflow_setconfig))
  				ERROUT(EINVAL);
  
  			set = (struct ng_netflow_setconfig *)msg->data;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/134220: commit references a PR
Date: Wed, 20 May 2009 02:49:09 +0000 (UTC)

 Author: mav
 Date: Wed May 20 02:48:53 2009
 New Revision: 192415
 URL: http://svn.freebsd.org/changeset/base/192415
 
 Log:
   MFC rev. 192032
   
   Fix copy-paste bug in NGM_NETFLOW_SETCONFIG argument size verification.
   
   PR:		kern/134220
   Submitted by:	Eugene Mychlo
 
 Modified:
   stable/7/sys/   (props changed)
   stable/7/sys/contrib/pf/   (props changed)
   stable/7/sys/dev/ath/ath_hal/   (props changed)
   stable/7/sys/dev/cxgb/   (props changed)
   stable/7/sys/netgraph/netflow/ng_netflow.c
 
 Modified: stable/7/sys/netgraph/netflow/ng_netflow.c
 ==============================================================================
 --- stable/7/sys/netgraph/netflow/ng_netflow.c	Wed May 20 02:24:09 2009	(r192414)
 +++ stable/7/sys/netgraph/netflow/ng_netflow.c	Wed May 20 02:48:53 2009	(r192415)
 @@ -422,7 +422,7 @@ ng_netflow_rcvmsg (node_p node, item_p i
  		{
  			struct ng_netflow_setconfig *set;
  
 -			if (msg->header.arglen != sizeof(struct ng_netflow_settimeouts))
 +			if (msg->header.arglen != sizeof(struct ng_netflow_setconfig))
  				ERROUT(EINVAL);
  
  			set = (struct ng_netflow_setconfig *)msg->data;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: mav 
State-Changed-When: Wed May 20 02:56:31 UTC 2009 
State-Changed-Why:  
Patch merged to 7-STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134220 
>Unformatted:
