From nobody@FreeBSD.org  Tue Mar 31 03:20:31 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C4F0C106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Mar 2009 03:20:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id B2BDE8FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Mar 2009 03:20:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2V3KVQl093010
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 31 Mar 2009 03:20:31 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n2V3KVM8093009;
	Tue, 31 Mar 2009 03:20:31 GMT
	(envelope-from nobody)
Message-Id: <200903310320.n2V3KVM8093009@www.freebsd.org>
Date: Tue, 31 Mar 2009 03:20:31 GMT
From: soflare <soflare@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Process SIOCDLIFADDR command incorrectly in in_control()
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         133235
>Category:       kern
>Synopsis:       [netinet] [patch] Process SIOCDLIFADDR command incorrectly in in_control()
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-net
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 31 03:30:02 UTC 2009
>Closed-Date:    
>Last-Modified:  Tue Mar 31 10:40:01 UTC 2009
>Originator:     soflare
>Release:        7.0-RELEASE
>Organization:
>Environment:
FreeBSD liangzy-fbsd7.home.net 7.1-RELEASE FreeBSD 7.1-RELEASE #12: Fri Mar 20 21:19:12 UTC 2009     root@liangzy-fbsd7.arraynetworks.com.cn:/usr/obj/usr/src/sys/SOLAR  i386

>Description:
Can't delete an alias by using SIOCDLIFADDR command. Always return EADDRNOTAVAIL.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- in.c	2009-03-20 21:09:46.000000000 +0000
+++ src/sys/netinet/in.c	2009-03-20 21:15:35.000000000 +0000
@@ -634,11 +634,13 @@ in_lifaddr_ioctl(struct socket *so, u_lo
 		}
 
 		TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link)	{
-			if (ifa->ifa_addr->sa_family != AF_INET6)
+			struct sockaddr_in *sa;
+			sa=(struct sockaddr_in *)ifa->ifa_addr;
+			if (ifa->ifa_addr->sa_family != AF_INET)
 				continue;
 			if (match.s_addr == 0)
 				break;
-			candidate.s_addr = ((struct sockaddr_in *)&ifa->ifa_addr)->sin_addr.s_addr;
+			candidate.s_addr = sa->sin_addr.s_addr;
 			candidate.s_addr &= mask.s_addr;
 			if (candidate.s_addr == match.s_addr)
 				break;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Mar 31 05:49:29 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133235 

From: LiangZhenyu <liangzy@arraynetworks.com.cn>
To: bug-followup@FreeBSD.org, soflare@gmail.com
Cc:  
Subject: Re: kern/133235: [netinet] [patch] Process SIOCDLIFADDR command incorrectly
 in in_control()
Date: Tue, 31 Mar 2009 18:02:50 +0800

 The long expression:
 
 candidate.s_addr = ((struct sockaddr_in *)&ifa->ifa_addr)->sin_addr.s_addr;
 
 will cause a compilation problem in my machine. The target can be generated but was wrong.
 So I split it to 2 short expressions.
 
 
>Unformatted:
