From nobody@FreeBSD.org  Sat Mar 28 23:52:15 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 99089106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 28 Mar 2009 23:52:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6D2FA8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 28 Mar 2009 23:52:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2SNqDS4024241
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 28 Mar 2009 23:52:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n2SNqDaR024240;
	Sat, 28 Mar 2009 23:52:13 GMT
	(envelope-from nobody)
Message-Id: <200903282352.n2SNqDaR024240@www.freebsd.org>
Date: Sat, 28 Mar 2009 23:52:13 GMT
From: Bruce Cran <bruce@cran.org.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: panic when detaching swap-backed md(4) disk which has gone into swap
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         133170
>Category:       kern
>Synopsis:       [md] [panic] panic when detaching swap-backed md(4) disk which has gone into swap
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 29 00:00:09 UTC 2009
>Closed-Date:    Fri Feb 04 10:23:25 UTC 2011
>Last-Modified:  Fri Feb  4 10:30:18 UTC 2011
>Originator:     Bruce Cran
>Release:        7-STABLE
>Organization:
>Environment:
FreeBSD gluon.draftnet 7.2-PRERELEASE FreeBSD 7.2-PRERELEASE #0: Tue Mar 24 10:45:31 GMT 2009     brucec@gluon.draftnet:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
When detaching a swap-backed md(4) disk which is larger than physical
memory and which has forced the system into swap I get a panic
(on 7-STABLE). The following commands trigger it:

mdconfig -a -t swap -s 5T
newfs /dev/md0
[cancel newfs when the system goes into swap by ~200MB]
mdconfig -d -u 0

After a few seconds the system panics with:

panic: swp_pager_meta_free_all: failed to locate all swap meta blocks

#0  doadump () at pcpu.h:196
#1  0xc07e2aa7 in boot (howto=260)
at /usr/src/sys/kern/kern_shutdown.c:418 #2  0xc07e2d79 in panic
(fmt=Variable "fmt" is not available. )
at /usr/src/sys/kern/kern_shutdown.c:574 #3  0xc0a0c575 in
swp_pager_meta_free_all (object=0x0)
at /usr/src/sys/vm/swap_pager.c:1845 #4  0xc0a0e637 in
swap_pager_dealloc (object=0xc5bb0380)
at /usr/src/sys/vm/swap_pager.c:517 #5  0xc0a2a84a in
vm_pager_deallocate (object=0xc5bb0380)
at /usr/src/sys/vm/vm_pager.c:252 #6  0xc0a246a4 in vm_object_terminate
(object=0xc5bb0380) at /usr/src/sys/vm/vm_object.c:708
#7  0xc0a24dd3 in vm_object_deallocate (object=0xc5bb0380)
    at /usr/src/sys/vm/vm_object.c:602
#8  0xc06461c9 in mddestroy (sc=0xc8576800, td=0xc481b460)
    at /usr/src/sys/dev/md/md.c:986
#9  0xc0647159 in mdctlioctl (dev=0xc4226100, cmd=3249827073, 
    addr=0xc62f9a00 "", flags=3, td=0xc481b460)
    at /usr/src/sys/dev/md/md.c:1128
#10 0xc076fff7 in devfs_ioctl_f (fp=0xc477d260, com=3249827073, 
    data=0xc62f9a00, cred=0xc8689400, td=0xc481b460)
    at /usr/src/sys/fs/devfs/devfs_vnops.c:602
#11 0xc0819ff5 in kern_ioctl (td=0xc481b460, fd=3, com=3249827073, 
    data=0xc62f9a00 "") at file.h:269
---Type <return> to continue, or q <return> to quit---
#12 0xc081a154 in ioctl (td=0xc481b460, uap=0xe6795cfc)
    at /usr/src/sys/kern/sys_generic.c:570
#13 0xc0ae0b15 in syscall (frame=0xe6795d38)
    at /usr/src/sys/i386/i386/trap.c:1090
#14 0xc0ac58b0 in Xint0x80_syscall ()
at /usr/src/sys/i386/i386/exception.s:255 #15 0x00000033 in ?? ()
Previous frame inner to this frame (corrupt stack?)
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/133170: commit references a PR
Date: Sat,  1 Jan 2011 16:59:12 +0000 (UTC)

 Author: brucec
 Date: Sat Jan  1 16:59:05 2011
 New Revision: 216873
 URL: http://svn.freebsd.org/changeset/base/216873
 
 Log:
   There can be more than 0x20000000 swap meta blocks allocated if a swap-backed
   md(4) device is used. Don't panic when deallocating such a device if swap
   has been used.
   
   PR:	kern/133170
   Discussed with:	kib
   MFC after:	3 days
 
 Modified:
   head/sys/vm/swap_pager.c
 
 Modified: head/sys/vm/swap_pager.c
 ==============================================================================
 --- head/sys/vm/swap_pager.c	Sat Jan  1 16:47:12 2011	(r216872)
 +++ head/sys/vm/swap_pager.c	Sat Jan  1 16:59:05 2011	(r216873)
 @@ -1679,8 +1679,6 @@ swap_pager_isswapped(vm_object_t object,
  			}
  		}
  		index += SWAP_META_PAGES;
 -		if (index > 0x20000000)
 -			panic("swap_pager_isswapped: failed to locate all swap meta blocks");
  	}
  	mtx_unlock(&swhash_mtx);
  	return (0);
 @@ -1995,8 +1993,6 @@ swp_pager_meta_free_all(vm_object_t obje
  		}
  		mtx_unlock(&swhash_mtx);
  		index += SWAP_META_PAGES;
 -		if (index > 0x20000000)
 -			panic("swp_pager_meta_free_all: failed to locate all swap meta blocks");
  	}
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: brucec 
State-Changed-When: Sat Jan 1 17:20:48 UTC 2011 
State-Changed-Why:  
Fixed in HEAD. 


Responsible-Changed-From-To: freebsd-bugs->brucec 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Sat Jan 1 17:20:48 UTC 2011 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133170 
State-Changed-From-To: patched->closed 
State-Changed-By: brucec 
State-Changed-When: Fri Feb 4 10:22:57 UTC 2011 
State-Changed-Why:  
Fix merged to stable/7 and stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133170 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/133170: commit references a PR
Date: Fri,  4 Feb 2011 10:20:13 +0000 (UTC)

 Author: brucec
 Date: Fri Feb  4 10:19:56 2011
 New Revision: 218259
 URL: http://svn.freebsd.org/changeset/base/218259
 
 Log:
   MFC r216873:
   
   There can be more than 0x20000000 swap meta blocks allocated if a swap-backed
   md(4) device is used. Don't panic when deallocating such a device if swap
   has been used.
   
   PR:	kern/133170
 
 Modified:
   stable/8/sys/vm/swap_pager.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
 
 Modified: stable/8/sys/vm/swap_pager.c
 ==============================================================================
 --- stable/8/sys/vm/swap_pager.c	Fri Feb  4 09:15:23 2011	(r218258)
 +++ stable/8/sys/vm/swap_pager.c	Fri Feb  4 10:19:56 2011	(r218259)
 @@ -1668,8 +1668,6 @@ swap_pager_isswapped(vm_object_t object,
  			}
  		}
  		index += SWAP_META_PAGES;
 -		if (index > 0x20000000)
 -			panic("swap_pager_isswapped: failed to locate all swap meta blocks");
  	}
  	mtx_unlock(&swhash_mtx);
  	return (0);
 @@ -1984,8 +1982,6 @@ swp_pager_meta_free_all(vm_object_t obje
  		}
  		mtx_unlock(&swhash_mtx);
  		index += SWAP_META_PAGES;
 -		if (index > 0x20000000)
 -			panic("swp_pager_meta_free_all: failed to locate all swap meta blocks");
  	}
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/133170: commit references a PR
Date: Fri,  4 Feb 2011 10:22:24 +0000 (UTC)

 Author: brucec
 Date: Fri Feb  4 10:22:19 2011
 New Revision: 218261
 URL: http://svn.freebsd.org/changeset/base/218261
 
 Log:
   MFC r216873:
   
   There can be more than 0x20000000 swap meta blocks allocated if a swap-backed
   md(4) device is used. Don't panic when deallocating such a device is swap
   has been used.
   
   PR:	kern/133170
 
 Modified:
   stable/7/sys/vm/swap_pager.c
 Directory Properties:
   stable/7/sys/   (props changed)
   stable/7/sys/cddl/contrib/opensolaris/   (props changed)
   stable/7/sys/contrib/dev/acpica/   (props changed)
   stable/7/sys/contrib/pf/   (props changed)
 
 Modified: stable/7/sys/vm/swap_pager.c
 ==============================================================================
 --- stable/7/sys/vm/swap_pager.c	Fri Feb  4 10:21:16 2011	(r218260)
 +++ stable/7/sys/vm/swap_pager.c	Fri Feb  4 10:22:19 2011	(r218261)
 @@ -1528,8 +1528,6 @@ swap_pager_isswapped(vm_object_t object,
  			}
  		}
  		index += SWAP_META_PAGES;
 -		if (index > 0x20000000)
 -			panic("swap_pager_isswapped: failed to locate all swap meta blocks");
  	}
  	mtx_unlock(&swhash_mtx);
  	return (0);
 @@ -1844,8 +1842,6 @@ swp_pager_meta_free_all(vm_object_t obje
  		}
  		mtx_unlock(&swhash_mtx);
  		index += SWAP_META_PAGES;
 -		if (index > 0x20000000)
 -			panic("swp_pager_meta_free_all: failed to locate all swap meta blocks");
  	}
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
