From nobody@FreeBSD.org  Wed Mar 25 15:14:16 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 53C5010657EA
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Mar 2009 15:14:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3C1B68FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Mar 2009 15:14:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2PFEGQk032500
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Mar 2009 15:14:16 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n2PFEFYG032498;
	Wed, 25 Mar 2009 15:14:15 GMT
	(envelope-from nobody)
Message-Id: <200903251514.n2PFEFYG032498@www.freebsd.org>
Date: Wed, 25 Mar 2009 15:14:15 GMT
From: Mateusz Guzik <mjguzik@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [sysv] Missing free(sema_mtx, M_SEM) in sys/kern/sysv_sem.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         133064
>Category:       kern
>Synopsis:       [sysv] [patch] Missing free(sema_mtx, M_SEM) in sys/kern/sysv_sem.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 25 15:20:07 UTC 2009
>Closed-Date:    Mon Apr 13 17:53:15 CEST 2009
>Last-Modified:  Mon Apr 13 17:53:15 CEST 2009
>Originator:     Mateusz Guzik
>Release:        8.0-CURRENT
>Organization:
>Environment:
>Description:
seminit() allocates memory for sema_mtx, but semunload() does not free it.
>How-To-Repeat:

>Fix:
Call free(sema_mtx, M_SEM) in semunload().

Patch attached with submission follows:

--- sysv_sem.c.orig	2009-01-15 12:15:46.000000000 +0000
+++ sysv_sem.c	2009-03-25 14:44:25.000000000 +0000
@@ -285,6 +285,7 @@
 	free(semu, M_SEM);
 	for (i = 0; i < seminfo.semmni; i++)
 		mtx_destroy(&sema_mtx[i]);
+	free(sema_mtx, M_SEM);
 	mtx_destroy(&sem_mtx);
 	mtx_destroy(&sem_undo_mtx);
 	return (0);


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Mon Mar 30 17:01:55 CEST 2009 
State-Changed-Why:  
Fixed in HEAD.  Thanks for the report! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Mon Mar 30 17:01:55 CEST 2009 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133064 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/133064: commit references a PR
Date: Mon, 30 Mar 2009 15:01:49 +0000 (UTC)

 Author: brueffer
 Date: Mon Mar 30 15:01:29 2009
 New Revision: 190557
 URL: http://svn.freebsd.org/changeset/base/190557
 
 Log:
   Fix memory leak in semunload().
   
   PR:		133064
   Submitted by:	Mateusz Guzik <mjguzik@gmail.com>
   MFC after:	1 week
 
 Modified:
   head/sys/kern/sysv_sem.c
 
 Modified: head/sys/kern/sysv_sem.c
 ==============================================================================
 --- head/sys/kern/sysv_sem.c	Mon Mar 30 14:11:37 2009	(r190556)
 +++ head/sys/kern/sysv_sem.c	Mon Mar 30 15:01:29 2009	(r190557)
 @@ -285,6 +285,7 @@ semunload(void)
  	free(semu, M_SEM);
  	for (i = 0; i < seminfo.semmni; i++)
  		mtx_destroy(&sema_mtx[i]);
 +	free(sema_mtx, M_SEM);
  	mtx_destroy(&sem_mtx);
  	mtx_destroy(&sem_undo_mtx);
  	return (0);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Mon Apr 13 17:52:54 CEST 2009 
State-Changed-Why:  
MFC done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133064 
>Unformatted:
