From nobody@FreeBSD.org  Tue Mar 24 00:35:32 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 23802106578F
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Mar 2009 00:35:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 10FF88FC31
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Mar 2009 00:35:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2O0ZV01055992
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 24 Mar 2009 00:35:31 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n2O0ZVrr055991;
	Tue, 24 Mar 2009 00:35:31 GMT
	(envelope-from nobody)
Message-Id: <200903240035.n2O0ZVrr055991@www.freebsd.org>
Date: Tue, 24 Mar 2009 00:35:31 GMT
From: Matthew Fleming <mfleming@isilon.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: unionfs_readdir has math problem
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         132987
>Category:       kern
>Synopsis:       [unionfs] unionfs_readdir has math problem
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    daichi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 24 00:40:05 UTC 2009
>Closed-Date:    Thu May 03 07:23:39 UTC 2012
>Last-Modified:  Thu May  3 07:30:12 UTC 2012
>Originator:     Matthew Fleming
>Release:        RELENG 7.1
>Organization:
Isilon Systems
>Environment:
n/a
>Description:
It looks like unionfs_readdir() has a math problem.  My guess as to what was meant:

	if (cookies_bk != NULL) {
		/* merge cookies */
		int		size;
		u_long         *newcookies, *pos;

		size = *(ap->a_ncookies) + ncookies_bk;
		newcookies = (u_long *) malloc(size * sizeof(u_long),
		    M_TEMP, M_WAITOK);
		pos = newcookies;

		memcpy(pos, cookies_bk, ncookies_bk * sizeof(u_long));
-		pos += ncookies_bk * sizeof(u_long);
+		pos += ncookies_bk;
		memcpy(pos, *(ap->a_cookies), *(ap->a_ncookies) * sizeof(u_long));
		free(cookies_bk, M_TEMP);
		free(*(ap->a_cookies), M_TEMP);
		*(ap->a_ncookies) = size;
		*(ap->a_cookies) = newcookies;
	}

>How-To-Repeat:
n/a
>Fix:
See Full Description above.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->daichi 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Mar 24 01:05:40 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132987 
State-Changed-From-To: open->closed 
State-Changed-By: daichi 
State-Changed-When: Thu May 3 07:23:16 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132987 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/132987: commit references a PR
Date: Thu,  3 May 2012 07:22:40 +0000 (UTC)

 Author: daichi
 Date: Thu May  3 07:22:29 2012
 New Revision: 234944
 URL: http://svn.freebsd.org/changeset/base/234944
 
 Log:
   fixed a unionfs_readdir math issue
   
   PR:		132987
   Submitted by:	Matthew Fleming <mfleming@isilon.com>
 
 Modified:
   head/sys/fs/unionfs/union_vnops.c
 
 Modified: head/sys/fs/unionfs/union_vnops.c
 ==============================================================================
 --- head/sys/fs/unionfs/union_vnops.c	Thu May  3 07:17:25 2012	(r234943)
 +++ head/sys/fs/unionfs/union_vnops.c	Thu May  3 07:22:29 2012	(r234944)
 @@ -1642,7 +1642,7 @@ unionfs_readdir(struct vop_readdir_args 
  		pos = newcookies;
  
  		memcpy(pos, cookies_bk, ncookies_bk * sizeof(u_long));
 -		pos += ncookies_bk * sizeof(u_long);
 +		pos += ncookies_bk;
  		memcpy(pos, *(ap->a_cookies), *(ap->a_ncookies) * sizeof(u_long));
  		free(cookies_bk, M_TEMP);
  		free(*(ap->a_cookies), M_TEMP);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
