From nobody@FreeBSD.org  Sat Feb 14 21:21:48 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A1573106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 14 Feb 2009 21:21:48 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 8E1168FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 14 Feb 2009 21:21:48 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n1ELLmux001194
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 14 Feb 2009 21:21:48 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n1ELLmXb001193;
	Sat, 14 Feb 2009 21:21:48 GMT
	(envelope-from nobody)
Message-Id: <200902142121.n1ELLmXb001193@www.freebsd.org>
Date: Sat, 14 Feb 2009 21:21:48 GMT
From: Adam Hopstetter <ahopstetter@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: 2/14/2009 - CVSup'd to RELENG_7-stable - build kernel with libiconv fails with ../../../libkern/iconv.c: In function 'iconv_mod_unload'
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         131683
>Category:       kern
>Synopsis:       2/14/2009 - CVSup'd to RELENG_7-stable - build kernel with libiconv fails with ../../../libkern/iconv.c: In function 'iconv_mod_unload'
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    gavin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 14 21:30:02 UTC 2009
>Closed-Date:    Sun Feb 15 11:53:51 UTC 2009
>Last-Modified:  Wed Feb 18 16:21:40 UTC 2009
>Originator:     Adam Hopstetter
>Release:        freebsd-7-stable
>Organization:
Adam Hopstetter
>Environment:
FreeBSD evangelist 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Mon Nov 24 20:22:16 EST 2008     root@pcbsdx32-7:/usr/obj/pcbsd-build/cvs/7.0.2-src/sys/PCBSD  i386
>Description:
perform cvsup on RELENG_7 on/after 2/14/2009 ... and make buildkernel fails with the following error ...

 ../../../libkern/iconv.c: In function 'iconv_mod_unload'
>How-To-Repeat:
Attempt to build a the kernel with built-in libiconv support after CVSUP'ing RELENG_7 on/after 2/14/2009
>Fix:
patch src/sys/sys/sx.h with the attached patch file!



Patch attached with submission follows:

--- sx.h.orig	2009-02-14 15:49:28.000000000 -0500
+++ sx.h	2009-02-14 16:15:18.000000000 -0500
@@ -35,6 +35,7 @@
 #include <sys/_lock.h>
 #include <sys/_sx.h>
 #include <sys/lock_profile.h>
+#include <sys/proc.h>
 
 #ifdef	_KERNEL
 #include <machine/atomic.h>


>Release-Note:
>Audit-Trail:

From: Adam Hopstetter <ahopstetter@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/131683: 2/14/2009 - CVSup'd to RELENG_7-stable - build kernel
 with libiconv fails with ../../../libkern/iconv.c: In function 'iconv_mod_unload'
Date: Sat, 14 Feb 2009 22:43:32 -0500

 This is a multi-part message in MIME format.
 --------------030302040308030504080503
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Sorry ... previous patch posted causes break in buildworld. ... 
 apparrently pf/ftp-proxy.c declares "session" while sys/proc.h does as 
 well .... c++ namespaces anyone?
 
 Attached is the patch that allows for buildkernel and buildworld with 
 kernel libiconv...
 
 Sincerely,
 
 Adam Hopstetter
 
 
 
 
 --------------030302040308030504080503
 Content-Type: text/plain;
  name="new_patch.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="new_patch.txt"
 
 --- sys/sys/sx.h.orig	2009-02-14 15:49:28.000000000 -0500
 +++ sys/sys/sx.h	2009-02-14 21:38:04.000000000 -0500
 @@ -37,6 +37,7 @@
  #include <sys/lock_profile.h>
  
  #ifdef	_KERNEL
 +#include <sys/proc.h>
  #include <machine/atomic.h>
  #endif
  
 
 --------------030302040308030504080503--
State-Changed-From-To: open->closed 
State-Changed-By: gavin 
State-Changed-When: Sun Feb 15 11:49:35 UTC 2009 
State-Changed-Why:  
To submitter: the PR database is for bugs in FreeBSD and is 
not really a place for build issues.  Please post to the 
freebsd-stable@freebsd.org mailing list, and describe your 
problem there.  Please also include more of the error message - 
you failed to provide the actual error so it's impossible to 
determine where the problem even is in your original message. 


Responsible-Changed-From-To: freebsd-bugs->gavin 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Sun Feb 15 11:49:35 UTC 2009 
Responsible-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=131683 
State-Changed-From-To: closed->closed  
State-Changed-By: gavin 
State-Changed-When: Wed Feb 18 16:20:13 UTC 2009 
State-Changed-Why:  
FWIW, this was fixed in SVN r188714 Tue Feb 17 15:41:41 2009 UTC 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131683 
>Unformatted:
