From nobody@FreeBSD.org  Mon Dec 22 16:33:21 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA8C51065670
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 22 Dec 2008 16:33:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id B88E18FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 22 Dec 2008 16:33:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mBMGXLDh019524
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 22 Dec 2008 16:33:21 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id mBMGXL2K019523;
	Mon, 22 Dec 2008 16:33:21 GMT
	(envelope-from nobody)
Message-Id: <200812221633.mBMGXL2K019523@www.freebsd.org>
Date: Mon, 22 Dec 2008 16:33:21 GMT
From: James Juran <james.juran@baesystems.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Argument names reversed in pf_table.c:_copyout()
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         129861
>Category:       kern
>Synopsis:       [pf] [patch] Argument names reversed in pf_table.c:_copyout()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 22 16:40:01 UTC 2008
>Closed-Date:    Wed Jan 22 09:17:37 UTC 2014
>Last-Modified:  Wed Jan 22 09:17:37 UTC 2014
>Originator:     James Juran
>Release:        CURRENT
>Organization:
BAE Systems
>Environment:
n/a
>Description:
The formal paramaters in _copyout() in sys/contrib/pf/net/pf_table.c are reversed.  This does not cause an actual problem as they are passed on to copyout() correctly, but it is confusing.

>How-To-Repeat:
n/a

>Fix:
See patch.

Patch attached with submission follows:

Index: pf_table.c
===================================================================
--- pf_table.c	(revision 186395)
+++ pf_table.c	(working copy)
@@ -79,12 +79,12 @@ _copyin(const void *uaddr, void *kaddr, 
 }
 
 static inline int
-_copyout(const void *uaddr, void *kaddr, size_t len)
+_copyout(const void *kaddr, void *uaddr, size_t len)
 {
 	int r;
 
 	PF_UNLOCK();
-	r = copyout(uaddr, kaddr, len);
+	r = copyout(kaddr, uaddr, len);
 	PF_LOCK();
 
 	return (r);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-pf 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Dec 22 21:43:49 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129861 
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Tue Sep 11 10:43:56 UTC 2012 
State-Changed-Why:  
No applicable to head anymore. 


Responsible-Changed-From-To: freebsd-pf->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Tue Sep 11 10:43:56 UTC 2012 
Responsible-Changed-Why:  
No applicable to head anymore. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129861 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Wed Jan 22 09:17:16 UTC 2014 
State-Changed-Why:  
Fixed in 10.0-RELEASE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129861 
>Unformatted:
