From jedgar@pawn.primelocation.net Mon Aug  2 09:20:56 1999
Return-Path: <jedgar@pawn.primelocation.net>
Received: from pawn.primelocation.net (pawn.primelocation.net [205.161.238.235])
	by hub.freebsd.org (Postfix) with ESMTP id 3032B14BDD
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  2 Aug 1999 09:20:48 -0700 (PDT)
	(envelope-from jedgar@pawn.primelocation.net)
Received: by pawn.primelocation.net (Postfix, from userid 1003)
	id F148DF818; Mon,  2 Aug 1999 12:20:16 -0400 (EDT)
Message-Id: <19990802162016.F148DF818@pawn.primelocation.net>
Date: Mon,  2 Aug 1999 12:20:16 -0400 (EDT)
From: jedgar@fxp.org
Sender: jedgar@pawn.primelocation.net
Reply-To: jedgar@fxp.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] using BROKEN_KEYBOARD_RESET option gives warning upon kernel config(8)
X-Send-Pr-Version: 3.2

>Number:         12927
>Category:       kern
>Synopsis:       [PATCH] using BROKEN_KEYBOARD_RESET option gives warning upon kernel config(8)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jedgar
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug  2 09:30:01 PDT 1999
>Closed-Date:    Sat Jun 10 04:23:45 PDT 2000
>Last-Modified:  Sat Jun 10 04:24:09 PDT 2000
>Originator:     Chris D. Faulhaber
>Release:        FreeBSD 3.2-STABLE i386
>Organization:
>Environment:

	FreeBSD router.fxp 3.2-STABLE FreeBSD 3.2-STABLE #2: Sun Aug  2 11:19:49 EDT 1999

>Description:

	/sys/i386/conf/options.i386 does not include an entry for
	BROKEN_KEYBOARD_RESET; therefore, the following warning is issued:

		router# config ROUTER
		ROUTER:36: unknown option "BROKEN_KEYBOARD_RESET"
		Unknown option used - it is VERY important that you do
	         	make clean && make depend
		before recompiling
		Kernel build directory is ../../compile/ROUTER
		router#

	even though LINT has the entry:

		# BROKEN_KEYBOARD_RESET disables the use of the keyboard controller to
		# reset the CPU for reboot.  This is needed on some systems with broken
		# keyboard controllers.

	and

		#options        BROKEN_KEYBOARD_RESET

>How-To-Repeat:

	config(8) a kernel with the BROKEN_KEYBOARD_RESET option

>Fix:
	
	Apply the following patch which adds BROKEN_KEYBOARD_RESET to
	/sys/i386/conf/options.i386 and an #include line to
	/sys/i386/i386/vm_machdep.c:

--- /usr/src/sys/i386/conf/options.i386.orig	Wed Jul 14 23:30:34 1999
+++ /usr/src/sys/i386/conf/options.i386	Mon Aug  2 11:42:43 1999
@@ -1,5 +1,6 @@
 #	$Id: options.i386,v 1.103.2.5 1999/05/27 03:06:34 julian Exp $
 
+BROKEN_KEYBOARD_RESET
 DISABLE_PSE
 IDE_DELAY
 USER_LDT

--- /usr/src/sys/i386/i386/vm_machdep.c.orig	Wed Jan  6 18:05:37 1999
+++ /usr/src/sys/i386/i386/vm_machdep.c	Mon Aug  2 11:58:58 1999
@@ -42,6 +42,7 @@
  */
 
 #include "npx.h"
+#include "opt_broken_keyboard_reset.h"
 #include "opt_user_ldt.h"
 #include "opt_vm86.h"
 #ifdef PC98

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jedgar 
Responsible-Changed-By: ru 
Responsible-Changed-When: Thu Jan 6 02:30:04 PST 2000 
Responsible-Changed-Why:  
The originator volunteered to "assist in relieving the pressure on the PR system". 
State-Changed-From-To: open->closed 
State-Changed-By: jedgar 
State-Changed-When: Sat Jun 10 04:23:45 PDT 2000 
State-Changed-Why:  
Woohoo, someone finally committed, this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=12927 
>Unformatted:
