From nobody@FreeBSD.org  Mon Nov 10 13:07:56 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 257BE106568D
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 10 Nov 2008 13:07:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0D5FA8FC31
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 10 Nov 2008 13:07:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mAAD7tr4032016
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 10 Nov 2008 13:07:55 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id mAAD7t86032015;
	Mon, 10 Nov 2008 13:07:55 GMT
	(envelope-from nobody)
Message-Id: <200811101307.mAAD7t86032015@www.freebsd.org>
Date: Mon, 10 Nov 2008 13:07:55 GMT
From: Paul <onemda@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: BSS mode broken with ndis
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         128750
>Category:       kern
>Synopsis:       [ndis] BSS mode broken with ndis
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-net
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 10 13:10:01 UTC 2008
>Closed-Date:    Wed Nov 12 15:36:06 UTC 2008
>Last-Modified:  Wed Nov 12 15:36:06 UTC 2008
>Originator:     Paul
>Release:        FreeBSD 8.0 CURRENT
>Organization:
>Environment:
8.0-CURRENT FreeBSD i386
>Description:
ndis does not work properly in BSS mode. It does not set associd.
Fake one because ndis doesnt yet support HOSTAP mode.
>How-To-Repeat:
# kldload ndis if_ndis bcmwl5.ko
# ifconfig wlan8 create wlandev ndis0
# ifconfig wlan8 ssid SSID
# ifconfig wlan8 up
# dhclient wlan0  <-- here it display following type of messages if wlan debug messages are enabled:

wlan0: [ff:ff:ff:ff:ff:ff] discard frame, sta not associated (type 0x0800)
wlan0: [ff:ff:ff:ff:ff:ff] discard frame, sta not associated (type 0x0806)
>Fix:
--- /usr/src/sys/dev/if_ndis/if_ndis.c.orig      2008-11-10 13:43:12.000000000 +0100
+++ /usr/src/sys/dev/if_ndis/if_ndis.c   2008-11-10 13:53:51.000000000 +0100
@@ -2616,6 +2616,10 @@
        struct ndis_softc       *sc;
        ndis_wlan_bssid_ex      **assoc;
 {
+       struct ifnet *ifp = sc->ifp;
+       struct ieee80211com *ic = ifp->if_l2com;
+       struct ieee80211vap     *vap;
+       struct ieee80211_node   *ni;
        ndis_80211_bssid_list_ex        *bl;
        ndis_wlan_bssid_ex      *bs;
        ndis_80211_macaddr      bssid;
@@ -2624,6 +2628,9 @@
        if (!sc->ndis_link)
                return(ENOENT);
 
+       vap = TAILQ_FIRST(&ic->ic_vaps);
+       ni = vap->iv_bss;
+
        len = sizeof(bssid);
        error = ndis_get_info(sc, OID_802_11_BSSID, &bssid, &len);
        if (error) {
@@ -2654,6 +2661,8 @@
                        }
                        bcopy((char *)bs, (char *)*assoc, bs->nwbx_len);
                        free(bl, M_TEMP);
+                        if (ic->ic_opmode == IEEE80211_M_STA)
+                               ni->ni_associd = 1 | 0xc000; /* fake associd */
                        return(0);
                }
                bs = (ndis_wlan_bssid_ex *)((char *)bs + bs->nwbx_len);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Nov 12 08:44:00 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128750 
State-Changed-From-To: open->closed 
State-Changed-By: thompsa 
State-Changed-When: Wed Nov 12 15:35:27 UTC 2008 
State-Changed-Why:  
Fixed in r184833, does not affect older branches. Thanks Paul! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128750 
>Unformatted:
