From kieber@sax.sax.de  Fri May 31 05:45:47 1996
Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id FAA09773
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 31 May 1996 05:45:27 -0700 (PDT)
Received: from sax.sax.de by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id OAA12762 for <FreeBSD-gnats-submit@freebsd.org>; Fri, 31 May 1996 14:45:03 +0200
Received: by sax.sax.de (8.6.12/8.6.12-s1)
	id OAA27405; Fri, 31 May 1996 14:45:02 +0200
Message-Id: <199605311245.OAA27405@sax.sax.de>
Date: Fri, 31 May 1996 14:45:02 +0200
From: kieber@sax.sax.de (Ulf Kieber)
Reply-To: kieber@sax.sax.de
To: FreeBSD-gnats-submit@freebsd.org
Subject: cleaning out compiler fuzz
X-Send-Pr-Version: 3.2

>Number:         1283
>Category:       kern
>Synopsis:       cleaning out some compiler fuzz from pcvt_hdr.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    joerg
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 31 05:50:01 PDT 1996
>Closed-Date:    Sun Aug 11 00:18:50 MET DST 1996
>Last-Modified:  Sun Aug 11 00:19:26 MET DST 1996
>Originator:     Ulf Kieber
>Release:        FreeBSD 2.1-STABLE i386
>Organization:
SaxNet e. V.
>Environment:
FreeBSD sax.sax.de 2.1.0-RELEASE FreeBSD 2.1.0-RELEASE #2: Tue May 21 16:11:07 MET DST 1996     root@sax.sax.de:/usr/src/sys/compile/SAX.exabyte  i386
>Description:
kernel make says:

cc -c -O -pipe -W -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit -nostdinc -I. -I../.. -I../../sys -I../../../include -DSAX -DI486_CPU -DNMBCLUSTERS='(1024+MAXUSERS*16)' -DDFLDSIZ='(8UL*1024*1024)' -DFAT_CURSOR -DPCVT_VT220KEYB -DMONO_KERNEL_FG=FG_LIGHTGREY -DPCVT_FREEBSD=210 -DCOM_MULTIPORT -DQUOTA -DIPACCT -DSYSVMSG -DSYSVSEM -DSYSVSHM -DDUMMY_NOPS -DAUTO_EOI_2 -DAUTO_EOI_1 -DCOMPAT_43 -DPROCFS -DCD9660 -DNFS -DFFS -DINET -DKERNEL -Di386 -DLOAD_ADDRESS=0xF0100000  ../../i386/isa/pcvt/pcvt_ext.c
../../i386/isa/pcvt/pcvt_ext.c: In function `wd90c11_col':
../../i386/isa/pcvt/pcvt_ext.c:1213: warning: implicit declaration of function `vga_move_charset'

                 If the definition of vga_move_charset in pcvt_sup.c
		 does not depend on option XSERVER being set, I don't
		 see why the the prototype should depend on that
		 option.

>How-To-Repeat:
See Description.
>Fix:
*** i386/isa/pcvt/pcvt_hdr.h.orig	Thu Sep 14 09:09:49 1995
--- i386/isa/pcvt/pcvt_hdr.h	Fri May 31 14:35:20 1996
***************
*** 1265,1274 ****
  void 	pcvt_set_scrnsv_tmo ( int );
  #endif /* PCVT_SCREENSAVER && defined(XSERVER) */
  
- #ifdef XSERVER
  void	vga_move_charset ( unsigned n, unsigned char *b, int save_it);
- #endif /* XSERVER */
- 
  void	async_update ( int arg );
  void	clr_parms ( struct video_state *svsp );
  void	cons_highlight ( void );
--- 1265,1271 ----
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->joerg 
Responsible-Changed-By: joerg 
Responsible-Changed-When: Sun Jun 2 15:54:18 MET DST 1996 
Responsible-Changed-Why:  
I'm ``Mr. pcvt''. 
State-Changed-From-To: open->closed 
State-Changed-By: joerg 
State-Changed-When: Sun Aug 11 00:18:50 MET DST 1996 
State-Changed-Why:  
All currently open pcvt PRs have been resolved in the following  
files and respective revisions:  

pcvt_conf.h 1.5  
pcvt_drv.c 1.22  
pcvt_hdr.h 1.18  
pcvt_kbd.c 1.11  

(in combination with userconfig.c rev 1.43, regarding the visual  
UserConfig).  

>Unformatted:
 

