From nobody@FreeBSD.org  Sat Sep 13 18:32:27 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 18C1C1065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Sep 2008 18:32:27 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id F41758FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Sep 2008 18:32:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m8DIWQr5058438
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Sep 2008 18:32:26 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m8DIWQKK058437;
	Sat, 13 Sep 2008 18:32:26 GMT
	(envelope-from nobody)
Message-Id: <200809131832.m8DIWQKK058437@www.freebsd.org>
Date: Sat, 13 Sep 2008 18:32:26 GMT
From: Andrew Thompson <thompsa@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: TOE socket options missing from sosetopt()
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         127360
>Category:       kern
>Synopsis:       [socket] TOE socket options missing from sosetopt()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          patched
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 13 18:40:01 UTC 2008
>Closed-Date:    
>Last-Modified:  Sun May 29 22:39:04 UTC 2011
>Originator:     Andrew Thompson
>Release:        
>Organization:
>Environment:
>Description:
the switch at sys/kern/uipc_socket.c:2242 is missing SO_NO_OFFLOAD and SO_NO_DDP

..
 case SO_DEBUG:
 case SO_KEEPALIVE:
 case SO_DONTROUTE:
 case SO_USELOOPBACK:
 case SO_BROADCAST:
 case SO_REUSEADDR:
 case SO_REUSEPORT:
 case SO_OOBINLINE:
 case SO_TIMESTAMP:
 case SO_BINTIME:
 case SO_NOSIGPIPE:
   error = sooptcopyin(sopt, &optval, sizeof optval,
     sizeof optval);
   if (error)
     goto bad;
   SOCK_LOCK(so);
   if (optval)
     so->so_options |= sopt->sopt_name;
   else
     so->so_options &= ~sopt->sopt_name;
   SOCK_UNLOCK(so);
   break;

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->kmacy 
Responsible-Changed-By: thompsa 
Responsible-Changed-When: Sat Sep 13 18:43:11 UTC 2008 
Responsible-Changed-Why:  
Requested by Kip. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127360 
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Sun May 29 22:33:38 UTC 2011 
State-Changed-Why:  
This has been patched (r183963) in HEAD and stable/8.  Somebody who 
knows this code better than I needs to establish if this is worth 
merging to stable/7, and if not, close this PR. 


Responsible-Changed-From-To: kmacy->freebsd-net 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Sun May 29 22:33:38 UTC 2011 
Responsible-Changed-Why:  
kmacy has asked for all of his PRs to be reassigned back to the pool. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127360 
>Unformatted:
