From gary@palmer.demon.co.uk  Mon May 27 14:06:36 1996
Received: from palmer.demon.co.uk (palmer.demon.co.uk [158.152.50.150])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id OAA11996
          for <FreeBSD-gnats-submit@FreeBSD.ORG>; Mon, 27 May 1996 14:06:28 -0700 (PDT)
Received: (from gary@localhost)
	  by palmer.demon.co.uk (sendmail/PALMER-1) id WAA02868;
	  Mon, 27 May 1996 22:06:04 +0100 (BST)
Message-Id: <199605272106.WAA02868@palmer.demon.co.uk>
Date: Mon, 27 May 1996 22:06:04 +0100 (BST)
From: Gary Palmer <gpalmer@FreeBSD.ORG>
Reply-To: gpalmer@freebsd.org
To: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: warnings in pcv
X-Send-Pr-Version: 3.2

>Number:         1265
>Category:       kern
>Synopsis:       warnings in pcv
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    joerg
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 27 14:10:01 PDT 1996
>Closed-Date:    Sun Aug 11 00:18:50 MET DST 1996
>Last-Modified:  Sun Aug 11 00:19:08 MET DST 1996
>Originator:     Gary Palmer
>Release:        FreeBSD 2.1-STABLE i386
>Organization:
None
>Environment:

FreeBSD's current PCVT version

>Description:

If you compile pcvt with -Wunused, you get plenty of warings like:

../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'
../../i386/isa/pcvt/pcvt_drv.c:908: warning: unused variable `x'

This is because pcvt uses an inb() from the keyboard controller in an
attempt to get a delay which is slightly less processor dependant
than DELAY().

Bruce commented:

pcvt should just use DELAY().  DELAY() isn't perfect, but neither is pcvt's
inb() method.

>How-To-Repeat:

Add -Wunused to the kernel Makefile.

>Fix:
	
Move from the inb() to DELAY().

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->joerg 
Responsible-Changed-By: gpalmer 
Responsible-Changed-When: Mon May 27 14:20:04 PDT 1996 
Responsible-Changed-Why:  
Joerg asked that I send-pr this so that he is reminded to do something about 
it when he has time :-) 
State-Changed-From-To: open->closed 
State-Changed-By: joerg 
State-Changed-When: Sun Aug 11 00:18:50 MET DST 1996 
State-Changed-Why:  
All currently open pcvt PRs have been resolved in the following  
files and respective revisions:  

pcvt_conf.h 1.5  
pcvt_drv.c 1.22  
pcvt_hdr.h 1.18  
pcvt_kbd.c 1.11  

(in combination with userconfig.c rev 1.43, regarding the visual  
UserConfig).  

>Unformatted:
 
