From nobody@FreeBSD.org  Wed Jul 30 14:16:18 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D0A61065678
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jul 2008 14:16:18 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 043338FC20
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jul 2008 14:16:18 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m6UEGGsX070468
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jul 2008 14:16:16 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m6UEGGem070467;
	Wed, 30 Jul 2008 14:16:16 GMT
	(envelope-from nobody)
Message-Id: <200807301416.m6UEGGem070467@www.freebsd.org>
Date: Wed, 30 Jul 2008 14:16:16 GMT
From: Anton Kartashev <amokk@seb.org.ua>
To: freebsd-gnats-submit@FreeBSD.org
Subject: uipaq support for ASUS P535 PDA
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         126097
>Category:       kern
>Synopsis:       [uipaq] [patch] add support for ASUS P535 PDA
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 30 14:20:01 UTC 2008
>Closed-Date:    Tue Aug 05 06:42:31 UTC 2008
>Last-Modified:  Tue Aug 05 06:42:31 UTC 2008
>Originator:     Anton Kartashev
>Release:        8-current
>Organization:
>Environment:
FreeBSD my.home 8.0-CURRENT FreeBSD 8.0-CURRENT #15: Wed Jul 30 16:00:15 EEST 2008     root@my.home:/usr/obj/usr/src/sys/GENERIC  i386


>Description:
uipaq module doesn't recognize my ASUS P535 as ucom device. I've add support for them. But it's work only in serial mode (change USB setting to normal at PDA). In RNDIS mode pppd could't connect. 


>How-To-Repeat:

>Fix:
patch for uipaq.c

--- uipaq.c.orig        2008-05-09 00:22:27.000000000 +0300
+++ uipaq.c     2008-07-30 16:34:53.000000000 +0300
@@ -128,6 +128,7 @@
        {{ USB_VENDOR_COMPAQ, USB_PRODUCT_COMPAQ_IPAQPOCKETPC } , 0},
        {{ USB_VENDOR_CASIO, USB_PRODUCT_CASIO_BE300 } , 0},
        {{ USB_VENDOR_SHARP, USB_PRODUCT_SHARP_WZERO3ES }, 0},
+       {{ USB_VENDOR_ASUS, USB_PRODUCT_ASUS_P535 }, 0},
};

#define uipaq_lookup(v, p) ((const struct uipaq_type *)usb_lookup(uipaq_devs, v, p))

patch for usbdevs

--- usbdevs.orig        2008-06-27 13:30:08.000000000 +0300
+++ usbdevs     2008-07-30 16:33:56.000000000 +0300
@@ -877,6 +877,7 @@
product ASUS RT2573_1          0x1723  RT2573
product ASUS RT2573_2          0x1724  RT2573
product ASUS LCM               0x1726  LCM display
+product ASUS P535              0x420f  ASUS P535 PDA

/* ATen products */
product ATEN UC1284            0x2001  Parallel printer

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->freebsd-usb 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Wed Jul 30 15:08:39 UTC 2008 
Responsible-Changed-Why:  
Over to maintainers 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126097 
Responsible-Changed-From-To: freebsd-usb->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Thu Jul 31 09:42:53 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126097 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Sat Aug 2 12:15:45 UTC 2008 
State-Changed-Why:  
patched in current 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126097 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/126097: commit references a PR
Date: Sat,  2 Aug 2008 12:20:47 +0000 (UTC)

 remko       2008-08-02 12:15:18 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/usb          uipaq.c usbdevs 
   Log:
   SVN rev 181163 on 2008-08-02 12:15:18Z by remko
   
   Add support for the ASUS P535 PDA
   
   PR:             kern/126097
   Submitted by:   Anton Kartashev <amokk@seb.org.ua>
   Approved by:    imp (mentor, implicit)
   MFC after:      3 days
   
   Revision  Changes    Path
   1.12      +1 -0      src/sys/dev/usb/uipaq.c
   1.362     +1 -0      src/sys/dev/usb/usbdevs
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/126097: commit references a PR
Date: Tue,  5 Aug 2008 06:38:24 +0000 (UTC)

 remko       2008-08-05 06:37:49 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/dev/usb          uipaq.c usbdevs 
   Log:
   SVN rev 181320 on 2008-08-05 06:37:49Z by remko
   
   MFC r181163
   
     Add support for the ASUS P535 PDA
   
     PR:             kern/126097
     Submitted by:   Anton Kartashev <amokk@seb.org.ua>
     Approved by:    imp (mentor, implicit)
     MFC after:      3 days
   
   Approved by:    imp (mentor, implicit)
   
   Revision    Changes    Path
   1.7.2.2     +1 -0      src/sys/dev/usb/uipaq.c
   1.328.2.14  +1 -0      src/sys/dev/usb/usbdevs
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Tue Aug 5 06:42:29 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=126097 
>Unformatted:
