From nobody@FreeBSD.org  Tue Jul  8 09:44:45 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2A883106567E
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  8 Jul 2008 09:44:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 187A28FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  8 Jul 2008 09:44:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m689iiW7080686
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 8 Jul 2008 09:44:44 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m689iiWg080685;
	Tue, 8 Jul 2008 09:44:44 GMT
	(envelope-from nobody)
Message-Id: <200807080944.m689iiWg080685@www.freebsd.org>
Date: Tue, 8 Jul 2008 09:44:44 GMT
From: Tino Engel <goaengel@gmx.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: QUIRK: USB: scsi_da.c: Samsung YP-U3 1.00
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         125398
>Category:       kern
>Synopsis:       QUIRK: USB: scsi_da.c: Samsung YP-U3 1.00
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 08 09:50:02 UTC 2008
>Closed-Date:    Sat Aug 02 12:47:23 UTC 2008
>Last-Modified:  Sat Aug  2 12:50:03 UTC 2008
>Originator:     Tino Engel
>Release:        FreeBSD 7.0-STABLE i386
>Organization:
n/a
>Environment:
System: FreeBSD freebsdangel.local 7.0-STABLE FreeBSD 7.0-STABLE #10: Mon Jul 7 21:59:00 CEST 2008 elgrande    @freebsdangel.local:/usr/obj/usr/src/sys/elgrande i386
>Description:
   Synchronize cache causes device to hang up

    Contact:
    ========
    goaengel@gmx.net

    camcontrol info:
    ================
    root:/home/elgrande# camcontrol inquiry da0 
    pass0: <Samsung YP-U3 1.00> Removable Direct Access SCSI-2 device 
    pass0: Serial Number E61CFF65EEFF0000
    40.000MB/s transfers 
       
    Failed dmesg:
    =============
    da0 at umass-sim0 bus 0 target 0 lun 0
    da0: <Samsung YP-U3 1.00> Removable Direct Access SCSI-2 device 
    da0: 40.000MB/s transfers
    da0: 3855MB (7895552 512 byte sectors: 255H 63S/T 491C)
    (da0:umass-sim0:0:0:0): Synchronize cache failed, status == 0x4, scsi status == 0x0 
       
    dmesg after quirk:
    ==================
    da0 at umass-sim0 bus 0 target 0 lun 0
    da0: <Samsung YP-U3 1.00> Removable Direct Access SCSI-2 device 
    da0: 40.000MB/s transfers
    da0: 3855MB (7895552 512 byte sectors: 255H 63S/T 491C)

    usbdevs:
    ========
    root:/home/elgrande# usbdevs -v
    Controller /dev/usb0:
    addr 1: full speed, self powered, config 1, OHCI root hub(0x0000), nVidia(0x0000), rev 1.00
     port 1 powered
     port 2 powered
     port 3 powered
     port 4 powered
    Controller /dev/usb1:
    addr 1: full speed, self powered, config 1, OHCI root hub(0x0000), nVidia(0x0000), rev 1.00
     port 1 powered
     port 2 powered
     port 3 powered
     port 4 addr 2: low speed, power 98 mA, config 1, USB-PS/2 Optical Mouse(0xc00e), Logitech(0x046d), rev 11.10
    Controller /dev/usb2:
    addr 1: high speed, self powered, config 1, EHCI root hub(0x0000), nVidia(0x0000), rev 1.00
     port 1 powered
     port 2 powered
     port 3 powered
     port 4 powered
     port 5 addr 2: high speed, power 500 mA, config 1, YP-U3(0x507c), Samsung Electronics(0x04e8), rev 2.20
     port 6 powered
     port 7 powered
     port 8 powered
    root:/home/elgrande#

>How-To-Repeat:
 Attach  Samsung YP-U3 with UMS firmware to usb port (MTP works, but has device ID YP-U3J afaik)
>Fix:
    Added the following quirk to scsi_da.c:

    538     {
    539         /*
    540          * Samsung YP-U3 mp3-player
    541          * PR: tdb
    542          */
    543         {T_DIRECT, SIP_MEDIA_REMOVABLE, "Samsung", "YP-U3",
    544          "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
    545     },


Patch attached with submission follows:

--- scsi_da.c.orig	2008-07-08 11:47:26.000000000 +0200
+++ scsi_da.c	2008-07-07 20:37:38.000000000 +0200
@@ -535,6 +535,14 @@
 		{T_DIRECT, SIP_MEDIA_REMOVABLE, "ChipsBnk", "USB*",
 		 "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
 	},
+	{
+		/*
+		 * Samsung YP-U3 mp3-player
+		 * PR: tdb
+		 */
+		{T_DIRECT, SIP_MEDIA_REMOVABLE, "Samsung", "YP-U3",
+		 "*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
+	},
 };
 
 static	disk_strategy_t	dastrategy;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Wed Jul 9 11:03:07 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125398 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/125398: commit references a PR
Date: Wed,  9 Jul 2008 17:00:32 +0000 (UTC)

 remko       2008-07-09 17:00:14 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/cam/scsi         scsi_da.c 
   Log:
   SVN rev 180389 on 2008-07-09 17:00:14Z by remko
   
   Add quirk for the Samsung YP-U3
   
   PR:             125398
   Submitted by:   Tino Engel <goaengel at gmx dot net>
   Approved by:    imp (mentor, implicit)
   MFC after:      1 week
   
   Revision  Changes    Path
   1.227     +8 -0      src/sys/cam/scsi/scsi_da.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: remko 
State-Changed-When: Sat Aug 2 12:47:22 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=125398 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/125398: commit references a PR
Date: Sat,  2 Aug 2008 12:46:48 +0000 (UTC)

 remko       2008-08-02 12:46:22 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/cam/scsi         scsi_da.c 
   Log:
   SVN rev 181173 on 2008-08-02 12:46:22Z by remko
   
   MFC r180389 (which includes another scsi id as well).
   
     Add quirk for the Samsung YP-U3
   
     PR:             125398
     Submitted by:   Tino Engel <goaengel at gmx dot net>
     Approved by:    imp (mentor, implicit)
     MFC after:      1 week
   
   Approved by:    imp (mentor)
   
   Revision   Changes    Path
   1.224.2.2  +12 -0     src/sys/cam/scsi/scsi_da.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
