From nobody@FreeBSD.org  Wed Jun 18 16:44:59 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8B5C7106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jun 2008 16:44:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 734498FC2A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jun 2008 16:44:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m5IGiwf7093906
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jun 2008 16:44:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m5IGiwDp093905;
	Wed, 18 Jun 2008 16:44:58 GMT
	(envelope-from nobody)
Message-Id: <200806181644.m5IGiwDp093905@www.freebsd.org>
Date: Wed, 18 Jun 2008 16:44:58 GMT
From: Hywel Mallett <Hywel@hmallett.co.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Typo in error message in ggated.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         124723
>Category:       kern
>Synopsis:       [patch] [ggated] Typo in error message in ggated.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gonzo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 18 16:50:01 UTC 2008
>Closed-Date:    Fri Jun 20 22:38:39 UTC 2008
>Last-Modified:  Fri Jun 20 22:38:39 UTC 2008
>Originator:     Hywel Mallett
>Release:        7-RELENG
>Organization:
>Environment:
FreeBSD one.option13.co.uk 7.0-STABLE FreeBSD 7.0-STABLE #0: Sun May  4 19:43:28 BST 2008     hywel@one.option13.co.uk:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
In ggated there is an error message "No enough memory", which should (probably) read "Not enough memory".
>How-To-Repeat:

>Fix:
Patch for src/sbin/ggate/ggated/ggated.c attached


Patch attached with submission follows:

--- /usr/src/sbin/ggate/ggated/ggated.c 2006-12-18 11:12:00.000000000 +0000
+++ ggated.c    2008-06-18 17:39:26.000000000 +0100
@@ -211,10 +211,10 @@

        ex = malloc(sizeof(*ex));
        if (ex == NULL)
-               g_gate_xlog("No enough memory.");
+               g_gate_xlog("Not enough memory.");
        ex->e_path = strdup(path);
        if (ex->e_path == NULL)
-               g_gate_xlog("No enough memory.");
+               g_gate_xlog("Not enough memory.");

        /* Made 'and' here. */
        ex->e_ip = (ip & mask);


>Release-Note:
>Audit-Trail:

From: "Garrett Cooper" <yanefbsd@gmail.com>
To: "Hywel Mallett" <Hywel@hmallett.co.uk>
Cc: bug-followup@freebsd.org
Subject: Re: kern/124723: Typo in error message in ggated.c
Date: Wed, 18 Jun 2008 20:41:15 -0700

 On Wed, Jun 18, 2008 at 9:44 AM, Hywel Mallett <Hywel@hmallett.co.uk> wrote:
 >
 >>Number:         124723
 >>Category:       kern
 >>Synopsis:       Typo in error message in ggated.c
 >>Confidential:   no
 >>Severity:       non-critical
 >>Priority:       low
 >>Responsible:    freebsd-bugs
 >>State:          open
 >>Quarter:
 >>Keywords:
 >>Date-Required:
 >>Class:          sw-bug
 >>Submitter-Id:   current-users
 >>Arrival-Date:   Wed Jun 18 16:50:01 UTC 2008
 >>Closed-Date:
 >>Last-Modified:
 >>Originator:     Hywel Mallett
 >>Release:        7-RELENG
 >>Organization:
 >>Environment:
 > FreeBSD one.option13.co.uk 7.0-STABLE FreeBSD 7.0-STABLE #0: Sun May  4 19:43:28 BST 2008     hywel@one.option13.co.uk:/usr/obj/usr/src/sys/GENERIC  amd64
 >
 >>Description:
 > In ggated there is an error message "No enough memory", which should (probably) read "Not enough memory".
 >>How-To-Repeat:
 >
 >>Fix:
 > Patch for src/sbin/ggate/ggated/ggated.c attached
 >
 >
 > Patch attached with submission follows:
 >
 > --- /usr/src/sbin/ggate/ggated/ggated.c 2006-12-18 11:12:00.000000000 +0000
 > +++ ggated.c    2008-06-18 17:39:26.000000000 +0100
 > @@ -211,10 +211,10 @@
 >
 >        ex = malloc(sizeof(*ex));
 >        if (ex == NULL)
 > -               g_gate_xlog("No enough memory.");
 > +               g_gate_xlog("Not enough memory.");
 >        ex->e_path = strdup(path);
 >        if (ex->e_path == NULL)
 > -               g_gate_xlog("No enough memory.");
 > +               g_gate_xlog("Not enough memory.");
 >
 >        /* Made 'and' here. */
 >        ex->e_ip = (ip & mask);
 
 That error message (IMO) is in and of itself misleading.
 
 strerror(errno) with g_gate_xlog(...) would be a more suitable means
 of denoting the error encountered.
 
 -Garrett
Responsible-Changed-From-To: freebsd-bugs->gonzo 
Responsible-Changed-By: gonzo 
Responsible-Changed-When: Fri Jun 20 21:30:56 UTC 2008 
Responsible-Changed-Why:  
This fruit is hanging really low. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124723 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/124723: commit references a PR
Date: Fri, 20 Jun 2008 21:42:04 +0000 (UTC)

 gonzo       2008-06-20 21:41:44 UTC
 
   FreeBSD src repository
 
   Modified files:
     sbin/ggate/ggated    ggated.c 
   Log:
   SVN rev 179900 on 2008-06-20 21:41:44Z by gonzo
   
   Fix spelling
   
   PR:     kern/124723
   Event:  Bugathon#5
   
   Revision  Changes    Path
   1.10      +2 -2      src/sbin/ggate/ggated/ggated.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: gonzo 
State-Changed-When: Fri Jun 20 22:37:29 UTC 2008 
State-Changed-Why:  
Close PR. It's not worth MFCing. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124723 
>Unformatted:
