From nobody@FreeBSD.org  Mon Apr 21 09:36:07 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AC76C1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Apr 2008 09:36:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 99C5D8FC1D
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Apr 2008 09:36:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3L9Zl27052864
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Apr 2008 09:35:47 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m3L9ZlNF052863;
	Mon, 21 Apr 2008 09:35:47 GMT
	(envelope-from nobody)
Message-Id: <200804210935.m3L9ZlNF052863@www.freebsd.org>
Date: Mon, 21 Apr 2008 09:35:47 GMT
From: Ivan Voras <ivoras@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ath_hal is too verbose when booting
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         122957
>Category:       kern
>Synopsis:       [ath] [patch] ath_hal is too verbose when booting
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 21 09:40:01 UTC 2008
>Closed-Date:    Fri Jan 30 22:43:46 UTC 2009
>Last-Modified:  Fri Jan 30 22:43:46 UTC 2009
>Originator:     Ivan Voras
>Release:        7.x
>Organization:
>Environment:
FreeBSD 7.0-RELEASE
>Description:
ath_hal kernel module is too verbose when booting. It always prints its
banner instead of only when in bootverbose mode.
>How-To-Repeat:
Boot any recent FreeBSD. Observe message:
ath_hal: 0.9.20.3 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413, RF5413)

Drivers shouldn't display their banners when the hardware they support isn't there.
>Fix:
See patch.

Patch attached with submission follows:

--- ath_old/ah_osdep.c	2008-04-18 11:22:53.000000000 +0200
+++ ath/ah_osdep.c	2008-04-18 11:23:48.000000000 +0200
@@ -411,13 +411,15 @@
 
 	switch (type) {
 	case MOD_LOAD:
-		printf("ath_hal: %s (", ath_hal_version);
-		sep = "";
-		for (i = 0; ath_hal_buildopts[i] != NULL; i++) {
-			printf("%s%s", sep, ath_hal_buildopts[i]);
-			sep = ", ";
+		if (bootverbose) {
+			printf("ath_hal: %s (", ath_hal_version);
+			sep = "";
+			for (i = 0; ath_hal_buildopts[i] != NULL; i++) {
+				printf("%s%s", sep, ath_hal_buildopts[i]);
+				sep = ", ";
+			}
+			printf(")\n");
 		}
-		printf(")\n");
 		return 0;
 	case MOD_UNLOAD:
 		return 0;


>Release-Note:
>Audit-Trail:

From: Vladimir Ermakov <samflanker@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/122957: [ath] [patch] ath_hal is too verbose when booting
Date: Mon, 12 May 2008 22:55:44 +0400

 tested on HEAD
 patch work
 please commit
 
 /Vladimir Ermakov
 
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: vwe 
Responsible-Changed-When: Fri Jan 30 22:34:07 UTC 2009 
Responsible-Changed-Why:  

Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122957 
State-Changed-From-To: open->closed 
State-Changed-By: thompsa 
State-Changed-When: Fri Jan 30 22:42:16 UTC 2009 
State-Changed-Why:  
This is needed since the hal is 3rd party in FreeBSD7 and 
below, this no longer applies to current so closing. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122957 
>Unformatted:
