From nobody@FreeBSD.org  Fri Apr 18 03:43:44 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 165611065671
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 18 Apr 2008 03:43:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id EFA028FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 18 Apr 2008 03:43:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3I3hUCE082222
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 18 Apr 2008 03:43:30 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m3I3hU0r082221;
	Fri, 18 Apr 2008 03:43:30 GMT
	(envelope-from nobody)
Message-Id: <200804180343.m3I3hU0r082221@www.freebsd.org>
Date: Fri, 18 Apr 2008 03:43:30 GMT
From: Arthur Hartwig <arthur.hartwig@nokia.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: coretemp driver reports attach failure
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         122878
>Category:       kern
>Synopsis:       [coretemp] [patch] coretemp driver reports attach failure
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rpaulo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 18 03:50:01 UTC 2008
>Closed-Date:    Sun May 11 23:18:33 UTC 2008
>Last-Modified:  Wed May 14 10:10:04 UTC 2008
>Originator:     Arthur Hartwig
>Release:        6.3 & 7.0
>Organization:
Nokia
>Environment:
>Description:
If kernel is built with coretemp driver and run on Celeron M based system a coretemp attach failure is reported.
>How-To-Repeat:

>Fix:
In coretemp_identify() in dev/coretemp/coretemp.c check the cpu supports CPUID 6 before executing CPUID 6:

Change

!       /* Check that CPUID is supported and the vendor is Intel.*/
!       if (cpu_high == 0 || strcmp(cpu_vendor, "GenuineIntel"))
                return;
to
!       /* Check that CPUID 0x06 is supported and the vendor is Intel.*/
!       if (cpu_high < 6 || strcmp(cpu_vendor, "GenuineIntel"))
                return;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->rpaulo 
Responsible-Changed-By: matteo 
Responsible-Changed-When: Sab 10 Mag 2008 20:16:08 UTC 
Responsible-Changed-Why:  
Assign to Rui Paulo as he wrote coretemp(4). Rui, I have a Celeron M and can test patches. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122878 
State-Changed-From-To: open->closed 
State-Changed-By: rpaulo 
State-Changed-When: Sun May 11 23:18:03 UTC 2008 
State-Changed-Why:  
I committed your fix. Thanks a lot for finding the problem! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=122878 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/122878: commit references a PR
Date: Sun, 11 May 2008 23:18:02 +0000 (UTC)

 rpaulo      2008-05-11 23:17:57 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/coretemp     coretemp.c 
   Log:
   Change the check for cpu_high to actually match CPUID 0x06.
   
   Submitted by:   Arthur Hartwig <arthur.hartwig at nokia.com>
   PR:             122878
   MFC after:      3 days
   
   Revision  Changes    Path
   1.7       +3 -3      src/sys/dev/coretemp/coretemp.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/122878: commit references a PR
Date: Wed, 14 May 2008 10:04:21 +0000 (UTC)

 rpaulo      2008-05-14 10:04:16 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/dev/coretemp     coretemp.c 
   Log:
   MFC r1.7:
     Change the check for cpu_high to actually match CPUID 0x06.
   
     Submitted by: Arthur Hartwig <arthur.hartwig at nokia.com>
     PR:           122878
   
   Revision  Changes    Path
   1.2.2.3   +3 -3      src/sys/dev/coretemp/coretemp.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/122878: commit references a PR
Date: Wed, 14 May 2008 10:04:34 +0000 (UTC)

 rpaulo      2008-05-14 10:04:17 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/dev/coretemp     coretemp.c 
   Log:
   MFC r1.7:
     Change the check for cpu_high to actually match CPUID 0x06.
   
     Submitted by: Arthur Hartwig <arthur.hartwig at nokia.com>
     PR:           122878
   
   Revision  Changes    Path
   1.2.4.2   +3 -3      src/sys/dev/coretemp/coretemp.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
