From moore@bricoworks.com Fri Jun 18 12:56:15 1999
Return-Path: <moore@bricoworks.com>
Received: from herschel.bricoworks.com (sense-sea-pm4-5.oz.net [216.39.133.101])
	by hub.freebsd.org (Postfix) with ESMTP id CD28615444
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 18 Jun 1999 12:56:02 -0700 (PDT)
	(envelope-from moore@bricoworks.com)
Received: from ariel.bricoworks.com (ariel [192.168.1.37])
	by herschel.bricoworks.com (8.9.3/8.9.3) with ESMTP id MAA00422
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 18 Jun 1999 12:55:57 -0700 (PDT)
	(envelope-from moore@bricoworks.com)
Received: (from moore@localhost)
	by ariel.bricoworks.com (8.9.3/8.9.2) id MAA00892;
	Fri, 18 Jun 1999 12:51:47 -0700 (PDT)
	(envelope-from moore)
Message-Id: <199906181951.MAA00892@ariel.bricoworks.com>
Date: Fri, 18 Jun 1999 12:51:47 -0700 (PDT)
From: Tim Moore <moore@bricoworks.com>
Reply-To: moore@bricoworks.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: active-filter option in pppd doesn't stop reset of idle timer
X-Send-Pr-Version: 3.2

>Number:         12281
>Category:       kern
>Synopsis:       active-filter option in pppd doesn't stop reset of idle timer
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 18 13:00:01 PDT 1999
>Closed-Date:    Tue Mar 12 01:02:21 PST 2002
>Last-Modified:  Tue Mar 12 01:03:12 PST 2002
>Originator:     Tim Moore
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
Bricoworks
>Environment:

	PPP over dialup modem using pppd and kernel PPP.

>Description:

	The active-filter option of pppd doesn't prevent the idle
timer from being reset when packets that don't match the filter are
received.  The problem is in ppp_inproc in /usr/src/sys/net/if_ppp.c;
sc->sc_last_recv is always set by the PPP_IP and PPP_IPX specific code
even if the packet was rejected by sc->sc_active_filt.

>How-To-Repeat:

I included
demand
idle 300
active-filter '! port ntp'
in my ppp/options file.  The only traffic was ntp traffic.  Although
the link doesn't come up if it's down, it never goes down due to inactivity.

>Fix:
	
Index: if_ppp.c
===================================================================
RCS file: /home/cvs/src/sys/net/if_ppp.c,v
retrieving revision 1.60
diff -u -r1.60 if_ppp.c
--- if_ppp.c	1999/04/27 11:17:00	1.60
+++ if_ppp.c	1999/06/18 19:50:43
@@ -1491,7 +1491,6 @@
 	}
 	schednetisr(NETISR_IP);
 	inq = &ipintrq;
-	sc->sc_last_recv = time_second;	/* update time of last pkt rcvd */
 	break;
 #endif
 #ifdef IPX
@@ -1510,7 +1509,6 @@
 	m->m_len -= PPP_HDRLEN;
 	schednetisr(NETISR_IPX);
 	inq = &ipxintrq;
-	sc->sc_last_recv = time_second;	/* update time of last pkt rcvd */
 	break;
 #endif
 



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: iedowse 
State-Changed-When: Sun Jan 20 10:06:17 PST 2002 
State-Changed-Why:  

Is this problem still present? 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=12281 

From: Ian Dowse <iedowse@maths.tcd.ie>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: kern/12281: active-filter option in pppd doesn't stop reset of idle timer 
Date: Mon, 21 Jan 2002 21:08:54 +0000

 Adding to the audit trial:
 
 In message <Pine.BSF.4.10.10201201647000.5693-100000@herschel.bricoworks.com>, 
 Tim Moore writes:
 >I don't use pppd anymore and don't have a current copy of the sources
 >checked out, so unfortunately I can't comment.
 >
 >Tim
 >
 >On Sun, 20 Jan 2002 iedowse@FreeBSD.org wrote:
 >
 >> Synopsis: active-filter option in pppd doesn't stop reset of idle timer
 >> 
 >> State-Changed-From-To: open->feedback
 >> State-Changed-By: iedowse
 >> State-Changed-When: Sun Jan 20 10:06:17 PST 2002
 >> State-Changed-Why: 
 >> 
 >> Is this problem still present?
 >> 
 >> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=12281
 >> 
 >

From: Sheldon Hearn <sheldonh@starjuice.net>
To: iedowse@FreeBSD.org
Cc: bug-followup@freebsd.org
Subject: Re: kern/12281: active-filter option in pppd doesn't stop reset of idle timer 
Date: Thu, 31 Jan 2002 17:12:13 +0200

 On Sun, 20 Jan 2002 16:47:39 PST, Tim Moore wrote:
 
 > I don't use pppd anymore and don't have a current copy of the sources
 > checked out, so unfortunately I can't comment.
 
 So does this get closed or assigned to Peter?
 
 Ciao,
 Sheldon.
State-Changed-From-To: feedback->analyzed 
State-Changed-By: maxim 
State-Changed-When: Tue Mar 5 02:12:14 PST 2002 
State-Changed-Why:  
I will MFC the fix in one week. 


Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Tue Mar 5 02:12:14 PST 2002 
Responsible-Changed-Why:  
I fixed the bug in -current and will MFC a fix later. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=12281 
State-Changed-From-To: analyzed->closed 
State-Changed-By: maxim 
State-Changed-When: Tue Mar 12 01:02:21 PST 2002 
State-Changed-Why:  
Committed to -current and -stable. Thank you! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=12281 
>Unformatted:
