From nobody@FreeBSD.org  Thu Mar  6 12:23:46 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9F1771065676
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Mar 2008 12:23:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 8D6AB8FC25
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  6 Mar 2008 12:23:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m26CKhtP012738
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 Mar 2008 12:20:43 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m26CKhtZ012737;
	Thu, 6 Mar 2008 12:20:43 GMT
	(envelope-from nobody)
Message-Id: <200803061220.m26CKhtZ012737@www.freebsd.org>
Date: Thu, 6 Mar 2008 12:20:43 GMT
From: Sergey Matveychuk <sem@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: kldload crash system when specified not-file argument (device, etc.)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         121427
>Category:       kern
>Synopsis:       [kernel] [patch] kldload crash system when specified not-file argument (device, etc.)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ru
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 06 12:30:00 UTC 2008
>Closed-Date:    Tue Mar 18 11:49:55 UTC 2008
>Last-Modified:  Fri Sep  5 17:10:01 UTC 2008
>Originator:     Sergey Matveychuk
>Release:        7.0-STABLE
>Organization:
Yandex LLC
>Environment:
FreeBSD purple.yandex.net 7.0-STABLE FreeBSD 7.0-STABLE #6: Thu Mar  6 12:05:52 MSK 2008     root@purple.yandex.net:/usr/obj/usr/src/sys/PURPLE  i386
>Description:
Kernel is crashed if you specify a device name instead of a file name for kldload.
A code for checking is present but did not call is a full path name specified.
>How-To-Repeat:
kldload /dev/null
>Fix:


Patch attached with submission follows:

--- sys/kern/kern_linker.c.orig	2008-03-06 11:56:15.000000000 +0300
+++ sys/kern/kern_linker.c	2008-03-06 12:05:04.000000000 +0300
@@ -1704,8 +1704,10 @@
 	int len;
 
 	/* qualified at all? */
-	if (index(name, '/'))
-		return (linker_strdup(name));
+	if ((cp = index(name, '/')) != NULL) {
+	    	len = strlen(++cp);
+		return (linker_lookup_file(name, cp - name, cp, len, NULL));
+	}
 
 	/* traverse the linker path */
 	len = strlen(name);


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: ru 
State-Changed-When: Thu Mar 6 16:23:11 UTC 2008 
State-Changed-Why:  
Have sent a different patch to Sergey. 


Responsible-Changed-From-To: freebsd-bugs->ru 
Responsible-Changed-By: ru 
Responsible-Changed-When: Thu Mar 6 16:23:11 UTC 2008 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=121427 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/121427: commit references a PR
Date: Sat, 15 Mar 2008 17:40:23 +0000 (UTC)

 ru          2008-03-15 17:40:18 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/kern             link_elf.c link_elf_obj.c 
   Log:
   Fix panic on e.g. "kldload /dev/null".
   
   PR:             kern/121427
   Reviewed by:    sem
   MFC after:      3 days
   
   Revision  Changes    Path
   1.96      +5 -0      src/sys/kern/link_elf.c
   1.98      +4 -0      src/sys/kern/link_elf_obj.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: ru 
State-Changed-When: Tue Mar 18 11:49:25 UTC 2008 
State-Changed-Why:  
Fixed in 8.0-CURRENT and 7.0-STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121427 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/121427: commit references a PR
Date: Tue, 18 Mar 2008 11:49:17 +0000 (UTC)

 ru          2008-03-18 11:49:11 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/kern             link_elf.c link_elf_obj.c 
   Log:
   MFC: Fix panic on e.g. "kldload /dev/null".
   
   PR:             kern/121427
   
   Revision  Changes    Path
   1.93.2.1  +5 -0      src/sys/kern/link_elf.c
   1.95.2.1  +4 -0      src/sys/kern/link_elf_obj.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/121427: commit references a PR
Date: Fri,  5 Sep 2008 17:03:37 +0000 (UTC)

 emaste      2008-09-05 17:03:10 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/kern             link_elf.c link_elf_obj.c 
   Log:
   SVN rev 182794 on 2008-09-05 17:03:10Z by emaste
   
   MFC r177228:
   
     Fix panic on e.g. "kldload /dev/null".
   
   PR:             kern/121427
   Approved by:    re
   
   Revision  Changes    Path
   1.81.8.8  +5 -0      src/sys/kern/link_elf.c
   1.87.2.7  +4 -0      src/sys/kern/link_elf_obj.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
