From nobody@FreeBSD.org  Wed Feb 13 00:36:29 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E342F16A469
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Feb 2008 00:36:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id D807C13C467
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Feb 2008 00:36:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m1D0YDt7086481
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 13 Feb 2008 00:34:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m1D0YDBf086480;
	Wed, 13 Feb 2008 00:34:13 GMT
	(envelope-from nobody)
Message-Id: <200802130034.m1D0YDBf086480@www.freebsd.org>
Date: Wed, 13 Feb 2008 00:34:13 GMT
From: Ighighi <ighighi@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: TCP_DROP_SYNFIN isn't at all gone on 6.3 and RELENG_6
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         120587
>Category:       kern
>Synopsis:       TCP_DROP_SYNFIN isn't at all gone on 6.3 and RELENG_6
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 13 00:40:02 UTC 2008
>Closed-Date:    Tue Feb 26 10:30:42 UTC 2008
>Last-Modified:  Tue Feb 26 11:50:04 UTC 2008
>Originator:     Ighighi
>Release:        6.3-STABLE
>Organization:
>Environment:
FreeBSD orion 6.3-STABLE FreeBSD 6.3-STABLE #0: Tue Feb 12 10:18:06 VET 2008     root@orion.nebula.mil:/usr/obj/usr/src/sys/CUSTOM  i386
>Description:
According to the CVS log of rc.conf(5), TCP_DROP_SYNFIN is no longer
needed for setting tcp_drop_synfin.  It is not the case...

Quoting:
http://www.FreeBSD.org/cgi/cvsweb.cgi/src/share/man/man5/rc.conf.5?only_with_tag=RELENG_6

"MFC rev. 1.322 rc.conf, rev. 1.332 rc.conf.5: TCP_DROP_SYNFIN has gone"
>How-To-Repeat:
$ fgrep -r TCP_DROP_SYNFIN /usr/src/sys
/usr/src/sys/conf/NOTES:# TCP_DROP_SYNFIN adds support for ignoring TCP packets with SYN+FIN. This
/usr/src/sys/conf/NOTES:options         TCP_DROP_SYNFIN         #drop TCP packets with SYN+FIN
/usr/src/sys/conf/options:TCP_DROP_SYNFIN               opt_tcp_input.h
/usr/src/sys/netinet/tcp_input.c:#ifdef TCP_DROP_SYNFIN
/usr/src/sys/netinet/tcp_input.c:#ifdef TCP_DROP_SYNFIN

>Fix:
Either undo the changes to rc.conf(5) on RELENG_6 or truly drop TCP_DROP_SYNFIN

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Wed Feb 13 06:15:47 UTC 2008 
Responsible-Changed-Why:  
Over to me. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120587 
State-Changed-From-To: open->closed 
State-Changed-By: maxim 
State-Changed-When: Tue Feb 26 10:30:27 UTC 2008 
State-Changed-Why:  
Fixed.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120587 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/120587: commit references a PR
Date: Tue, 26 Feb 2008 11:47:20 +0000 (UTC)

 maxim       2008-02-26 10:30:19 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     etc/defaults         rc.conf 
     share/man/man5       rc.conf.5 
   Log:
   o Backout rev. 1.252.2.39 rc.conf and rev. 1.256.2.35 rc.conf.5:
   there is TCP_DROP_SYNFIN in RELENG_6 still.
   
   PR:             kern/120587
   
   Revision    Changes    Path
   1.252.2.43  +2 -0      src/etc/defaults/rc.conf
   1.256.2.36  +5 -1      src/share/man/man5/rc.conf.5
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
