From nobody@FreeBSD.org  Thu Feb  7 10:30:49 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2251416A468
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  7 Feb 2008 10:30:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0303013C4EE
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  7 Feb 2008 10:30:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m17ASi5N086272
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 7 Feb 2008 10:28:44 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m17ASiVU086261;
	Thu, 7 Feb 2008 10:28:44 GMT
	(envelope-from nobody)
Message-Id: <200802071028.m17ASiVU086261@www.freebsd.org>
Date: Thu, 7 Feb 2008 10:28:44 GMT
From: CyberLeo <cyberleo@cyberleo.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: twe pci parity error printf lacks terminating newline
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         120341
>Category:       kern
>Synopsis:       [twe] [patch] twe pci parity error printf lacks terminating newline
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 07 10:40:01 UTC 2008
>Closed-Date:    Thu Feb 14 21:53:21 CET 2008
>Last-Modified:  Thu Feb 14 21:53:21 CET 2008
>Originator:     CyberLeo
>Release:        RELENG_6_3
>Organization:
CyberLeo.Net
>Environment:
FreeBSD mtumishi.cyberleo.net 6.3-RELEASE FreeBSD 6.3-RELEASE #2: Sat Jan 19 02:11:12 PST 2008     cyberleo@mtumishi.cyberleo.net:/usr/obj/usr/src/sys/MTUMISHI  i386
>Description:
twe(4) driver printf for TWE_STATUS_PCI_PARITY_ERROR message lacks
terminating newline.

Confirmed in CURRENT and 6x/7x branches.
>How-To-Repeat:
Use a 3ware card, cause a PCI parity error, watch dmesg or console log.
>Fix:
Apply the included patch.

Patch attached with submission follows:

--- sys/dev/twe/twe.c-orig	Thu Feb  7 03:35:02 2008
+++ sys/dev/twe/twe.c	Thu Feb  7 03:35:22 2008
@@ -1696,7 +1696,7 @@
 	}
 	result = 1;
 	if (status_reg & TWE_STATUS_PCI_PARITY_ERROR) {
-	    twe_printf(sc, "PCI parity error: Reseat card, move card or buggy device present.");
+	    twe_printf(sc, "PCI parity error: Reseat card, move card or buggy device present.\n");
 	    twe_clear_pci_parity_error(sc);
 	}
 	if (status_reg & TWE_STATUS_PCI_ABORT) {


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Tue Feb 12 09:58:35 CET 2008 
State-Changed-Why:  
Committed to HEAD, MFC pending. 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Tue Feb 12 09:58:35 CET 2008 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120341 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/120341: commit references a PR
Date: Tue, 12 Feb 2008 08:58:32 +0000 (UTC)

 brueffer    2008-02-12 08:58:26 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/twe          twe.c 
   Log:
   Add missing \n.
   
   PR:             120341
   Submitted by:   CyberLeo <cyberleo@cyberleo.net>
   Approved by:    rwatson (mentor), aradford@amcc.com
   MFC after:      3 days
   
   Revision  Changes    Path
   1.26      +1 -1      src/sys/dev/twe/twe.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Thu Feb 14 21:53:03 CET 2008 
State-Changed-Why:  
All MFCs done.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120341 
>Unformatted:
