From nobody@FreeBSD.org  Tue Feb  5 00:50:33 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6933E16A420
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  5 Feb 2008 00:50:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 5CB7513C45A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  5 Feb 2008 00:50:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m150mXl3071466
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 5 Feb 2008 00:48:33 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m150mXa9071465;
	Tue, 5 Feb 2008 00:48:33 GMT
	(envelope-from nobody)
Message-Id: <200802050048.m150mXa9071465@www.freebsd.org>
Date: Tue, 5 Feb 2008 00:48:33 GMT
From: chargen <chargen@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [cryptotools] [patch] minor patches to cryptotools
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         120274
>Category:       kern
>Synopsis:       [cryptotools] [patch] minor patches to cryptotools
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    matteo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 05 01:00:06 UTC 2008
>Closed-Date:    Mon Mar 31 11:03:42 UTC 2008
>Last-Modified:  Mon Mar 31 11:03:42 UTC 2008
>Originator:     chargen
>Release:        7.0-PRERELEASE
>Organization:
none
>Environment:
FreeBSD packetstorm 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #0: Sun Feb  3 01:06:38 CET 2008     root@packetstorm:/usr/src/sys/i386/compile/PACKETSTORM  i386

>Description:
minor cleanups in /src/tools/tools/crypto/ in order to avoid some
unnecessary compiler errors 

gcc -v
Using built-in specs.
Target: i386-undermydesk-freebsd
Configured with: FreeBSD/i386 system compiler
Thread model: posix
gcc version 4.2.1 20070719  [FreeBSD]



>How-To-Repeat:

>Fix:
patches included

Patch attached with submission follows:

--- /usr/src/tools/tools/crypto/cryptotest.c    2007-03-21 04:42:51.000000000 +0100
+++ cryptotest.c        2008-02-05 01:36:02.000000000 +0100
@@ -93,6 +93,7 @@
 #include <sys/mman.h>
 #include <paths.h>
 #include <stdlib.h>
+#include <string.h>

 #include <sys/sysctl.h>
 #include <sys/time.h>

--- /usr/src/tools/tools/crypto/cryptostats.c   2003-03-19 02:53:55.000000000 +0100
+++ cryptostats.c       2008-02-05 01:36:05.000000000 +0100
@@ -32,6 +32,9 @@
  */
 #include <stdio.h>

+#include <stdlib.h>
+#include <string.h>
+
 #include <sys/types.h>
 #include <sys/sysctl.h>
 #include <sys/time.h>
@@ -58,7 +61,7 @@
        size_t slen;

        slen = sizeof (stats);
-       if (sysctlbyname("kern.crypto_stats", &stats, &slen, NULL, NULL) < 0)
+       if (sysctlbyname("kern.crypto_stats", &stats, &slen, NULL, sizeof(NULL)) < 0)
                err(1, "kern.cryptostats");

        if (argc > 1 && strcmp(argv[1], "-z") == 0) {




>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->matteo 
Responsible-Changed-By: matteo 
Responsible-Changed-When: Mar 5 Feb 2008 08:05:42 UTC 
Responsible-Changed-Why:  
I'm going to commit the fix 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120274 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/120274: commit references a PR
Date: Tue,  5 Feb 2008 08:07:26 +0000 (UTC)

 matteo      2008-02-05 08:07:19 UTC
 
   FreeBSD src repository
 
   Modified files:
     tools/tools/crypto   cryptostats.c cryptotest.c 
   Log:
   Add missing includes and correct argument to sysctlbyname
   
   PR:             misc/120274
   MFC after:      1 week
   
   Revision  Changes    Path
   1.3       +3 -1      src/tools/tools/crypto/cryptostats.c
   1.10      +1 -0      src/tools/tools/crypto/cryptotest.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: matteo 
State-Changed-When: Mar 5 Feb 2008 08:13:20 UTC 
State-Changed-Why:  
Fix committed to HEAD. MFC coming in a week 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120274 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/120274: commit references a PR
Date: Mon, 31 Mar 2008 06:49:09 +0000 (UTC)

 matteo      2008-03-31 06:49:03 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     tools/tools/crypto   cryptostats.c cryptotest.c 
   Log:
   MFC rev. 1.10 of cryptotest.c and rev. 1.3 of cryptostats.c
   
           Add missing includes and correct argument to sysctlbyname
   
   PR:     misc/120274
   
   Revision  Changes    Path
   1.2.22.1  +3 -1      src/tools/tools/crypto/cryptostats.c
   1.9.2.1   +1 -0      src/tools/tools/crypto/cryptotest.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: matteo 
State-Changed-When: Lun 31 Mar 2008 11:03:27 UTC 
State-Changed-Why:  
MFC'ed to RELENG_7 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120274 
>Unformatted:
