From archon@forbidden.dough.net Thu Jun  3 18:31:21 1999
Return-Path: <archon@forbidden.dough.net>
Received: from forbidden.dough.net (forbidden.dough.net [208.24.140.67])
	by hub.freebsd.org (Postfix) with ESMTP id 1A61315A56
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Jun 1999 18:31:18 -0700 (PDT)
	(envelope-from archon@forbidden.dough.net)
Received: (from root@localhost)
	by forbidden.dough.net (8.9.3/8.9.3) id UAA21494;
	Thu, 3 Jun 1999 20:35:22 -0500 (CDT)
	(envelope-from archon)
Message-Id: <199906040135.UAA21494@forbidden.dough.net>
Date: Thu, 3 Jun 1999 20:35:22 -0500 (CDT)
From: archon@forbidden.dough.net
Reply-To: archon@forbidden.dough.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: no quirk for Nakamichi cd changer
X-Send-Pr-Version: 3.2

>Number:         12017
>Category:       kern
>Synopsis:       no quirk for Nakamichi cd changer
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ken
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun  3 18:40:00 PDT 1999
>Closed-Date:    Thu Jun 3 22:55:18 PDT 1999
>Last-Modified:  Thu Jun  3 22:57:39 PDT 1999
>Originator:     Dennis Moore
>Release:        FreeBSD 3.2-RELEASE i386
>Organization:
Forbidden DoughNet Enterprises
>Environment:

cd1: <NAKAMICH MJ-5.16S 1.07> Removable CD-ROM SCSI-2 device 
cd1: 10.000MB/s transfers (10.000MHz, offset 15)
cd1: cd present [302895 x 2048 byte records]


>Description:

No quirk for this cd-changer device.
http://www.nakamichi.com/computer/mj5_16spec.htm

>How-To-Repeat:

	N/A

>Fix:
	
patch to sys/cam/scsi/scsi_cd.c

*** scsi_cd.c.orig	Thu Jun  3 20:15:11 1999
--- scsi_cd.c	Thu Jun  3 20:20:02 1999
***************
*** 166,171 ****
--- 166,175 ----
  	{
  		{ T_CDROM, SIP_MEDIA_REMOVABLE, "CHINON", "CD-ROM CDS-535","*"},
  		/* quirks */ CD_Q_BCD_TRACKS
+ 	},
+ 	{
+ 		{ _CDROM, SIP_MEDIA_REMOVABLE, "NAKAMICH", "MJ-5.16S" , "*"},
+ 		/* quirks */ CD_Q_CHANGER
  	}
  };
  

>Release-Note:
>Audit-Trail:

From: "Kenneth D. Merry" <ken@plutotech.com>
To: archon@forbidden.dough.net
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: kern/12017: no quirk for Nakamichi cd changer
Date: Thu, 3 Jun 1999 21:00:42 -0600 (MDT)

 archon@forbidden.dough.net wrote...
 > 
 > >Number:         12017
 > >Category:       kern
 > >Synopsis:       no quirk for Nakamichi cd changer
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       medium
 > >Responsible:    freebsd-bugs
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          change-request
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Thu Jun  3 18:40:00 PDT 1999
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Dennis Moore
 > >Release:        FreeBSD 3.2-RELEASE i386
 > >Organization:
 > Forbidden DoughNet Enterprises
 > >Environment:
 > 
 > cd1: <NAKAMICH MJ-5.16S 1.07> Removable CD-ROM SCSI-2 device 
 > cd1: 10.000MB/s transfers (10.000MHz, offset 15)
 > cd1: cd present [302895 x 2048 byte records]
 > 
 > 
 > >Description:
 > 
 > No quirk for this cd-changer device.
 > http://www.nakamichi.com/computer/mj5_16spec.htm
 
 You shouldn't need a quirk entry, as the comment above the quirk table
 says:
 
 /*      
  * These quirk entries aren't strictly necessary.  Basically, what they do
  * is tell cdregister() up front that a device is a changer.  Otherwise, it
  * will figure that fact out once it sees a LUN on the device that is
  * greater than 0.  If it is known up front that a device is a changer, all
  * I/O to the device will go through the changer scheduling routines, as
  * opposed to the "normal" CD code.
  */     
 
 Does your drive function properly without the quirk entry?
 
 Ken
 -- 
 Kenneth Merry
 ken@plutotech.com
 
State-Changed-From-To: open->closed 
State-Changed-By: ken 
State-Changed-When: Thu Jun 3 22:55:18 PDT 1999 
State-Changed-Why:  
No quirk entry is necessary for the CD driver to detect that this device 
is a changer.  After corresponding with the PR submitter, it appears that 
the driver is functioning properly. 
If the submitter still has problems, we can re-open this PR or file a 
new one. 


Responsible-Changed-From-To: freebsd-bugs->ken 
Responsible-Changed-By: ken 
Responsible-Changed-When: Thu Jun 3 22:55:18 PDT 1999 
Responsible-Changed-Why:  
My driver. 
>Unformatted:
