From nobody@FreeBSD.org  Thu Jan 24 16:39:46 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8A56F16A41A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Jan 2008 16:39:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 45F4A13C44B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Jan 2008 16:39:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m0OGcA8C021254
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Jan 2008 16:38:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m0OGcAvt021253;
	Thu, 24 Jan 2008 16:38:10 GMT
	(envelope-from nobody)
Message-Id: <200801241638.m0OGcAvt021253@www.freebsd.org>
Date: Thu, 24 Jan 2008 16:38:10 GMT
From: "Y.Okabe" <be_works_us@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: rum device in hostap mode, cause kernel core dump.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         119945
>Category:       kern
>Synopsis:       [rum] [panic] rum device in hostap mode, cause kernel core dump.
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-net
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 24 16:40:02 UTC 2008
>Closed-Date:    
>Last-Modified:  Fri Feb 22 12:09:35 UTC 2008
>Originator:     Y.Okabe
>Release:        7.0-PRERELEASE
>Organization:
>Environment:
FreeBSD 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE

CPU: VIA C7 Esther+RNG+AES+AES-CTR+SHA1+SHA256+RSA (1500.00-MHz 686-class CPU)
Origin = "CentaurHauls" Id = 0x6d0 Stepping = 0
Features=0xa7c9bbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,CMOV,PAT,CLFLUSH,ACPI,MMX,FXSR,SSE,SSE2,TM,PBE>
Features2=0x4181<SSE3,EST,TM2,xTPR>

dmesg follow:

uhub4: <VIA EHCI root hub, class 9/0, rev 2.00/1.00, addr 1> on usb4
uhub4: 8 ports with 8 removable, self powered
rum0: <buffalo WLI-U2-SG54HP, class 0/0, rev 2.00/0.01, addr 2> on uhub4
rum0: MAC/BBP RT2573 (rev 0x2573a), RF RT2528
rum0: Ethernet address: 00:16:xx:xx:xx:xx
rum0: if_start running deferred for Giant

 
>Description:
I made rum device into hostap mode. 
When receive some packet by rum device,
kernel was panic and core dumped at module uhci.ko.

>How-To-Repeat:
1. install GENERIC kernel for RENENG_7,
2. configure hostapd using rum0.
3. setup rum0 and wired lan ingerface bridge
   i.e. run ifconfig bridge0 create
        run ifconfig bridge0 addm rum0 addm eth0
        run ifconfig bridge0 inet 192.168.1.9/24
4. run hostapd.
5. accsess wlan client this hostap accces point
    (by WPA-PSK, WPA-AES, WPA2-AES, etc...) 
6. some packet send, kernel panic.
>Fix:
rum_free_tx_list function on if_rum.c , at the OpenBSD current source  is

--------------- openbsd if_rum.c start --------------------------------
void
rum_free_tx_list(struct rum_softc *sc)
{
	int i;

	for (i = 0; i < RUM_TX_LIST_COUNT; i++) {
		struct rum_tx_data *data = &sc->tx_data[i];

		if (data->xfer != NULL) {
			usbd_free_xfer(data->xfer);
			data->xfer = NULL;
		}
		/*
		 * The node has already been freed at that point so don't call
		 * ieee80211_release_node() here.
		 */
		data->ni = NULL;
	}
}
--------------- openbsd if_rum.c end --------------------------------



therefor, freebsd's rum_free_tx_list function at if_rum.c 
/usr/src/sys/dev/usb/if_rum.c at line 650

static void
rum_free_tx_list(struct rum_softc *sc)
{
	struct rum_tx_data *data;
	int i;

	for (i = 0; i < RUM_TX_LIST_COUNT; i++) {
		data = &sc->tx_data[i];

		if (data->xfer != NULL) {
			usbd_free_xfer(data->xfer);
			data->xfer = NULL;
		}

		if (data->ni != NULL) {
-			ieee80211_free_node(data->ni);
+                       /*ieee80211_free_node(data->ni);*/
			data->ni = NULL;
		}
	}
}

--------------------------------------------------------------------

I don't know this patch's work reason.

but, hostapd can work at patched kernel.



>Release-Note:
>Audit-Trail:

From: Alexey Popov <a_popov@rbc.ru>
To: bug-followup@FreeBSD.org,  be_works_us@yahoo.com
Cc:  
Subject: Re: usb/119945: rum device in hostap mode, cause kernel core dump.
Date: Fri, 25 Jan 2008 12:21:24 +0300

 Hi
 
 This is exactly the same bug as to usb/92083, usb/101096 and the last part of 
 kern/117820.
 
 The main question is whether it is enough to check data->ni to be not NULL or
 to completely remove ieee80211_free_node() call from (rum|ral)_txeof(). Do I 
 understand correct that adding this check does not work for you?
 
 Can anyone shed some light on this issue?
 
 With best regards,
 Alexey Popov
Responsible-Changed-From-To: freebsd-usb->freebsd-net 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Fri Feb 22 12:08:13 UTC 2008 
Responsible-Changed-Why:  
To me, this looks like it might be a -net problem, rather than -usb 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119945 
>Unformatted:
