From antoine@peanut.dreadbsd.org  Sat Jan 12 16:51:02 2008
Return-Path: <antoine@peanut.dreadbsd.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1741316A41A
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Jan 2008 16:51:02 +0000 (UTC)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: from peanut.dreadbsd.org (peanut.dreadbsd.org [82.67.196.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 611F813C442
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Jan 2008 16:51:00 +0000 (UTC)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: from peanut.dreadbsd.org (localhost [127.0.0.1])
	by peanut.dreadbsd.org (8.14.2/8.14.2) with ESMTP id m0CGolVL034860
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Jan 2008 17:50:47 +0100 (CET)
	(envelope-from antoine@peanut.dreadbsd.org)
Received: (from antoine@localhost)
	by peanut.dreadbsd.org (8.14.2/8.14.2/Submit) id m0CGolJv034859;
	Sat, 12 Jan 2008 17:50:47 +0100 (CET)
	(envelope-from antoine)
Message-Id: <200801121650.m0CGolJv034859@peanut.dreadbsd.org>
Date: Sat, 12 Jan 2008 17:50:47 +0100 (CET)
From: Antoine Brodin <antoine.brodin@laposte.net>
Reply-To: Antoine Brodin <antoine.brodin@laposte.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] remove superfluous line in sys/kern/subr_autoconf.c
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         119604
>Category:       kern
>Synopsis:       [kernel] [patch] remove superfluous line in sys/kern/subr_autoconf.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    antoine
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 12 17:00:00 UTC 2008
>Closed-Date:    Mon Mar 17 19:01:08 UTC 2008
>Last-Modified:  Mon Mar 17 19:01:08 UTC 2008
>Originator:     Antoine Brodin
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
none
>Environment:
System: FreeBSD barton.dreadbsd.org. 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sun Jan 6 15:52:17 CET 2008 root@barton.dreadbsd.org.:/usr/obj/usr/src/sys/BARTON i386


>Description:
There is a superfluous line in sys/kern/subr_autoconf.c:run_interrupt_driven_config_hooks
The "next_entry = TAILQ_NEXT(hook_entry, ich_links);" is not necessary
since TAILQ_FOREACH_SAFE is used.
>How-To-Repeat:
>Fix:


--- subr_autoconf.c.diff begins here ---
Index: subr_autoconf.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/subr_autoconf.c,v
retrieving revision 1.23
diff -u -p -r1.23 subr_autoconf.c
--- subr_autoconf.c	19 Jul 2006 18:53:56 -0000	1.23
+++ subr_autoconf.c	30 Dec 2007 19:39:36 -0000
@@ -67,7 +67,6 @@ run_interrupt_driven_config_hooks(dummy)
 	mtx_lock(&intr_config_hook_lock);
 	TAILQ_FOREACH_SAFE(hook_entry, &intr_config_hook_list, ich_links,
 	    next_entry) {
-		next_entry = TAILQ_NEXT(hook_entry, ich_links);
 		mtx_unlock(&intr_config_hook_lock);
 		(*hook_entry->ich_func)(hook_entry->ich_arg);
 		mtx_lock(&intr_config_hook_lock);
--- subr_autoconf.c.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->antoine 
Responsible-Changed-By: antoine 
Responsible-Changed-When: Sun Feb 10 19:15:29 UTC 2008 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119604 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/119604: commit references a PR
Date: Fri, 15 Feb 2008 21:54:27 +0000 (UTC)

 antoine     2008-02-15 21:54:21 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/kern             subr_autoconf.c 
   Log:
   Remove a superfluous line in run_interrupt_driven_config_hooks(),
   next_entry is already initialized during TAILQ_FOREACH_SAFE().
   
   PR:             kern/119604
   Approved by:    rwatson (mentor)
   MFC after:      1 month
   
   Revision  Changes    Path
   1.24      +0 -1      src/sys/kern/subr_autoconf.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: antoine 
State-Changed-When: Fri Feb 15 22:04:53 UTC 2008 
State-Changed-Why:  
Patched in revision 1.24 of srs/sys/kern/subr_autoconf.c 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119604 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/119604: commit references a PR
Date: Mon, 17 Mar 2008 18:57:16 +0000 (UTC)

 antoine     2008-03-17 18:57:07 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/kern             subr_autoconf.c 
   Log:
   MFC to RELENG_7
     Remove a superfluous line in run_interrupt_driven_config_hooks(),
     next_entry is already initialized during TAILQ_FOREACH_SAFE().
   
     PR:             kern/119604
     Approved by:    rwatson (mentor)
     MFC after:      1 month
   
   Revision  Changes    Path
   1.23.2.1  +0 -1      src/sys/kern/subr_autoconf.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: antoine 
State-Changed-When: Mon Mar 17 19:00:25 UTC 2008 
State-Changed-Why:  
Close: committed in HEAD and RELENG_7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119604 
>Unformatted:
