From jhs@berklix.org  Thu Jan  3 13:47:17 2008
Return-Path: <jhs@berklix.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5EC5316A419;
	Thu,  3 Jan 2008 13:47:17 +0000 (UTC)
	(envelope-from jhs@berklix.org)
Received: from tower.berklix.org (tower.berklix.org [83.236.223.114])
	by mx1.freebsd.org (Postfix) with ESMTP id B1A2813C4E9;
	Thu,  3 Jan 2008 13:47:15 +0000 (UTC)
	(envelope-from jhs@berklix.org)
Received: from js.berklix.net (p549A79DF.dip.t-dialin.net [84.154.121.223])
	(authenticated bits=0)
	by tower.berklix.org (8.13.6/8.13.6) with ESMTP id m03DlCYW088151;
	Thu, 3 Jan 2008 13:47:13 GMT
	(envelope-from jhs@berklix.org)
Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41])
	by js.berklix.net (8.13.8/8.13.8) with ESMTP id m03DmNAa091306;
	Thu, 3 Jan 2008 14:48:23 +0100 (CET)
	(envelope-from jhs@berklix.org)
Received: from fire.js.berklix.net (localhost.js.berklix.net [127.0.0.1])
	by fire.js.berklix.net (8.13.8/8.13.8) with ESMTP id m03DmDH9092209;
	Thu, 3 Jan 2008 14:48:13 +0100 (CET)
	(envelope-from jhs@fire.js.berklix.net)
Received: (from jhs@localhost)
	by fire.js.berklix.net (8.13.8/8.13.8/Submit) id m03Dm3dg092208;
	Thu, 3 Jan 2008 14:48:03 +0100 (CET)
	(envelope-from jhs)
Message-Id: <200801031348.m03Dm3dg092208@fire.js.berklix.net>
Date: Thu, 3 Jan 2008 14:48:03 +0100 (CET)
From: "Julian H. Stacey" <jhs@berklix.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: "Julian H. Stacey" <jhs@berklix.com>, freebsd-stable@freebsd.org
Subject: 7-Stable/sys/modules/xfs fails to make from world
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         119298
>Category:       kern
>Synopsis:       [xfs] [patch] 7-Stable/sys/modules/xfs fails to make from world
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 03 13:50:01 UTC 2008
>Closed-Date:    Fri Mar 15 23:34:42 UTC 2013
>Last-Modified:  Fri Mar 15 23:34:42 UTC 2013
>Originator:     Julian H. Stacey <jhs@berklix.com>
>Release:        FreeBSD 7.0-PRERELEASE i386
>Organization:
http://berklix.com
>Environment:
System: FreeBSD lapn.js.berklix.net 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #0: Mon Dec 31 19:01:25 CET 2007     jhs@lapn.js.berklix.net:/usr/src/sys/i386/compile/GENERIC  i386

	
>Description:
	
7-Stable/sys/modules/xfs fails to make from world
Been like that a few days (while my slow host made world) as:
 It's now Thu Jan  3 12:54:35 CET 2008,
 & from CTM delta dates of reception 
  (& Yes acknowledging ctm is Push whereas cvsup is Pull, 
   so a delay of maybe 12/24 hours).
Bad between src-7.0075 & src-7.0077.
 Dec 30 12:12 /pub/FreeBSD/development/CTM/src-7/src-7.0075.gz
 Jan  1 10:52 /pub/FreeBSD/development/CTM/src-7/src-7.0076.gz
 Jan  2 08:49 /pub/FreeBSD/development/CTM/src-7/src-7.0077.gz

With a src/ based on src-7.0075
 cd /usr/src  ; make world # ...
  ===> sys/modules/xfs (depend)
  @ -> /usr/src/sys
  machine -> /usr/src/sys/i386/include
  awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -p
  awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -q
  awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -h
  make: don't know how to make xfsrtstubs.c. Stop
  *** Error code 2
  Stop in /usr/src/sys/modules.
 find . -name xfsrtstubs.c	# Nothing
 # UPDATE ...
 ctm -v /pub/FreeBSD/development/CTM/src-7/src-7.0.gz
 cd /sys/modules/xfs ; make clean ; make # Still Fails
 # Also fails on another 7.0-PRERELEASE host (though that hasnt gone through 
 # the rigour of a make world.

>How-To-Repeat:
	make world on stable-7
>Fix:

	


*** 7.0-PRERELEASE-src-7.0077/src/sys/modules/xfs/Makefile.o	Thu Jan  3 12:38:06 2008
.--- new/src/sys/modules/xfs/Makefile	Thu Jan  3 12:43:32 2008
***************
*** 54,62 ****
  	xfs_iget.c \
  	xfs_attr_leaf.c \
  	xfs_attr.c \
- 	xfsrtstubs.c \
- 	xfsquotasstubs.c \
- 	xfsdmapistubs.c \
  	xfs_dmops.c \
  	xfs_qmops.c \
  	xfs_mountops.c \
--- 54,59 ----
***************
*** 81,86 ****
--- 78,87 ----
  	kmem.c \
  	kdb.c
  
+ #	xfsrtstubs.c \
+ #	xfsquotasstubs.c \
+ #	xfsdmapistubs.c \
+ 
  SRCS+=	opt_ddb.h
  
  .include <bsd.kmod.mk>

This patch & follow up at:
http://berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/sys/modules/xfs/Makefile.REL=ALL.diff
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon May 18 02:57:11 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119298 
Responsible-Changed-From-To: freebsd-fs->kan 
Responsible-Changed-By: kan 
Responsible-Changed-When: Mon May 18 16:35:36 UTC 2009 
Responsible-Changed-Why:  
I'll look at this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119298 

From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@freebsd.org,
 jhs@berklix.org
Cc:  
Subject: Re: kern/119298: [xfs] [patch] 7-Stable/sys/modules/xfs fails to make from world
Date: Mon, 18 May 2009 11:16:13 -0400

 There are actually zero-byte files in src/sys/gnu/fs/xfs/FreeBSD by that name.  
 Perhaps CTM doesn't handle creating empty files?
 
 -- 
 John Baldwin

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/119298: commit references a PR
Date: Mon, 18 May 2009 17:20:38 +0000 (UTC)

 Author: kan
 Date: Mon May 18 17:20:24 2009
 New Revision: 192314
 URL: http://svn.freebsd.org/changeset/base/192314
 
 Log:
   Remove empty files and do nto try to build them.
   Apparently, they are problematic for CTF users.
   
   PR:	119298
   Submitted by: Julian H. Stacey
 
 Deleted:
   head/sys/gnu/fs/xfs/FreeBSD/xfsdmapistubs.c
   head/sys/gnu/fs/xfs/FreeBSD/xfsquotasstubs.c
   head/sys/gnu/fs/xfs/FreeBSD/xfsrtstubs.c
 Modified:
   head/sys/modules/xfs/Makefile
 
 Modified: head/sys/modules/xfs/Makefile
 ==============================================================================
 --- head/sys/modules/xfs/Makefile	Mon May 18 17:18:40 2009	(r192313)
 +++ head/sys/modules/xfs/Makefile	Mon May 18 17:20:24 2009	(r192314)
 @@ -54,9 +54,6 @@ SRCS =  vnode_if.h \
  	xfs_iget.c \
  	xfs_attr_leaf.c \
  	xfs_attr.c \
 -	xfsrtstubs.c \
 -	xfsquotasstubs.c \
 -	xfsdmapistubs.c \
  	xfs_dmops.c \
  	xfs_qmops.c \
  	xfs_mountops.c \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Alexander Kabaev <kabaev@gmail.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: bug-followup@freebsd.org
Subject: Re: kern/119298: [xfs] [patch] 7-Stable/sys/modules/xfs fails to
 make from world
Date: Mon, 18 May 2009 13:33:36 -0400

 --Sig_/kpQ.Tm4gHt=z6HbRS+cZ8pB
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 On Mon, 18 May 2009 17:30:03 GMT
 John Baldwin <jhb@FreeBSD.org> wrote:
 
 > The following reply was made to PR kern/119298; it has been noted by
 > GNATS.
 >=20
 > From: John Baldwin <jhb@FreeBSD.org>
 > To: bug-followup@freebsd.org,
 >  jhs@berklix.org
 > Cc: =20
 > Subject: Re: kern/119298: [xfs] [patch] 7-Stable/sys/modules/xfs
 > fails to make from world Date: Mon, 18 May 2009 11:16:13 -0400
 >=20
 >  There are actually zero-byte files in src/sys/gnu/fs/xfs/FreeBSD by
 > that name. Perhaps CTM doesn't handle creating empty files?
 > =20
 >  --=20
 >  John Baldwin
 
 Exactly my suspicion and this is why I removed empty files with this
 change.
 
 --=20
 Alexander Kabaev
 
 --Sig_/kpQ.Tm4gHt=z6HbRS+cZ8pB
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.11 (FreeBSD)
 
 iD8DBQFKEZv5Q6z1jMm+XZYRAqxlAKC4O+HPy43qFNUHadVQfUEZOX9gnQCgvFCP
 r6IVVdDWrQgkC7x/4XWGS2k=
 =c40o
 -----END PGP SIGNATURE-----
 
 --Sig_/kpQ.Tm4gHt=z6HbRS+cZ8pB--
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Sun Feb 7 19:49:48 UTC 2010 
State-Changed-Why:  
THis is fixed in head and 8.x, mark patched pending MFC to 7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119298 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Fri Mar 15 23:34:37 UTC 2013 
State-Changed-Why:  
MFCed/fixed by now or it will never be MFCed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119298 
>Unformatted:
