From dan@kulesh.obluda.cz  Sun Dec 16 02:35:11 2007
Return-Path: <dan@kulesh.obluda.cz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CDABC16A418
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Dec 2007 02:35:11 +0000 (UTC)
	(envelope-from dan@kulesh.obluda.cz)
Received: from smtp1.kolej.mff.cuni.cz (smtp1.kolej.mff.cuni.cz [78.128.192.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 70D3613C442
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Dec 2007 02:35:11 +0000 (UTC)
	(envelope-from dan@kulesh.obluda.cz)
Received: from kulesh.obluda.cz (openvpn.ms.mff.cuni.cz [195.113.20.87])
	by smtp1.kolej.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id lBG2YuTR068132
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Dec 2007 03:34:57 +0100 (CET)
	(envelope-from dan@kulesh.obluda.cz)
Received: from kulesh.obluda.cz (localhost. [127.0.0.1])
	by kulesh.obluda.cz (8.14.2/8.14.2) with ESMTP id lBG2Yrdb001301
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Dec 2007 03:34:53 +0100 (CET)
	(envelope-from dan@kulesh.obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.14.2/8.14.1/Submit) id lBG2YrLm001300;
	Sun, 16 Dec 2007 03:34:53 +0100 (CET)
	(envelope-from dan)
Message-Id: <200712160234.lBG2YrLm001300@kulesh.obluda.cz>
Date: Sun, 16 Dec 2007 03:34:53 +0100 (CET)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [ PATCH ] Allow the cpufreq/p4tcc driver to detach
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         118739
>Category:       kern
>Synopsis:       [cpufreq] [patch] Allow the cpufreq/p4tcc driver to detach
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hiren
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 16 02:40:02 UTC 2007
>Closed-Date:    Fri May 17 04:12:06 UTC 2013
>Last-Modified:  Fri May 17 17:20:00 UTC 2013
>Originator:     Dan Lukes
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD 6.3-PRERELEASE #18: Sun Dec 16 03:05:00 CET 2007 i386
src/sys/i386/cpufreq/p4tcc.c,v 1.11.2.1 2005/10/25 20:52:44 njl

As far as I know the problem apply to current as well

>Description:
	The p4tcc driver has no detach method with no aparent reason

	As p4tcc is not standalone driver but part of cpufreq suite it block 
reloading of the other cpufreq subdrivers

>How-To-Repeat:
	kldunload cpufreq on hardware where p4tcc supported
>Fix:

	Add the detach method.

	It mean:

1. set CPU to Automatic mode 
2. deregister the driver
3. return NOERROR to upper layer

--- sys/i386/cpufreq/p4tcc.c.ORIG	2007-12-16 02:49:30.000000000 +0100
+++ sys/i386/cpufreq/p4tcc.c	2007-12-16 03:08:12.000000000 +0100
@@ -72,6 +72,7 @@
 static void	p4tcc_identify(driver_t *driver, device_t parent);
 static int	p4tcc_probe(device_t dev);
 static int	p4tcc_attach(device_t dev);
+static int	p4tcc_detach(device_t dev);
 static int	p4tcc_settings(device_t dev, struct cf_setting *sets,
 		    int *count);
 static int	p4tcc_set(device_t dev, const struct cf_setting *set);
@@ -83,6 +84,7 @@
 	DEVMETHOD(device_identify,	p4tcc_identify),
 	DEVMETHOD(device_probe,		p4tcc_probe),
 	DEVMETHOD(device_attach,	p4tcc_attach),
+	DEVMETHOD(device_detach,	p4tcc_detach),
 
 	/* cpufreq interface */
 	DEVMETHOD(cpufreq_drv_set,	p4tcc_set),
@@ -201,6 +203,25 @@
 }
 
 static int
+p4tcc_detach(device_t dev)
+{
+	struct est_softc *sc;
+	struct cf_setting set;
+	int error;
+
+	sc = device_get_softc(dev);
+
+	/*
+	 * Before we finish detach, switch to Automatic mode
+	 */
+	set.freq = 10000;
+	p4tcc_set(dev, &set);
+
+	error = cpufreq_unregister(dev);
+	return (error);
+}
+
+static int
 p4tcc_settings(device_t dev, struct cf_setting *sets, int *count)
 {
 	struct p4tcc_softc *sc;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-i386->freebsd-bugs 
Responsible-Changed-By: remko 
Responsible-Changed-When: Sun Dec 23 17:23:01 UTC 2007 
Responsible-Changed-Why:  
not something i386 specific 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118739 
Responsible-Changed-From-To: freebsd-bugs->hiren 
Responsible-Changed-By: hiren 
Responsible-Changed-When: Tue May 7 00:29:03 UTC 2013 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118739 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118739: commit references a PR
Date: Fri, 10 May 2013 22:43:34 +0000 (UTC)

 Author: hiren
 Date: Fri May 10 22:43:27 2013
 New Revision: 250487
 URL: http://svnweb.freebsd.org/changeset/base/250487
 
 Log:
   Adding a detach method to p4tcc driver.
   
   PR:	118739
   Submitted by:	Dan Lukes <dan@obluda.cz> (earlier version)
   Reviewed by:	jhb
   Approved by:	sbruno (mentor)
   MFC after:	1 week
 
 Modified:
   head/sys/x86/cpufreq/p4tcc.c
 
 Modified: head/sys/x86/cpufreq/p4tcc.c
 ==============================================================================
 --- head/sys/x86/cpufreq/p4tcc.c	Fri May 10 21:39:41 2013	(r250486)
 +++ head/sys/x86/cpufreq/p4tcc.c	Fri May 10 22:43:27 2013	(r250487)
 @@ -73,6 +73,7 @@ static int	p4tcc_features(driver_t *driv
  static void	p4tcc_identify(driver_t *driver, device_t parent);
  static int	p4tcc_probe(device_t dev);
  static int	p4tcc_attach(device_t dev);
 +static int	p4tcc_detach(device_t dev);
  static int	p4tcc_settings(device_t dev, struct cf_setting *sets,
  		    int *count);
  static int	p4tcc_set(device_t dev, const struct cf_setting *set);
 @@ -84,6 +85,7 @@ static device_method_t p4tcc_methods[] =
  	DEVMETHOD(device_identify,	p4tcc_identify),
  	DEVMETHOD(device_probe,		p4tcc_probe),
  	DEVMETHOD(device_attach,	p4tcc_attach),
 +	DEVMETHOD(device_detach,	p4tcc_detach),
  
  	/* cpufreq interface */
  	DEVMETHOD(cpufreq_drv_set,	p4tcc_set),
 @@ -213,6 +215,24 @@ p4tcc_attach(device_t dev)
  }
  
  static int
 +p4tcc_detach(device_t dev)
 +{
 +	struct cf_setting set;
 +	int error;
 +
 +	error = cpufreq_unregister(dev);
 +	if (error)
 +		return (error);
 +
 +	/*
 +	 * Before we finish detach, switch to Automatic mode.
 +	 */
 +	set.freq = 10000;
 +	p4tcc_set(dev, &set);
 +	return(0);
 +}
 +
 +static int
  p4tcc_settings(device_t dev, struct cf_setting *sets, int *count)
  {
  	struct p4tcc_softc *sc;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118739: commit references a PR
Date: Fri, 17 May 2013 04:09:12 +0000 (UTC)

 Author: hiren
 Date: Fri May 17 04:09:04 2013
 New Revision: 250734
 URL: http://svnweb.freebsd.org/changeset/base/250734
 
 Log:
   MFC: r250487
   
   Adding a detach method to p4tcc driver.
   
   PR:		118739
   Submitted by:	Dan Lukes <dan@obluda.cz> (earlier version)
   Reviewed by:	jhb
   Approved by:	sbruno (mentor)
 
 Modified:
   stable/9/sys/x86/cpufreq/p4tcc.c
 Directory Properties:
   stable/9/   (props changed)
   stable/9/sys/   (props changed)
 
 Modified: stable/9/sys/x86/cpufreq/p4tcc.c
 ==============================================================================
 --- stable/9/sys/x86/cpufreq/p4tcc.c	Fri May 17 03:55:03 2013	(r250733)
 +++ stable/9/sys/x86/cpufreq/p4tcc.c	Fri May 17 04:09:04 2013	(r250734)
 @@ -73,6 +73,7 @@ static int	p4tcc_features(driver_t *driv
  static void	p4tcc_identify(driver_t *driver, device_t parent);
  static int	p4tcc_probe(device_t dev);
  static int	p4tcc_attach(device_t dev);
 +static int	p4tcc_detach(device_t dev);
  static int	p4tcc_settings(device_t dev, struct cf_setting *sets,
  		    int *count);
  static int	p4tcc_set(device_t dev, const struct cf_setting *set);
 @@ -84,6 +85,7 @@ static device_method_t p4tcc_methods[] =
  	DEVMETHOD(device_identify,	p4tcc_identify),
  	DEVMETHOD(device_probe,		p4tcc_probe),
  	DEVMETHOD(device_attach,	p4tcc_attach),
 +	DEVMETHOD(device_detach,	p4tcc_detach),
  
  	/* cpufreq interface */
  	DEVMETHOD(cpufreq_drv_set,	p4tcc_set),
 @@ -213,6 +215,24 @@ p4tcc_attach(device_t dev)
  }
  
  static int
 +p4tcc_detach(device_t dev)
 +{
 +	struct cf_setting set;
 +	int error;
 +
 +	error = cpufreq_unregister(dev);
 +	if (error)
 +		return (error);
 +
 +	/*
 +	 * Before we finish detach, switch to Automatic mode.
 +	 */
 +	set.freq = 10000;
 +	p4tcc_set(dev, &set);
 +	return(0);
 +}
 +
 +static int
  p4tcc_settings(device_t dev, struct cf_setting *sets, int *count)
  {
  	struct p4tcc_softc *sc;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: hiren 
State-Changed-When: Fri May 17 04:11:46 UTC 2013 
State-Changed-Why:  
Fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118739 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/118739: commit references a PR
Date: Fri, 17 May 2013 17:16:36 +0000 (UTC)

 Author: hiren
 Date: Fri May 17 17:16:29 2013
 New Revision: 250743
 URL: http://svnweb.freebsd.org/changeset/base/250743
 
 Log:
   MFC: r250487
   
   Adding a detach method to p4tcc driver.
   
   PR:		118739
   Submitted by:	Dan Lukes <dan@obluda.cz> (earlier version)
   Reviewed by:	jhb
   Approved by:	sbruno (mentor)
 
 Modified:
   stable/8/sys/x86/cpufreq/p4tcc.c
 Directory Properties:
   stable/8/   (props changed)
   stable/8/sys/   (props changed)
   stable/8/sys/x86/   (props changed)
 
 Modified: stable/8/sys/x86/cpufreq/p4tcc.c
 ==============================================================================
 --- stable/8/sys/x86/cpufreq/p4tcc.c	Fri May 17 15:20:45 2013	(r250742)
 +++ stable/8/sys/x86/cpufreq/p4tcc.c	Fri May 17 17:16:29 2013	(r250743)
 @@ -73,6 +73,7 @@ static int	p4tcc_features(driver_t *driv
  static void	p4tcc_identify(driver_t *driver, device_t parent);
  static int	p4tcc_probe(device_t dev);
  static int	p4tcc_attach(device_t dev);
 +static int	p4tcc_detach(device_t dev);
  static int	p4tcc_settings(device_t dev, struct cf_setting *sets,
  		    int *count);
  static int	p4tcc_set(device_t dev, const struct cf_setting *set);
 @@ -84,6 +85,7 @@ static device_method_t p4tcc_methods[] =
  	DEVMETHOD(device_identify,	p4tcc_identify),
  	DEVMETHOD(device_probe,		p4tcc_probe),
  	DEVMETHOD(device_attach,	p4tcc_attach),
 +	DEVMETHOD(device_detach,	p4tcc_detach),
  
  	/* cpufreq interface */
  	DEVMETHOD(cpufreq_drv_set,	p4tcc_set),
 @@ -213,6 +215,24 @@ p4tcc_attach(device_t dev)
  }
  
  static int
 +p4tcc_detach(device_t dev)
 +{
 +	struct cf_setting set;
 +	int error;
 +
 +	error = cpufreq_unregister(dev);
 +	if (error)
 +		return (error);
 +
 +	/*
 +	 * Before we finish detach, switch to Automatic mode.
 +	 */
 +	set.freq = 10000;
 +	p4tcc_set(dev, &set);
 +	return(0);
 +}
 +
 +static int
  p4tcc_settings(device_t dev, struct cf_setting *sets, int *count)
  {
  	struct p4tcc_softc *sc;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
